[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

szdominik added inline comments. Comment at: clang-tidy/misc/CopyConstructorInitCheck.cpp:37 + + // We match here because we want one warning (and FixIt) for every ctor. + const auto Matches = match( aaron.ballman wrote: > Wouldn't registering this matcher

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

szdominik updated this revision to Diff 118617. szdominik marked 4 inline comments as done. szdominik added a comment. Small changes after aaron.ballman's comments. https://reviews.llvm.org/D33722 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/CopyConstructorInitCheck.cpp

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

szdominik added a comment. There wasn't any update on this check lately - can I help to make it better? https://reviews.llvm.org/D33722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

szdominik updated this revision to Diff 109564. szdominik marked 2 inline comments as done. szdominik added a comment. Herald added a subscriber: JDevlieghere. Fixed check-fixes lines in test cases. Updated matcher definition. https://reviews.llvm.org/D33722 Files:

[PATCH] D33645: [analyzer] Add missing documentation for static analyzer checkers

szdominik added a comment. In https://reviews.llvm.org/D33645#806852, @dcoughlin wrote: > Do you have commit access, or do you need someone to commit it for you? Thank you. I don't have, I'm quite new at this project. :) https://reviews.llvm.org/D33645

[PATCH] D33645: [analyzer] Add missing documentation for static analyzer checkers

szdominik updated this revision to Diff 106184. szdominik marked 9 inline comments as done. szdominik added a comment. Update with more idiomatic examples (from @dcoughlin). https://reviews.llvm.org/D33645 Files: www/analyzer/alpha_checks.html www/analyzer/available_checks.html

[PATCH] D33645: [analyzer] Add missing documentation for static analyzer checkers

szdominik added a comment. In https://reviews.llvm.org/D33645#805920, @dcoughlin wrote: > Who is the target of this documentation? Is it developers of the analyzer or > is it end users of the analyzer? If it is end users, it is unfortunate that > we've been just grabbing examples from the

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

szdominik updated this revision to Diff 103385. szdominik marked 4 inline comments as done. szdominik added a comment. Updated loop for searching the beginning of the initlist. https://reviews.llvm.org/D33722 Files: clang-tidy/misc/CMakeLists.txt

[PATCH] D33645: [analyzer] Add missing documentation for static analyzer checkers

szdominik updated this revision to Diff 103378. szdominik marked 3 inline comments as done. szdominik added a comment. Fixed alpha.core.CallAndMessageUnInitRefArg. https://reviews.llvm.org/D33645 Files: www/analyzer/alpha_checks.html www/analyzer/available_checks.html

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

szdominik added inline comments. Comment at: clang-tidy/misc/UndelegatedCopyOfBaseClassesCheck.cpp:92 + // Loop until the beginning of the initialization list. + while (!Tok.is(tok::r_paren)) +Lex.LexFromRawLexer(Tok); aaron.ballman wrote: > szdominik

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

szdominik added inline comments. Comment at: clang-tidy/misc/UndelegatedCopyOfBaseClassesCheck.cpp:92 + // Loop until the beginning of the initialization list. + while (!Tok.is(tok::r_paren)) +Lex.LexFromRawLexer(Tok); aaron.ballman wrote: > This doesn't

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

szdominik updated this revision to Diff 102807. szdominik marked 9 inline comments as done. szdominik added a comment. Rename check. Hoisted matcher, changed warning message & nits. https://reviews.llvm.org/D33722 Files: clang-tidy/misc/CMakeLists.txt

[PATCH] D33645: [analyzer] Add missing documentation for static analyzer checkers

szdominik marked 3 inline comments as done. szdominik added inline comments. Comment at: www/analyzer/alpha_checks.html:91 +(C, C++) +Check for logical errors for function calls and Objective-C message +expressions (e.g., uninitialized arguments, null function pointers,

[PATCH] D33645: [analyzer] Add missing documentation for static analyzer checkers

szdominik updated this revision to Diff 102650. szdominik added a comment. Delete modeling checkers (unix.StdCLibraryFunctions, cplusplus.SelfAssignment). Delete unix.MallocWithAnnotations. https://reviews.llvm.org/D33645 Files: www/analyzer/alpha_checks.html

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

szdominik marked 2 inline comments as done. szdominik added a comment. Warnings of the check's run on llvm/clang codebase. F3426875: undelegated-copy-of-base-classes-clangrun.txt https://reviews.llvm.org/D33722

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

szdominik updated this revision to Diff 100892. szdominik added a comment. Update with fixed docs. https://reviews.llvm.org/D33722 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/UndelegatedCopyOfBaseClassesCheck.cpp

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

szdominik created this revision. Herald added a subscriber: mgorny. Finds copy constructors where the constructor don't call the constructor of the base class. class X : public Copyable { X(const X& other) {}; // Copyable(other) is missing }; Also finds copy constructors where the

[PATCH] D33645: [analyzer] Add missing documentation for static analyzer checkers

szdominik created this revision. Some checks did not have documentation in the www/analyzer/ folder, and also some alpha checks became non-alpha. https://reviews.llvm.org/D33645 Files: www/analyzer/alpha_checks.html www/analyzer/available_checks.html www/analyzer/implicit_checks.html