[PATCH] D132640: [clang-tidy] Fix modernize-use-emplace to support alias cases

corona10 added a comment. In D132640#3757395 , @njames93 wrote: > In D132640#3757277 , @corona10 > wrote: > >> @njames93 Can we land this patch before it occurs conflicting with other >> changes? > > Yes, sorry

[PATCH] D132640: [clang-tidy] Fix modernize-use-emplace to support alias cases

corona10 added a comment. @njames93 Can we land this patch before it occurs conflicting with other changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132640/new/ https://reviews.llvm.org/D132640

[PATCH] D132640: [clang-tidy] Fix modernize-use-emplace to support alias cases

corona10 updated this revision to Diff 456173. corona10 added a comment. - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132640/new/ https://reviews.llvm.org/D132640 Files: clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck.cpp

[PATCH] D132640: [clang-tidy] Fix modernize-use-emplace to support alias cases

corona10 marked an inline comment as done. corona10 added a comment. Thanks! I updated the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132640/new/ https://reviews.llvm.org/D132640 ___

[PATCH] D132640: [clang-tidy] Fix modernize-use-emplace to support alias cases

corona10 updated this revision to Diff 456172. corona10 added a comment. Address code review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132640/new/ https://reviews.llvm.org/D132640 Files:

[PATCH] D132640: [clang-tidy] Fix modernize-use-emplace to support alias cases

corona10 added a comment. In D132640#3753744 , @njames93 wrote: > LGTM, just with a small nit. @njames93 Thank you but I can not find your comment about nit. Would you like to check the comment one more time? Repository: rG LLVM Github Monorepo

[PATCH] D132640: [clang-tidy] Fix modernize-use-emplace to support alias cases

corona10 updated this revision to Diff 455819. corona10 marked an inline comment as done. corona10 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132640/new/ https://reviews.llvm.org/D132640 Files:

[PATCH] D132640: [clang-tidy] Fix modernize-use-emplace to support alias cases

corona10 marked an inline comment as done. corona10 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/use-emplace.cpp:1059 priority_queue.emplace(Foo(13)); // CHECK-MESSAGES: :[[@LINE-1]]:26: warning: unnecessary temporary object

[PATCH] D132640: [clang-tidy] Fix modernize-use-emplace to support alias cases

corona10 updated this revision to Diff 455807. corona10 added a comment. - Update modernize-use-emplace to support emplacy cases for alias types. - Add new test - Update release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132640/new/

[PATCH] D132640: [clang-tidy] Fix modernize-use-emplace to support alias cases

corona10 updated this revision to Diff 455544. corona10 added a comment. Add unittest CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132640/new/ https://reviews.llvm.org/D132640 Files: clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck.cpp

[PATCH] D132640: [clang-tidy] Fix modernize-use-emplace to support alias cases

corona10 updated this revision to Diff 455536. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132640/new/ https://reviews.llvm.org/D132640 Files: clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck.cpp Index: clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck.cpp

[PATCH] D132640: [clang-tidy] Fix modernize-use-emplace to support alias cases

corona10 added a comment. I am new to this project. I know that I need to write a test also likewise: https://github.com/llvm/llvm-project/blob/b8655f7ff286b9ebcd97cdd24b9c8eb5b89b9651/clang-tools-extra/test/clang-tidy/checkers/modernize/use-emplace.cpp#L872-L884 Please let me know how to

[PATCH] D132640: [clang-tidy] Fix modernize-use-emplace to support alias cases

corona10 created this revision. Herald added subscribers: carlosgalvezp, jeroen.dobbelaere, xazax.hun. Herald added a project: All. corona10 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fix modernize-use-emplace to support