[PATCH] D59402: Fix-it hints for -Wmissing-{prototypes,variable-declarations}

ed accepted this revision. ed added a comment. This revision is now accepted and ready to land. The patch looks pretty good as far as I can see. That said, I've been out of the loop for quite a while, so do take my approval with a grain of salt. Thanks for working on this! \o/ Repository:

[PATCH] D41500: ananas: Add shared library support

This revision was automatically updated to reflect the committed changes. Closed by commit rC322064: ananas: Add shared library support (authored by ed, committed by ). Changed prior to commit: https://reviews.llvm.org/D41500?vs=127907=129045#toc Repository: rC Clang

[PATCH] D41500: ananas: Add shared library support

ed accepted this revision. ed added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D41500#965157, @zhmu wrote: > @ed I tried to keep things as much in line as the other > ::linker::Construct() functions do. Do you wish to stray from that path? > > I

[PATCH] D41500: ananas: Add shared library support

ed added inline comments. Comment at: lib/Driver/ToolChains/Ananas.cpp:93 CmdArgs.push_back(Args.MakeArgString(ToolChain.GetFilePath("crti.o"))); -CmdArgs.push_back(Args.MakeArgString(ToolChain.GetFilePath("crtbegin.o"))); +if (Args.hasArg(options::OPT_shared) ||

[PATCH] D32936: [clang] Add support for Ananas platform

ed added a comment. Final call: do any of you have any more feedback on this change? If not, I will go ahead and commit this change one of these days (together with https://reviews.llvm.org/D32937). Thanks, Ed https://reviews.llvm.org/D32936 ___

[PATCH] D32936: [clang] Add support for Ananas platform

ed accepted this revision. ed added a comment. This revision is now accepted and ready to land. These changes look all right to me, except that I'd like it if someone else could take a look at `Ananas.cpp` as well. Is anyone interested in taking a look? https://reviews.llvm.org/D32936

[PATCH] D29818: [libcxx] Threading support: Attempt to externalize system_clock::now() and steady_clock::now() implementations

ed added a comment. Worth mentioning: the latest version of macOS now supports `clock_gettime()`. Maybe better to leave the code as is and simply axe the Mach time code at some point in the future? https://reviews.llvm.org/D29818 ___ cfe-commits

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

ed added a comment. I'd be interested in seeing a feature like this appearing. Any chance this feature may be part of Clang 4.0? https://reviews.llvm.org/D23934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org