[PATCH] D159092: [APINotes] Initial support for C++ namespaces

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG993955662554: [APINotes] Initial support for C++ namespaces (authored by egorzhdan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D159092: [APINotes] Initial support for C++ namespaces

egorzhdan created this revision. egorzhdan added a reviewer: compnerd. Herald added a project: All. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This upstreams a part of the C++ namespaces support in Clang API Notes. The

[PATCH] D146434: [clang-format] Fix support for ObjC blocks with pointer return types

egorzhdan closed this revision. egorzhdan added a comment. Merged as 63d6659a . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146434/new/ https://reviews.llvm.org/D146434

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

egorzhdan added a comment. @compnerd @martong would you be OK with merging this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92797/new/ https://reviews.llvm.org/D92797 ___ cfe-commits mailing

[PATCH] D149850: [Clang][Modules] Support `requires cplusplus20` in a modulemap

egorzhdan closed this revision. egorzhdan added a comment. Looks like https://reviews.llvm.org/D150773 got there first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149850/new/ https://reviews.llvm.org/D149850

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

egorzhdan added a comment. Apologies for pinging an old review. Would it be possible to land this to facilitate future work to upstream API notes support? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92797/new/ https://reviews.llvm.org/D92797

[PATCH] D149850: [Clang][Modules] Support `requires cplusplus20` in a modulemap

egorzhdan added a comment. @Bigcheese, @ChuanqiXu, could you please take a look at this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149850/new/ https://reviews.llvm.org/D149850 ___ cfe-commits

[PATCH] D149850: [Clang][Modules] Support `requires cplusplus20` in a modulemap

egorzhdan created this revision. Herald added a project: All. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change adds the support for `requires cplusplus20` directive for a module declared in a Clang modulemap,

[PATCH] D138630: [modules] Fix marking `ObjCMethodDecl::isOverriding` when there a no overrides.

egorzhdan accepted this revision. egorzhdan added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138630/new/ https://reviews.llvm.org/D138630

[PATCH] D138434: [Clang][Sema] Added space after ',' in a warning

egorzhdan closed this revision. egorzhdan added a comment. Merged: https://reviews.llvm.org/rGcdfb65e5e7182a02005b3611aa28288890b9e296 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138434/new/ https://reviews.llvm.org/D138434

[PATCH] D138434: [Clang][Sema] Added space after ',' in a warning

egorzhdan accepted this revision. egorzhdan added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138434/new/ https://reviews.llvm.org/D138434

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

This revision was automatically updated to reflect the committed changes. Closed by commit rG97105e5bf70f: [libclang] Expose completion result kind in `CXCompletionResult` (authored by egorzhdan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

egorzhdan updated this revision to Diff 472171. egorzhdan added a comment. Preserve `CodeCompletionResult::ResultKind` and do the conversion to `CXCompletionResultKind` in `CIndexCodeCompletion.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

egorzhdan added inline comments. Comment at: clang/include/clang/Sema/CodeCompleteConsumer.h:755 - /// Describes the kind of result generated. - enum ResultKind { -/// Refers to a declaration. kadircet wrote: > egorzhdan wrote: > > kadircet wrote: > > > i

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

egorzhdan added inline comments. Herald added subscribers: Michael137, JDevlieghere. Comment at: clang/include/clang/Sema/CodeCompleteConsumer.h:755 - /// Describes the kind of result generated. - enum ResultKind { -/// Refers to a declaration. kadircet

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

egorzhdan updated this revision to Diff 471838. egorzhdan added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix clangd compilation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136844/new/

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

egorzhdan created this revision. egorzhdan added reviewers: arphaman, bnbarham. Herald added a subscriber: kadircet. Herald added a project: All. egorzhdan requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. This allows

[PATCH] D133105: [Clang][Comments] Fix `Index/comment-lots-of-unknown-commands.c`

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c232b086720: [Clang][Comments] Fix `Index/comment-lots-of-unknown-commands.c` (authored by egorzhdan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133105: [Clang][Comments] Fix `Index/comment-lots-of-unknown-commands.c`

egorzhdan created this revision. egorzhdan added a reviewer: aaronpuchert. Herald added a subscriber: arphaman. Herald added a project: All. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This re-enables a test after it was

[PATCH] D133009: [libclang] Fix conversion from `StringRef` to `CXString`

egorzhdan added inline comments. Comment at: clang/test/Index/comment-lots-of-unknown-commands.c:3 +// XFAIL: * + aaronpuchert wrote: > egorzhdan wrote: > > gribozavr2 wrote: > > > egorzhdan wrote: > > > > This test was never properly passing. Because of the

[PATCH] D132932: [Clang][Comments] Parse `` in doc comments correctly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0cb080933654: [Clang][Comments] Parse `img src=/` in doc comments correctly (authored by egorzhdan). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D132932: [Clang][Comments] Parse `` in doc comments correctly

egorzhdan updated this revision to Diff 456989. egorzhdan added a comment. Rebase to apply fixes to string conversion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132932/new/ https://reviews.llvm.org/D132932 Files:

[PATCH] D133009: [libclang] Fix conversion from `StringRef` to `CXString`

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c0935238527: [libclang] Fix conversion from `StringRef` to `CXString` (authored by egorzhdan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133009/new/

[PATCH] D133009: [libclang] Fix conversion from `StringRef` to `CXString`

egorzhdan added inline comments. Comment at: clang/test/Index/comment-lots-of-unknown-commands.c:3 +// XFAIL: * + gribozavr2 wrote: > egorzhdan wrote: > > This test was never properly passing. Because of the bug in string > > conversion, the printed comments

[PATCH] D133009: [libclang] Fix conversion from `StringRef` to `CXString`

egorzhdan added inline comments. Comment at: clang/test/Index/comment-lots-of-unknown-commands.c:3 +// XFAIL: * + This test was never properly passing. Because of the bug in string conversion, the printed comments contained the entire source file and not just

[PATCH] D133009: [libclang] Fix conversion from `StringRef` to `CXString`

egorzhdan updated this revision to Diff 456942. egorzhdan added a comment. XFAIL a test that was accidentally passing because of incorrect behavior Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133009/new/ https://reviews.llvm.org/D133009 Files:

[PATCH] D133009: [libclang] Fix conversion from `StringRef` to `CXString`

egorzhdan created this revision. egorzhdan added a reviewer: gribozavr2. Herald added a subscriber: arphaman. Herald added a project: All. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `CXString createRef(StringRef String)`

[PATCH] D132932: [Clang][Comments] Parse `` in doc comments correctly

egorzhdan marked an inline comment as done. egorzhdan added inline comments. Comment at: clang/tools/libclang/CXString.cpp:85 + if (String.empty()) +return createEmpty(); + gribozavr2 wrote: > Please split this change into a separate patch and add a unit

[PATCH] D132932: [Clang][Comments] Parse `` in doc comments correctly

egorzhdan marked an inline comment as done. egorzhdan added inline comments. Comment at: clang/test/Sema/warn-documentation.cpp:78 +/// Aaa bbb +int test_html_img4(int); + gribozavr2 wrote: > Could you also add these tests to >

[PATCH] D132932: [Clang][Comments] Parse `` in doc comments correctly

egorzhdan updated this revision to Diff 456674. egorzhdan added a comment. - Add tests for conversion of doc comments to HTML/XML - Fix a bug in `StringRef` -> `CXString` conversion logic for an empty string Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D132932: [Clang][Comments] Parse `` in doc comments correctly

egorzhdan created this revision. Herald added a project: All. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a valid HTML5 tag. Previously it triggered a Clang error (`HTML start tag prematurely ended, expected

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d0cc510516d: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD (authored by egorzhdan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

egorzhdan added a comment. Thanks @brad @3405691582 @MaskRay for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129654/new/ https://reviews.llvm.org/D129654 ___ cfe-commits mailing list

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

egorzhdan updated this revision to Diff 446223. egorzhdan added a comment. - Add a test for OpenBSD - Modify existing test file instead of adding a new file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129654/new/ https://reviews.llvm.org/D129654

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

egorzhdan created this revision. Herald added subscribers: krytarowski, arichardson, emaste. Herald added a project: All. egorzhdan requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. This is the same change as

[PATCH] D128814: [Clang][Preprocessor] Fix inconsistent `FLT_EVAL_METHOD` when compiling vs preprocessing

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f2cf3a21f3a: [Clang][Preprocessor] Fix inconsistent `FLT_EVAL_METHOD` when compiling vs… (authored by egorzhdan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128814: [Clang][Preprocessor] Fix inconsistent `FLT_EVAL_METHOD` when compiling vs preprocessing

egorzhdan updated this revision to Diff 440978. egorzhdan added a comment. Adjust commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128814/new/ https://reviews.llvm.org/D128814 Files: clang/lib/Lex/Preprocessor.cpp

[PATCH] D128814: [Clang][Preprocessor] Fix inconsistent `FLT_EVAL_METHOD` when compiling vs preprocessing

egorzhdan created this revision. egorzhdan added a reviewer: zahiraam. Herald added a project: All. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When running `clang -E -Ofast` on macOS, the `__FLT_EVAL_METHOD__` macro is `0`,

[PATCH] D127408: [clang][driver] Introduce new -fdriver-only flag

egorzhdan accepted this revision. egorzhdan added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127408/new/ https://reviews.llvm.org/D127408

[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

This revision was automatically updated to reflect the committed changes. Closed by commit rGe917801eddbe: [Clang][Driver] Fix include paths for `--sysroot /` on Linux (authored by egorzhdan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

egorzhdan updated this revision to Diff 432568. egorzhdan marked an inline comment as done. egorzhdan added a comment. Rebase & fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126289/new/ https://reviews.llvm.org/D126289 Files:

[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

egorzhdan marked 2 inline comments as done. egorzhdan added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:917 +/*static*/ std::string ToolChain::concat(const std::string , + const Twine , const Twine ,

[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

egorzhdan updated this revision to Diff 432539. egorzhdan added a comment. - Change arg type from `std::string` to `StringRef` - Remove unnecessary `//` • Remove unneeded test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126289/new/

[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

egorzhdan updated this revision to Diff 432256. egorzhdan added a comment. - Remove unnecessary trailing `/` - Add `-SAME` in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126289/new/ https://reviews.llvm.org/D126289 Files:

[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

egorzhdan added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:219 + + static std::string concat(const std::string , const Twine , +const Twine = "", const Twine = "", MaskRay wrote: > This can use

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

egorzhdan accepted this revision. egorzhdan added a comment. This revision is now accepted and ready to land. I'm not super familiar with concepts but this LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126031/new/

[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

egorzhdan created this revision. Herald added subscribers: pmatos, asb, jgravelle-google, sbc100, dschuff. Herald added a project: All. egorzhdan requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, aheejin. Herald added a project: clang. Currently if `--sysroot /`

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

egorzhdan added a comment. Looks like `index-concepts.cpp` is failing on Windows, @arphaman could you please take a look? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126031/new/ https://reviews.llvm.org/D126031 ___ cfe-commits mailing

[PATCH] D121911: [Clang] Add DriverKit support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f04e703bff3: [Clang] Add DriverKit support (authored by egorzhdan). Changed prior to commit:

[PATCH] D121911: [Clang] Add DriverKit support

egorzhdan updated this revision to Diff 429025. egorzhdan added a comment. Remove static analyzer changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121911/new/ https://reviews.llvm.org/D121911 Files: clang/include/clang/Basic/Attr.td

[PATCH] D122232: [clang][NFC] Refactor logic for picking standard library on Apple

egorzhdan accepted this revision. egorzhdan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122232/new/ https://reviews.llvm.org/D122232

[PATCH] D121911: [Clang] Add DriverKit support

egorzhdan updated this revision to Diff 416920. egorzhdan added a comment. Fix clang-format warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121911/new/ https://reviews.llvm.org/D121911 Files:

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

egorzhdan added a comment. In D121283#3392137 , @thakis wrote: > The commit message got a bit mutilated: > 33a9eac6aaa495fce6fd9b17cd48aa57a95461e6 > > > Just FYI in case you didn't

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG33a9eac6aaa4: [Clang] Support multiple attributes in a single pragma (authored by egorzhdan). Changed prior to commit:

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

egorzhdan updated this revision to Diff 416279. egorzhdan added a comment. - Fix off-by-one error in fix-it generation logic: the last SubjectMatchRule (`SubjectMatchRule_variable_not_is_parameter`) was not handled properly - Add a test for this Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D121911: [Clang] Add DriverKit support

egorzhdan created this revision. egorzhdan added a reviewer: arphaman. Herald added a reviewer: aaron.ballman. Herald added subscribers: dexonsmith, zzheng. Herald added a project: All. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

egorzhdan added a comment. Thanks for the review @aaron.ballman! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121283/new/ https://reviews.llvm.org/D121283 ___ cfe-commits mailing list

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

egorzhdan updated this revision to Diff 415527. egorzhdan added a comment. Merge two test files into one to speed up testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121283/new/ https://reviews.llvm.org/D121283 Files:

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

egorzhdan updated this revision to Diff 415199. egorzhdan added a comment. - Only allow one attribute syntax style per directive - Adjust documentation - Add a release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121283/new/

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

egorzhdan added a comment. In D121283#3379225 , @aaron.ballman wrote: > As a thought experiment, would it make sense to lift the restriction on the > number of attributes allowed in a pragma, but not allow multiple attribute > specifiers? I think

[PATCH] D121475: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array argument

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ca2f1938f96: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array… (authored by egorzhdan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121475: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array argument

egorzhdan updated this revision to Diff 415069. egorzhdan added a comment. Rename a lambda to improve readability Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121475/new/ https://reviews.llvm.org/D121475 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

egorzhdan added a comment. In D121283#3373560 , @aaron.ballman wrote: > why do we support multiple attribute *specifiers* in the same pragma? I would > not expect to be able to mix attribute styles in the same pragma given that > all of the individual

[PATCH] D121475: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array argument

egorzhdan created this revision. egorzhdan added a reviewer: gchatelet. Herald added a project: All. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change teaches the Sema logic for `__builtin_memcpy_inline` to implicitly

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

egorzhdan updated this revision to Diff 414068. egorzhdan added a comment. Remove unused include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121283/new/ https://reviews.llvm.org/D121283 Files: clang/include/clang/Basic/AttrSubjectMatchRules.h

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

egorzhdan created this revision. egorzhdan added a reviewer: arphaman. Herald added a subscriber: jdoerfert. Herald added a project: All. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds support for multiple attributes

[PATCH] D120160: [Clang] Add `-funstable` flag to enable unstable and experimental features

egorzhdan added a comment. Herald added a project: All. Apologies for landing this too quickly! I'll adjust this logic in a separate patch: https://reviews.llvm.org/D121141 In D120160#3352399 , @Mordante wrote: > `-funstable` is an option that controls

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

egorzhdan created this revision. Herald added a subscriber: dang. Herald added a project: All. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a follow-up for https://reviews.llvm.org/D120160 that addresses some of the

[PATCH] D120160: [Clang] Add `-funstable` flag to enable unstable and experimental features

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3cdc1c155b40: [Clang] Add `-funstable` flag to enable unstable and experimental features (authored by egorzhdan). Repository: rG LLVM Github

[PATCH] D120160: [Clang] Add `-funstable` flag to enable unstable and experimental features

egorzhdan created this revision. Herald added subscribers: dexonsmith, dang. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This new flag enables `__has_feature(cxx_unstable)` that would replace libc++ macros for individual

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

egorzhdan added a comment. Thank you @dgoldman, this approach looks good to me. I don't have anything to add other than what @sammccall has already commented. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119363/new/

[PATCH] D116052: [clang] fix out of bounds access in an empty string when lexing a _Pragma with missing string token

egorzhdan accepted this revision. egorzhdan added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116052/new/ https://reviews.llvm.org/D116052 ___ cfe-commits mailing list

[PATCH] D117931: [Clang] Support `address_space` attribute in `#pragma clang attribute

egorzhdan abandoned this revision. egorzhdan added a comment. Thanks @aaron.ballman for your feedback. I will probably abandon this change until we have a more compelling reason to apply attributes to types via pragmas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D117931: [Clang] Support `address_space` attribute in `#pragma clang attribute

egorzhdan created this revision. Herald added a reviewer: aaron.ballman. Herald added a subscriber: jdoerfert. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change adds support for type attributes (for example,

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

egorzhdan accepted this revision. egorzhdan added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117348/new/ https://reviews.llvm.org/D117348 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D116822: [Clang][Sema] Use VersionMap from SDKSettings for remapping tvOS and watchOS availability

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a32d2e74e5c: [Clang][Sema] Use VersionMap from SDKSettings for remapping tvOS and watchOS… (authored by egorzhdan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116822: [Clang][Sema] Use VersionMap from SDKSettings for remapping tvOS and watchOS availability

egorzhdan updated this revision to Diff 399327. egorzhdan added a comment. Add a test for a diagnostic without VersionMap & fix clang-format warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116822/new/ https://reviews.llvm.org/D116822 Files:

[PATCH] D116412: [Clang][Sema] Fix attribute mismatch warning for ObjC class properties

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfda47db8ee1d: [Clang][Sema] Fix attribute mismatch warning for ObjC class properties (authored by egorzhdan). Repository: rG LLVM Github Monorepo

[PATCH] D116412: [Clang][Sema] Fix attribute mismatch warning for ObjC class properties

egorzhdan updated this revision to Diff 398753. egorzhdan added a comment. Fix clang-format warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116412/new/ https://reviews.llvm.org/D116412 Files: clang/include/clang/AST/DeclObjC.h

[PATCH] D116412: [Clang][Sema] Fix attribute mismatch warning for ObjC class properties

egorzhdan updated this revision to Diff 398601. egorzhdan added a comment. Diagnose mismatches between class property of a class and a class property of its superclass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116412/new/

[PATCH] D116272: [Clang][Sema] Avoid crashing for va_arg expressions with bool argument

egorzhdan added a comment. In D116272#3228427 , @tstellar wrote: > We may have time to fit it in to the release, but no guarantees. Can you > file an issue for this? That would be great. I filed an issue:

[PATCH] D116272: [Clang][Sema] Avoid crashing for va_arg expressions with bool argument

egorzhdan added a comment. Thank you @aaron.ballman, I will try to get this patch into the next 13.0.x release. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116272/new/ https://reviews.llvm.org/D116272

[PATCH] D116822: [Clang][Sema] Use VersionMap from SDKSettings for remapping tvOS and watchOS availability

egorzhdan updated this revision to Diff 398192. egorzhdan added a comment. Remove accidental change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116822/new/ https://reviews.llvm.org/D116822 Files: clang/include/clang/Basic/DarwinSDKInfo.h

[PATCH] D116822: [Clang][Sema] Use VersionMap from SDKSettings for remapping tvOS and watchOS availability

egorzhdan created this revision. Herald added a reviewer: aaron.ballman. Herald added a subscriber: dexonsmith. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This makes the mapping between iOS & tvOS/watchOS versions more

[PATCH] D116615: [Clang] Extract availability mapping from VersionMap for watchOS/tvOS

egorzhdan updated this revision to Diff 397565. egorzhdan added a comment. Fix lint warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116615/new/ https://reviews.llvm.org/D116615 Files: clang/lib/Basic/DarwinSDKInfo.cpp

[PATCH] D116615: [Clang] Extract availability mapping from VersionMap for watchOS/tvOS

egorzhdan updated this revision to Diff 397541. egorzhdan added a comment. Add a test to verify that `iOS_tvOS` mapping is parsed correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116615/new/ https://reviews.llvm.org/D116615 Files:

[PATCH] D116615: [Clang] Extract availability mapping from VersionMap for watchOS/tvOS

egorzhdan created this revision. Herald added a subscriber: dexonsmith. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change makes it possible to extract iOS-to-another-platform version mappings from `VersionMap` in the

[PATCH] D116459: [Clang][Sema] Adjust formatting (NFC)

egorzhdan created this revision. Herald added a reviewer: aaron.ballman. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a preparation for another change in the watchOS/tvOS availability logic. It is extracted into a

[PATCH] D116412: [Clang][Sema] Fix attribute mismatch warning for ObjC class properties

egorzhdan created this revision. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If a class declares an instance property, and an inheritor class declares a class property with the same name, Clang Sema currently treats the

[PATCH] D116272: [Clang][Sema] Avoid crashing for va_arg expressions with bool argument

egorzhdan created this revision. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change fixes a compiler crash that was introduced in https://reviews.llvm.org/D103611: `Sema::BuildVAArgExpr` attempted to retrieve a