[PATCH] D116814: [clang-tidy] Accept string literal decay in conditional operator

estan added a comment. Ah thanks. Yea no worries. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116814/new/ https://reviews.llvm.org/D116814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D116814: [clang-tidy] Accept string literal decay in conditional operator

estan added a comment. BTW how are backports to release branches made in LLVM? (sorry if it's in the docs somewhere!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116814/new/ https://reviews.llvm.org/D116814

[PATCH] D116814: [clang-tidy] Accept string literal decay in conditional operator

estan added a comment.  Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116814/new/ https://reviews.llvm.org/D116814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D116814: [clang-tidy] Accept string literal decay in conditional operator

estan added a comment. Ah right, `Elvis Stansvik ` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116814/new/ https://reviews.llvm.org/D116814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D116814: [clang-tidy] Accept string literal decay in conditional operator

estan added a comment. Thanks @aaron.ballman. I don't have commit/push rights, so someone please commit for me when you got the time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116814/new/ https://reviews.llvm.org/D116814

[PATCH] D116814: Accept string literal decay in conditional operator

estan updated this revision to Diff 398177. estan added a comment. Add entry in clang-tools-extra/docs/ReleaseNotes.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116814/new/ https://reviews.llvm.org/D116814 Files:

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

estan commandeered this revision. estan added a reviewer: fiesh. estan added a comment. I think we can close this one now that https://reviews.llvm.org/D116378 has landed though, since this revision was originally only about warnings in system macros case which is now solved (?) I'll

[PATCH] D116814: Accept string literal decay in conditional operator

estan created this revision. Herald added subscribers: carlosgalvezp, kbarton, nemanjai. estan edited the summary of this revision. estan edited the summary of this revision. estan edited the summary of this revision. estan edited the summary of this revision. estan updated this revision to Diff

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

estan added a comment. Alright, yea I'll see what using std::array would mean for our code. In many cases we are just using plain arrays currently, and often they are just a way to get data in/out of these APIs (and for the out direction, we quickly go on to saving the data we got out into

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

estan added a comment. Yep thanks a lot for that @carlosgalvezp, getting the system macros sorted out will get rid of many warnings we were getting in our code base (seems the qDebug / qWarning macros in the Qt version we're are using violate this check on their own). Regarding decay in calls

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

estan added a comment. In D88833#3225842 , @aaron.ballman wrote: > In D88833#3224389 , @carlosgalvezp > wrote: > >> Please note: I have a patch that disables warnings from system macros for >> all clang-tidy

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

estan added a comment. In D88833#3222829 , @estan wrote: > Sounds good @aaron.ballman, let's wait for @fiesh. > > Though I realize now that the scope of this patch is probably not enough to > solve a problem we have in our code base. The check will warn

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

estan added a comment. @carlosgalvezp Oh yes, that would be even better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88833/new/ https://reviews.llvm.org/D88833 ___ cfe-commits mailing list

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

estan added a comment. That did the trick, thanks @aaron.ballman. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88833/new/ https://reviews.llvm.org/D88833 ___ cfe-commits mailing list

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

estan added a comment. Ah yes I had a hunch it had to be "clang;clang-tools-extra" so running a build with that now. Almost done. It crashed at the very end due to OOM while linking, but reduced parallelism now and running again. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

estan added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp:65 void ProBoundsArrayToPointerDecayCheck::registerMatchers(MatchFinder *Finder) { - // The only allowed array to pointer decay + // We only allowed

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

estan added a comment. @aaron.ballman A bit off topic, but I followed https://github.com/llvm/llvm-project/blob/main/README.md#getting-the-source-code-and-building-llvm to build and install llvm-project main branch as follows: git clone https://github.com/llvm/llvm-project.git cd

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

estan added a comment. And there he is :) I've never worked on LLVM / clang-tidy but could have a look at making it opt-in. Now we know the status at least. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88833/new/ https://reviews.llvm.org/D88833

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

estan added a comment. Sounds good @aaron.ballman, let's wait for @fiesh. Though I realize now that the scope of this patch is probably not enough to solve a problem we have in our code base. The check will warn about (for example) things like this: In a third party lib outside our control:

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

estan added a comment. @lebedev.ri @aaron.ballman I think the opt-in sounds good too. Are we waiting for @fiesh to implement this, or is the patch abandoned? Would be sad if it was stranded the way https://reviews.llvm.org/D31130 was, since I think many people are skipping this check due to

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

estan added a comment. It would be great to get something like this in. In our project we're currently using a kludge of overriding the `RULE_LAUNCH_COMPILE` CMake variable to insert our own shell script as the compiler. The script strips the clang-tidy invocation inserted by CMake if the