[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

rymiel added a comment. Shouldn't that regression already be handled by D155358 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154184/new/ https://reviews.llvm.org/D154184

[PATCH] D155358: [clang-format] Correctly annotate overloaded operator function name

rymiel accepted this revision. rymiel added a comment. Was caused by 3f3620e5c9ee0f7b64afc39e5a26c6f4cc5e7b37 , thank you for fixing it up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

rymiel accepted this revision. rymiel added a comment. This revision is now accepted and ready to land. Thanks, this probably makes more sense than what I did before Comment at: clang/lib/Format/TokenAnnotator.cpp:3320 + // Annotate */&/&& in `operator` function calls as

[PATCH] D153798: [clang-format] Correctly annotate operator free function call

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4986f3f2f220: [clang-format] Correctly annotate operator free function call (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D153798: [clang-format] Correctly annotate operator free function call

rymiel updated this revision to Diff 535859. rymiel added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153798/new/ https://reviews.llvm.org/D153798 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D153798: [clang-format] Correctly annotate operator free function call

rymiel added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:319 + Prev->Previous->isOneOf(tok::period, tok::arrow)) || + (!Line.MustBeDeclaration && !Line.InMacroBody); Contexts.back().IsExpression = OperatorCalledAsMemberFunction;

[PATCH] D153798: [clang-format] Correctly annotate operator free function call

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. rymiel requested review of this revision. The annotator correctly annotates an overloaded operator call when

[PATCH] D153641: [clang-format] Preserve AmpAmpTokenType in nested parentheses

This revision was automatically updated to reflect the committed changes. Closed by commit rG15e14f129fe2: [clang-format] Preserve AmpAmpTokenType in nested parentheses (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153641/new/

[PATCH] D153745: [clang-format] Fix bugs in annotating r_paren as C-style cast

rymiel accepted this revision. rymiel added a comment. It appears other operators aren't affected, after D153641 I would have not been surprised if && had become unary :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150848: [clang-format] Respect ColumnLimit 0 line breaks in inline asm

rymiel marked 2 inline comments as done. rymiel added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:4626-4627 + verifyFormat(Code1, Style); + EXPECT_EQ(Code2, format(Code2, Style)); + EXPECT_EQ(Code3, format(Code3, Style)); + owenpan

[PATCH] D153641: [clang-format] Preserve AmpAmpTokenType in nested parentheses

rymiel updated this revision to Diff 534220. rymiel added a comment. Add annotator test cases involving a lambda Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153641/new/ https://reviews.llvm.org/D153641 Files:

[PATCH] D153641: [clang-format] Preserve AmpAmpTokenType in nested parentheses

rymiel added a comment. @HazardyKnusperkeks I'm not sure why it didn't recurse already, given that you even documented that it doesn't, but I chose to trust in the Beyoncé rule. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153641/new/

[PATCH] D153641: [clang-format] Preserve AmpAmpTokenType in nested parentheses

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. rymiel requested review of this revision. When parsing a requires clause, the

[PATCH] D150848: [clang-format] Respect ColumnLimit 0 line breaks in inline asm

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7a38b3bfeb56: [clang-format] Respect ColumnLimit 0 line breaks in inline asm (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D150848: [clang-format] Respect ColumnLimit 0 lines breaks in inline asm

rymiel updated this revision to Diff 530486. rymiel added a comment. Apply suggestions from review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150848/new/ https://reviews.llvm.org/D150848 Files: clang/lib/Format/ContinuationIndenter.cpp

[PATCH] D150403: [clang-format] Adjust braced list detection (try 2)

rymiel added a comment. This patch also fixes https://github.com/llvm/llvm-project/issues/52911 (which is probably a duplicate anyway) Comment at: clang/lib/Format/UnwrappedLineParser.cpp:583-584 + ProbablyBracedList || + NextTok->is(tok::l_brace) &&

[PATCH] D150848: [clang-format] Respect ColumnLimit 0 lines breaks in inline asm

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. rymiel requested review of this revision. Previously, using ColumnLimit: 0 with

[PATCH] D150614: [clang-format] Ignore first token when finding MustBreak

This revision was automatically updated to reflect the committed changes. Closed by commit rG06763ea5d8f9: [clang-format] Ignore first token when finding MustBreak (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150614/new/

[PATCH] D150629: [clang-format] Don't allow template to be preceded by closing brace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe4d3e8880239: [clang-format] Dont allow template to be preceded by closing brace (authored by rymiel). Repository: rG LLVM Github Monorepo

[PATCH] D150629: [clang-format] Don't allow template to be preceded by closing brace

rymiel updated this revision to Diff 522776. rymiel added a comment. Add annotator tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150629/new/ https://reviews.llvm.org/D150629 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D150614: [clang-format] Ignore first token when finding MustBreak

rymiel added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:20136 "#ifdef _DEBUG\n" - "void bar()\n" - " {\n" - " }\n" + "void bar() {}\n" "#else\n"

[PATCH] D150614: [clang-format] Ignore first token when finding MustBreak

rymiel added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:20136 "#ifdef _DEBUG\n" - "void bar()\n" - " {\n" - " }\n" + "void bar() {}\n" "#else\n"

[PATCH] D150614: [clang-format] Ignore first token when finding MustBreak

rymiel added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:891-895 +for (const FormatToken *Tok = Line->First; Tok; Tok = Tok->Next) { + // Ignore the first token, because in this situation, it applies more + // to the last token of the

[PATCH] D150614: [clang-format] Ignore first token when finding MustBreak

rymiel updated this revision to Diff 522453. rymiel marked an inline comment as done. rymiel added a comment. Start iteration from second token Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150614/new/ https://reviews.llvm.org/D150614 Files:

[PATCH] D150629: [clang-format] Don't allow template to be preceded by closing brace

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. rymiel requested review of this revision. This check is similar to the right paren

[PATCH] D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine

rymiel accepted this revision. rymiel added a comment. This revision is now accepted and ready to land. I see nothing wrong with this patch alone as it currently stands, since it's a quite simple change to the LineJoiner, and I see it as one of the final stopgaps in clang-format's support for

[PATCH] D150614: [clang-format] Ignore first token when finding MustBreak

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. rymiel requested review of this revision. When in ColumnLimit 0, the formatter looks

[PATCH] D150057: [clang-format] Fix consecutive alignments in #else blocks

rymiel added inline comments. Comment at: clang/unittests/Format/FormatTestComments.cpp:2762 // These comments should *not* be aligned - EXPECT_NE( // change for EQ when fixed + EXPECT_EQ( // change for EQ when fixed "#if FOO\n" Should probably get