[clang] [clang] Predefined macros for float128 support (PR #67196)

https://github.com/echristo commented: In general this looks good. Since we don't have full compiler-rt support for this yet we may want to wait until that to merge. Alex is already looking at this and coordinating with his needs is probably the best solution.

Re: [PATCH] D51650: Implement target_clones multiversioning

I think you are these days too :) My offer was "past-past-me". I think you're probably ok here, I did a rough scan, but getting someone like Aaron for the attribute support would be good. On Fri, Nov 5, 2021 at 12:00 PM Erich Keane via Phabricator < revi...@reviews.llvm.org> wrote: > erichkeane

Re: [PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

Sounds good. It's a soft objection, mostly because if nothing else it puts us back where we were subject to some latent bugs, but perhaps not as bad as before (though I don't find having to use an assert build reassuring ;) Anyhow, go ahead and we'll figure out something else. On Tue, Apr 27,

Re: [PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

On Tue, Apr 27, 2021 at 8:01 AM Melanie Blower via Phabricator < revi...@reviews.llvm.org> wrote: > mibintc abandoned this revision. > mibintc added a comment. > > There was no resolution about what option name would be acceptable > Oh no, I'm sorry that you felt that way. I saw Vitaly's

Re: [PATCH] D97736: [Driver] Add a experimental option to link to LLVM libc.

On Fri, Mar 5, 2021 at 1:15 AM Siva Chandra via Phabricator < revi...@reviews.llvm.org> wrote: > sivachandra added a comment. > > In D97736#2605535 , @phosek > wrote: > > > Have you considered using an input linker script? We could generate > `libc.so`

[clang-tools-extra] 549e55b - Temporarily Revert "[clangd] Add Random Forest runtime for code completion."

Author: Eric Christopher Date: 2020-09-18T14:47:43-07:00 New Revision: 549e55b3d5634870aa9d42135f51ad46a6a0e347 URL: https://github.com/llvm/llvm-project/commit/549e55b3d5634870aa9d42135f51ad46a6a0e347 DIFF:

[clang] 05777ab - Temporarily Revert "[DebugInfo] Move constructor homing case in shouldOmitDefinition."

Author: Eric Christopher Date: 2020-08-24T21:51:31-07:00 New Revision: 05777ab941063192b9ccb1775358a83a2700ccc1 URL: https://github.com/llvm/llvm-project/commit/05777ab941063192b9ccb1775358a83a2700ccc1 DIFF:

Re: [PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

This would be because at that point the default cpu was that and it probably had something to do with fallbacks. At this point it can be changed I imagine to whatever makes sense. On Wed, Aug 19, 2020, 1:12 AM Craig Topper via Phabricator < revi...@reviews.llvm.org> wrote: > craig.topper added

Re: [PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

Ow. Can revert and reapply after we fix the caching problem perhaps? -eric On Tue, Aug 4, 2020 at 3:48 PM Nick Desaulniers via Phabricator < revi...@reviews.llvm.org> wrote: > nickdesaulniers added a comment. > > I just collected a perf profile for an entire build. >

Re: [PATCH] D85231: Protect against filenames with no extension at all.

Could maybe add an assert along with the patch as well as an assert only test? On Tue, Aug 4, 2020, 1:42 PM Sterling Augustine via Phabricator < revi...@reviews.llvm.org> wrote: > saugustine added a comment. > > The darwin-dsymutil.c tests this code path right now on line 33. I found > this

Re: [PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

Release+Asserts on x86_64-linux and the debug-info-codeview-buildinfo.c test. Sorry if the latter wasn't clear :) -eric On Fri, Jul 10, 2020 at 4:12 PM Alexandre Ganea wrote: > Thanks for letting me know Eric. What test fails exactly? What config? > > > > *De :* Eric Christopher > *Envoyé :*

Re: [PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

You'll probably want the assert as well: assert.h assertion failed at llvm-project/llvm/lib/MC/MCStreamer.cpp:134 in virtual void llvm::MCStreamer::emitIntValue(uint64_t, unsigned int): (isUIntN(8 * Size, Value) || isIntN(8 * Size, Value)) && "Invalid size" On Fri, Jul 10, 2020 at 4:03 PM Eric

Re: [PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

I'm seeing tests fail with a crash. Can we revert the patch and attempted fixes and start working from there? Stacktrace for the curious :) @ 0x56420187cbbe llvm::MCStreamer::emitIntValue() @ 0x5641fec38899 llvm::MCStreamer::emitInt16() @ 0x5641ff73b337

Re: [PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

On Sun, Jul 5, 2020 at 8:47 PM Arthur Eubanks via Phabricator < revi...@reviews.llvm.org> wrote: > aeubanks added a comment. > > In D83013#2132070 , @echristo > wrote: > > > Adding Chandler and Alina here as well. > > > > In general, I don't think that

[clang] 0861889 - [clang/llvm] As part of using inclusive language within

Author: Eric Christopher Date: 2020-06-20T16:03:58-07:00 New Revision: 0861889be103bf7bcf013768e913695ed94b50bf URL: https://github.com/llvm/llvm-project/commit/0861889be103bf7bcf013768e913695ed94b50bf DIFF:

[clang-tools-extra] da6332f - [clang-tidy] As part of using inclusive language within

Author: Eric Christopher Date: 2020-06-20T15:20:11-07:00 New Revision: da6332f5f9f15f7b182f27bc9b8edbf709b48093 URL: https://github.com/llvm/llvm-project/commit/da6332f5f9f15f7b182f27bc9b8edbf709b48093 DIFF:

[clang-tools-extra] ef455a5 - Update comment to be more clear.

Author: Eric Christopher Date: 2020-06-20T14:44:41-07:00 New Revision: ef455a55bcf2cfea04a99c361b182ad18b7f03f1 URL: https://github.com/llvm/llvm-project/commit/ef455a55bcf2cfea04a99c361b182ad18b7f03f1 DIFF:

[clang] 10563e1 - [Analysis/Transforms/Sanitizers] As part of using inclusive language

Author: Eric Christopher Date: 2020-06-20T00:42:26-07:00 New Revision: 10563e16aa2c432a883695ddd714da68751bbd77 URL: https://github.com/llvm/llvm-project/commit/10563e16aa2c432a883695ddd714da68751bbd77 DIFF:

[clang-tools-extra] 16897e4 - Update test file.

Author: Eric Christopher Date: 2020-06-19T23:13:28-07:00 New Revision: 16897e47baa2b7cd1f63f40f8355c372b841f83d URL: https://github.com/llvm/llvm-project/commit/16897e47baa2b7cd1f63f40f8355c372b841f83d DIFF:

[clang-tools-extra] 25ed42f - [clang-change-namespace] As part of using inclusive language

Author: Eric Christopher Date: 2020-06-19T23:01:42-07:00 New Revision: 25ed42f05d07d3ad85c58ee001752338211c911c URL: https://github.com/llvm/llvm-project/commit/25ed42f05d07d3ad85c58ee001752338211c911c DIFF:

Re: [PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white, black}list to -fsanitize-coverage-{allow,block}list

On Fri, Jun 19, 2020 at 10:43 PM Fangrui Song via Phabricator < revi...@reviews.llvm.org> wrote: > MaskRay added inline comments. > > > > Comment at: clang/docs/ClangCommandLineReference.rst:891 > > Restrict sanitizer coverage instrumentation exclusively to modules and >

[clang-tools-extra] d313cb6 - Update redirected output file.

Author: Eric Christopher Date: 2020-06-19T23:30:16-07:00 New Revision: d313cb6e956de9448e4b979763ee8d12ce4103cb URL: https://github.com/llvm/llvm-project/commit/d313cb6e956de9448e4b979763ee8d12ce4103cb DIFF:

[clang] 1f593f4 - [AST/Lex/Parse/Sema] As part of using inclusive language within

Author: Eric Christopher Date: 2020-06-20T01:15:32-07:00 New Revision: 1f593f46f35b3afb1ba6e4700285cf8fd1b81bc7 URL: https://github.com/llvm/llvm-project/commit/1f593f46f35b3afb1ba6e4700285cf8fd1b81bc7 DIFF:

[clang-tools-extra] a146991 - Update error to read a little better when an error occurs.

Author: Eric Christopher Date: 2020-06-19T23:34:30-07:00 New Revision: a1469914fd7542526693b07a26a0bdcaa27591a3 URL: https://github.com/llvm/llvm-project/commit/a1469914fd7542526693b07a26a0bdcaa27591a3 DIFF:

[clang-tools-extra] f8a463c - As part of using inclusive language within the llvm project,

Author: Eric Christopher Date: 2020-06-19T15:43:51-07:00 New Revision: f8a463c170964bff7e239bb8268a4927a4547d3c URL: https://github.com/llvm/llvm-project/commit/f8a463c170964bff7e239bb8268a4927a4547d3c DIFF:

[clang-tools-extra] 937c135 - As part of using inclusive language within the llvm project,

Author: Eric Christopher Date: 2020-06-19T15:41:06-07:00 New Revision: 937c135dd57e86ccd3fd64ca7b07915a75157986 URL: https://github.com/llvm/llvm-project/commit/937c135dd57e86ccd3fd64ca7b07915a75157986 DIFF:

[clang-tools-extra] f92011d - As part of using inclusive language within the llvm project,

Author: Eric Christopher Date: 2020-06-19T15:12:18-07:00 New Revision: f92011d875cfdca1ed97bf0ab6956364c604b578 URL: https://github.com/llvm/llvm-project/commit/f92011d875cfdca1ed97bf0ab6956364c604b578 DIFF:

Re: [clang] 059ba74 - Revert "[codeview] Put !heapallocsite on calls to operator new"

FWIW before you reapply this let me know. I've seen some other failures associated and would like to give it a run through. -eric On Sat, Jun 6, 2020 at 4:38 PM Douglas Yung via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Douglas Yung > Date: 2020-06-06T23:30:46Z > New

[clang] c554c5e - Fix full unrolling with new pass manager.

Author: Eric Christopher Date: 2020-05-29T20:08:21-07:00 New Revision: c554c5e159aee43c5cd8236e077817e9f29dea78 URL: https://github.com/llvm/llvm-project/commit/c554c5e159aee43c5cd8236e077817e9f29dea78 DIFF:

[clang] 97a133f - Temporarily Revert "[Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts"

Author: Eric Christopher Date: 2020-05-26T18:51:00-07:00 New Revision: 97a133f15724aa7ddf5d9b62dc9c0657a4efd115 URL: https://github.com/llvm/llvm-project/commit/97a133f15724aa7ddf5d9b62dc9c0657a4efd115 DIFF:

Re: [clang] d82538b - Fix -Wunused compiler warning.

Very much so. Also nice all_of use! I'd have never thought about that :) -eric On Mon, May 11, 2020 at 7:03 PM David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Mon, May 11, 2020 at 12:21 AM Haojian Wu via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >>

Re: [PATCH] D72281: [Matrix] Add matrix type to Clang.

FWIW this broke lldb builds due to an unhandled enumeration. I've fixed them in: commit cd7cb1f4ce3ffc8be1146eeba28ae7dc50089459 (origin/master, origin/HEAD) Author: Eric Christopher Date: Mon May 11 13:44:12 2020 -0700 Update lldb for rG10658691951f to avoid Werror messages around

[clang-tools-extra] 35edd70 - Temporarily revert "build: use `find_package(Python3)` if available"

Author: Eric Christopher Date: 2020-04-28T16:41:22-07:00 New Revision: 35edd704e0fda09e8e634515c0b451d4a8b6b914 URL: https://github.com/llvm/llvm-project/commit/35edd704e0fda09e8e634515c0b451d4a8b6b914 DIFF:

[clang] 35edd70 - Temporarily revert "build: use `find_package(Python3)` if available"

Author: Eric Christopher Date: 2020-04-28T16:41:22-07:00 New Revision: 35edd704e0fda09e8e634515c0b451d4a8b6b914 URL: https://github.com/llvm/llvm-project/commit/35edd704e0fda09e8e634515c0b451d4a8b6b914 DIFF:

Re: [PATCH] D78501: Add a facility to get system cache directory and use it in clangd

I've had to temporarily revert this as it was breaking some tests: .../sources/llvm-project/llvm/unittests/Support/Path.cpp:334:5: error: use of undeclared identifier 'set' set(Value); ^ 1 error generated. Happy to help diagnose this with you if you need some assistance.

[clang-tools-extra] faf2dce - Temporarily revert "Add a facility to get system cache directory and use it in clangd"

Author: Eric Christopher Date: 2020-04-28T15:49:46-07:00 New Revision: faf2dce1dd6ae25aa75d2685ac7bb27ec31e2ced URL: https://github.com/llvm/llvm-project/commit/faf2dce1dd6ae25aa75d2685ac7bb27ec31e2ced DIFF:

Re: [clang] 83f4372 - [CodeGen] fix clang test that runs the optimizer pipeline; NFC

Sure. That sounds great. Thanks! On Wed, Feb 26, 2020 at 10:45 AM Sanjay Patel wrote: > To be clear - the test is checking IR instructions, but it's checking -O1 > IR for various targets. > So there must be different expectations per target... > But I just tried a test of turning everything

Re: [PATCH] D74918: Add method to TargetInfo to get CPU cache line size

I'm agreed with James on all points fwiw. On Thu, Feb 27, 2020, 2:00 PM James Y Knight via Phabricator < revi...@reviews.llvm.org> wrote: > jyknight requested changes to this revision. > jyknight added a comment. > This revision now requires changes to proceed. > > In D74918#1885869

Re: [clang] 83f4372 - [CodeGen] fix clang test that runs the optimizer pipeline; NFC

I mean anything that's testing assembly output out of clang is less than ideal. There are some circumstances, but this doesn't seem like one of them. On Wed, Feb 26, 2020, 9:10 AM Sanjay Patel wrote: > The test file dates back to: > https://reviews.llvm.org/D5698 > ...and I'm not familiar with

Re: [clang] 83f4372 - [CodeGen] fix clang test that runs the optimizer pipeline; NFC

Is there any way to pull this test out of clang and as an opt test? What's it trying to test? -eric On Tue, Feb 25, 2020 at 6:15 AM Sanjay Patel via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Sanjay Patel > Date: 2020-02-25T09:13:49-05:00 > New Revision:

[clang-tools-extra] 28728bf - Fix a signed/unsigned warning promoted to error.

Author: Eric Christopher Date: 2020-02-18T17:49:22-08:00 New Revision: 28728bf06f556dc8be5bc1fa77129906ba68 URL: https://github.com/llvm/llvm-project/commit/28728bf06f556dc8be5bc1fa77129906ba68 DIFF:

Re: [clang] 24ab9b5 - Generalize the pass registration mechanism used by Polly to any third-party tool

On Wed, Jan 8, 2020 at 1:40 AM Serge Guelton wrote: > On Tue, Jan 07, 2020 at 04:57:29PM -0800, Eric Christopher wrote: > > > ; CHECK-EP-VECTORIZER-START-NEXT: Running pass: NoOpFunctionPass > > > +; CHECK-EXT: Running pass: {{.*}}::Bye on foo > > > > > > Why is this running on

Re: [clang] 24ab9b5 - Generalize the pass registration mechanism used by Polly to any third-party tool

On Wed, Jan 8, 2020 at 3:07 PM Michael Kruse wrote: > Am Di., 7. Jan. 2020 um 18:57 Uhr schrieb Eric Christopher via > cfe-commits : > >> Is there anything I should have done? Probably reaching llvm-dev before > >> commiting. Reaching the right reviewers has always bee

Re: [clang] 24ab9b5 - Generalize the pass registration mechanism used by Polly to any third-party tool

Hi Serge! Thanks for a lot of the answers here :) > > The proposed infrastructure makes this process smoother and non intrusive > to the > llvm-project codebase: all development can be done in a separate git repo, > integration is controlled through cmake flags, and integration to >

Re: [clang] 24ab9b5 - Generalize the pass registration mechanism used by Polly to any third-party tool

Hi Serge, I have a few questions here about this: In general this appears to be a lot more complex than the existing plugin solutions and requires quite a lot of custom cmake rules that are difficult to maintain. Why do we want this in general for the project? I understand the desire to make

Re: [PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

You can sign up for an account by emailing the admin account. On Thu, Dec 26, 2019, 5:04 PM Anton Yudintsev via Phabricator < revi...@reviews.llvm.org> wrote: > AntonYudintsev added a comment. > > I have found bug in clang-cl (win32 clang), related to recent inroduction > of

[clang] 2369560 - Fix -Wunused-lambda-capture warnings.

Author: Eric Christopher Date: 2019-12-26T15:27:21-08:00 New Revision: 2369560f4a7720b19edfbf9de14ef061307ff773 URL: https://github.com/llvm/llvm-project/commit/2369560f4a7720b19edfbf9de14ef061307ff773 DIFF:

Re: [PATCH] D71486: [clang-tools-extra] Fix switch coverage warning

On Fri, Dec 13, 2019 at 1:18 PM Dávid Bolvanský via Phabricator < revi...@reviews.llvm.org> wrote: > xbolva00 added a comment. > > In D71486#1784079 , @sammccall > wrote: > > > It should be possible to test this by adapting a test case from the > original

[clang-tools-extra] 5623bd5 - Fix -Wswitch-coverage warning in clang-tidy after ak_addrspace introduction.

Author: Eric Christopher Date: 2019-12-13T12:57:48-08:00 New Revision: 5623bd52acd34db2e9cfc11d1510407610a14db0 URL: https://github.com/llvm/llvm-project/commit/5623bd52acd34db2e9cfc11d1510407610a14db0 DIFF:

Re: [PATCH] D71419: [clang] [test] Disable the test exhausting stack on NetBSD

No worries, it happens. On Thu, Dec 12, 2019, 10:59 PM Michał Górny wrote: > On Thu, 2019-12-12 at 14:47 -0800, Eric Christopher wrote: > > As a quick note, this broke the test because you didn't update the line > > numbers in the checks. > > > > Fixed thusly: > > > > echristo@athyra

Re: [PATCH] D71419: [clang] [test] Disable the test exhausting stack on NetBSD

As a quick note, this broke the test because you didn't update the line numbers in the checks. Fixed thusly: echristo@athyra ~/r/llvm-project> git push To github.com:llvm/llvm-project.git 6bed43f3c40..259a9b10390 master -> master :) -eric On Thu, Dec 12, 2019 at 12:25 PM Petr Hosek via

[clang] 259a9b1 - Update line number after previous patch added an additional unsupported

Author: Eric Christopher Date: 2019-12-12T14:45:05-08:00 New Revision: 259a9b1039093a1d036c1e6efcae699873f93ba5 URL: https://github.com/llvm/llvm-project/commit/259a9b1039093a1d036c1e6efcae699873f93ba5 DIFF:

Re: [clang] 7f9b513 - Reapply af57dbf12e54 "Add support for options -frounding-math, ftrapping-math, -ffp-model=, and -ffp-exception-behavior="

So you left some debugging code in that I've fixed thusly: "Enclosing function uses fp intrinsics" commit f4a7d5659df7cb56c1baa34a39e9fe2639472741 Author: Eric Christopher Date: Tue Dec 10 15:02:29 2019 -0800 Remove debugging printf and reformat code. On Thu, Dec 5, 2019 at 3:48 AM

[clang] f4a7d56 - Remove debugging printf and reformat code.

Author: Eric Christopher Date: 2019-12-10T15:04:45-08:00 New Revision: f4a7d5659df7cb56c1baa34a39e9fe2639472741 URL: https://github.com/llvm/llvm-project/commit/f4a7d5659df7cb56c1baa34a39e9fe2639472741 DIFF:

Re: [clang] d82b6ba - Revert "[DWARF5] Start emitting DW_AT_dwo_name when -gdwarf-5 is specified."

You don't need to revert for a missing differential revision, just close the revision yourself :) -eric On Tue, Dec 10, 2019 at 11:51 AM Sourabh Singh Tomar via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Sourabh Singh Tomar > Date: 2019-12-11T01:20:40+05:30 > New Revision:

[clang-tools-extra] 52b1c94 - Turn off unused variable checking here since we're explicitly adding

Author: Eric Christopher Date: 2019-12-09T19:14:04-08:00 New Revision: 52b1c94a5fe47c8bb5e189bc40bfd50255ce5795 URL: https://github.com/llvm/llvm-project/commit/52b1c94a5fe47c8bb5e189bc40bfd50255ce5795 DIFF:

[clang] 9c6b7f6 - Revert "[ARM][MVE] Add intrinsics for immediate shifts."

Author: Eric Christopher Date: 2019-12-09T16:47:38-08:00 New Revision: 9c6b7f68b807250e7c3aa01938339fdbd239c4ea URL: https://github.com/llvm/llvm-project/commit/9c6b7f68b807250e7c3aa01938339fdbd239c4ea DIFF:

Re: [PATCH] D65410: [PassManager] First Pass implementation at -O1 pass pipeline

Aha, found it in the revert. Bunch of tests use -O1 and probably have something specific in O1 they wanted. -eric On Mon, Nov 25, 2019 at 8:55 PM Eric Christopher wrote: > > Usually nice to give a link if there is one :) > > On Mon, Nov 25, 2019, 8:42 PM Muhammad Omair Javaid via Phabricator >

Re: [PATCH] D65410: [PassManager] First Pass implementation at -O1 pass pipeline

Usually nice to give a link if there is one :) On Mon, Nov 25, 2019, 8:42 PM Muhammad Omair Javaid via Phabricator < revi...@reviews.llvm.org> wrote: > omjavaid reopened this revision. > omjavaid added a comment. > This revision is now accepted and ready to land. > > Re-opening this because I

[clang] 8ff85ed - As a follow-up to my initial mail to llvm-dev here's a first pass at the O1 described there.

Author: Eric Christopher Date: 2019-11-25T17:16:46-08:00 New Revision: 8ff85ed905a7306977d07a5cd67ab4d5a56fafb4 URL: https://github.com/llvm/llvm-project/commit/8ff85ed905a7306977d07a5cd67ab4d5a56fafb4 DIFF:

[clang-tools-extra] e807569 - Fix an unused variable warning where a variable was only used in an assert.

Author: Eric Christopher Date: 2019-11-25T15:29:33-08:00 New Revision: e8075692589dc1274585bd7445f3e3b830b96c69 URL: https://github.com/llvm/llvm-project/commit/e8075692589dc1274585bd7445f3e3b830b96c69 DIFF:

Re: [PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

The C bindings, in general, don't have stability guarantees outside of a few cases. Whitequark owns all of this now though :) -eric On Tue, Nov 19, 2019 at 1:38 PM Adrian Prantl via Phabricator wrote: > > aprantl added a subscriber: echristo. > aprantl added a comment. > > In D70111#1752215

Re: [PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

No, it's just the bug that Jorge found. I understand it might have highlighted an existing bug, but reverting back to clean is the best bet here and then we can recommit when we get the latent bug fixed :) On Mon, Nov 18, 2019 at 11:08 AM Melanie Blower via Phabricator wrote: > > mibintc added a

Re: [PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

Hi All, I've gone ahead and temporarily reverted here: echristo@jhereg ~/s/llvm-project> git push To github.com:llvm/llvm-project.git a77b66a0562..30e7ee3c4ba master -> master and we can just reapply when the issues are fixed. Thanks :) -eric On Mon, Nov 18, 2019 at 6:58 AM Melanie Blower

[clang] 30e7ee3 - Temporarily Revert "Add support for options -frounding-math, ftrapping-math, -ffp-model=, and -ffp-exception-behavior="

Author: Eric Christopher Date: 2019-11-18T10:46:48-08:00 New Revision: 30e7ee3c4bac4a12ea584a879aa320bd4e035cc2 URL: https://github.com/llvm/llvm-project/commit/30e7ee3c4bac4a12ea584a879aa320bd4e035cc2 DIFF:

Re: r374841 - [Modules][PCH] Hash input files content

This was breaking a few bots and I couldn't find you on irc so I've reverted it thusly: echristo@jhereg ~/s/llvm-project> git llvm push Pushing 1 commit: 175b1b856ea Temporarily Revert [Modules][PCH] Hash input files content as it's breaking a few bots. Sending

r374842 - Temporarily Revert [Modules][PCH] Hash input files content

Author: echristo Date: Mon Oct 14 16:14:24 2019 New Revision: 374842 URL: http://llvm.org/viewvc/llvm-project?rev=374842=rev Log: Temporarily Revert [Modules][PCH] Hash input files content as it's breaking a few bots. This reverts r374841 (git commit 2a1386c81de504b5bda44fbecf3f7b4cdfd748fc)

r374840 - Add -fno-experimental-pass-manager to make clear which pass manager

Author: echristo Date: Mon Oct 14 16:01:48 2019 New Revision: 374840 URL: http://llvm.org/viewvc/llvm-project?rev=374840=rev Log: Add -fno-experimental-pass-manager to make clear which pass manager we're running and to make flipping the default not regress testing. Modified:

Re: [PATCH] D68535: Fix loop unrolling initialization in the new pass manager

Thanks for the text - I didn't have anything to add or change so I just used it verbatim :) Committed thusly: Committed revision 374838. Committed f64329154c3 to svn. On Mon, Oct 7, 2019 at 9:36 AM Alina Sbirlea via Phabricator wrote: > > asbirlea added a comment. > > Maybe elaborate in the

r374838 - In the new pass manager use PTO.LoopUnrolling to determine when and how

Author: echristo Date: Mon Oct 14 15:56:07 2019 New Revision: 374838 URL: http://llvm.org/viewvc/llvm-project?rev=374838=rev Log: In the new pass manager use PTO.LoopUnrolling to determine when and how we will unroll loops. Also comment a few occasions where we need to know whether or not we're

Re: [PATCH] D67216: [cfi] Add flag to always generate call frame information

That said, prior art in gcc in this area: -fasynchronous-unwind-tables Generate unwind table in DWARF format, if supported by target machine. The table is exact at each instruction boundary, so it can be used for stack unwinding from asynchronous events (such as debugger or garbage collector).

Re: r366076 - fix unnamed fiefield issue and add tests for __builtin_preserve_access_index intrinsic

I'm going to cheat and make Nick do it :) -eric On Mon, Jul 15, 2019 at 5:12 PM Yonghong Song wrote: > > HI, Eric, > > No problem! > > I just tried the following cmake (removing -DLLVM_ENABLE_ASSERTIONS=ON which > is used in my previous build) > > cmake -G "Unix Makefiles"

Re: r366146 - add -fthinlto-index= option to clang-cl

Hi Bob, I've temporarily reverted this here: echristo@jhereg ~/s/llvm-project> git llvm push Pushing 1 commit: 1dbd2f85903 Temporarily revert "add -fthinlto-index= option to clang-cl" Sendingcfe/trunk/include/clang/Driver/Options.td Deleting

r366157 - Temporarily revert "add -fthinlto-index= option to clang-cl"

Author: echristo Date: Mon Jul 15 17:02:40 2019 New Revision: 366157 URL: http://llvm.org/viewvc/llvm-project?rev=366157=rev Log: Temporarily revert "add -fthinlto-index= option to clang-cl" This is causing testsuite failures on (at least) darwin release+asserts. This reverts commit r366146.

Re: r366076 - fix unnamed fiefield issue and add tests for __builtin_preserve_access_index intrinsic

Just wanted to let you know I've temporarily reverted this here: echristo@jhereg ~/s/llvm-project> git llvm push Pushing 1 commit: ba7decf8c91 Temporarily Revert "fix unnamed fiefield issue and add tests for __builtin_preserve_access_index intrinsic" Sending

r366155 - Temporarily Revert "fix unnamed fiefield issue and add tests for __builtin_preserve_access_index intrinsic"

Author: echristo Date: Mon Jul 15 16:49:31 2019 New Revision: 366155 URL: http://llvm.org/viewvc/llvm-project?rev=366155=rev Log: Temporarily Revert "fix unnamed fiefield issue and add tests for __builtin_preserve_access_index intrinsic" The commit had tests that would only work with names in

r362462 - Remove test/CodeGen/builtin-stackaddress.c as it duplicates

Author: echristo Date: Mon Jun 3 16:16:06 2019 New Revision: 362462 URL: http://llvm.org/viewvc/llvm-project?rev=362462=rev Log: Remove test/CodeGen/builtin-stackaddress.c as it duplicates test/CodeGen/2004-02-13-BuiltinFrameReturnAddress.c. Differential Revision:

Re: [PATCH] D62133: test/CodeGen/builtin-stackaddress.c duplicates test/CodeGen/2004-02-13-BuiltinFrameReturnAddress.c

Will do. On Sun, Jun 2, 2019 at 5:43 AM A. Skrobov via Phabricator wrote: > > t.yomitch added a comment. > > Thanks Eric! > I don't have commit access; could someone please commit this for me? > > > Repository: > rC Clang > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D62133/new/ >

Re: r360403 - Change -gz and -Wa, --compress-debug-sections to use gABI compression (SHF_COMPRESSED)

Hi Ray, I've temporarily reverted this here: echristo@jhereg ~/s/llvm-project> git llvm push Pushing 1 commit: fda79815a33 Temporarily revert "Change -gz and -Wa,--compress-debug-sections to use gABI compression (SHF_COMPRESSED)" Sendingcfe/trunk/docs/ReleaseNotes.rst Sending

r360703 - Temporarily revert "Change -gz and -Wa, --compress-debug-sections to use gABI compression (SHF_COMPRESSED)"

Author: echristo Date: Tue May 14 12:40:42 2019 New Revision: 360703 URL: http://llvm.org/viewvc/llvm-project?rev=360703=rev Log: Temporarily revert "Change -gz and -Wa,--compress-debug-sections to use gABI compression (SHF_COMPRESSED)" This affects users of older (pre 2.26) binutils in such a

r360104 - Fix typo in risc-v register aliases.

Author: echristo Date: Mon May 6 17:45:47 2019 New Revision: 360104 URL: http://llvm.org/viewvc/llvm-project?rev=360104=rev Log: Fix typo in risc-v register aliases. Patch by John. Differential Revision: https://reviews.llvm.org/D61464 Modified: cfe/trunk/lib/Basic/Targets/RISCV.cpp

Re: [PATCH] D61464: [RiscV] Typo in register aliases

I'll get it. On Sat, May 4, 2019 at 3:47 AM John LLVM via Phabricator wrote: > > JohnLLVM added a comment. > > What should I do now? I do not have rights to commit. > > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D61464/new/ > > https://reviews.llvm.org/D61464 > > >

Re: [PATCH] D58326: [Driver][Gnu] Support -nolibc flag

Weird. Ok. On Sat, Feb 16, 2019, 5:20 PM Petr Hosek via Phabricator < revi...@reviews.llvm.org> wrote: > phosek created this revision. > phosek added reviewers: echristo, mcgrathr. > Herald added a project: clang. > Herald added a subscriber: cfe-commits. > > This can be used to disable libc

Re: r352690 - [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

Looks like this broke optimized asan builds via an assert in SCCP. I'll see what I can do about a testcase (or Eric will), however, would you mind reverting in the meantime? Thanks! -eric On Wed, Jan 30, 2019 at 4:41 PM Julian Lettner via cfe-commits < cfe-commits@lists.llvm.org> wrote: >

Re: [PATCH] D53919: [X86] Don't allow illegal vector types to return by direct value on x86-64.

On Mon, Nov 5, 2018 at 9:45 AM H.J Lu via Phabricator < revi...@reviews.llvm.org> wrote: > hjl.tools added a comment. > > In https://reviews.llvm.org/D53919#1287510, @echristo wrote: > > > In https://reviews.llvm.org/D53919#1282994, @hjl.tools wrote: > > > > > In

Re: [PATCH] D52703: Allow ifunc resolvers to accept arguments

SGTM. On Tue, Oct 9, 2018, 7:57 AM James Y Knight via Phabricator < revi...@reviews.llvm.org> wrote: > jyknight accepted this revision. > jyknight added a comment. > This revision is now accepted and ready to land. > > Given that there's no technical reason for the compiler to prohibit this >

Re: r342668 - Add testcases for r342667.

" >>>>> "-nostdsysteminc" >>>>> "C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\test\Preprocessor\include-leading-nonalpha-suggest.c" >>>>> "-verify" >>>>> # comman

Re: r342668 - Add testcases for r342667.

windows10pro-fast\llvm.src\tools\clang\test\Preprocessor\include-leading-nonalpha-suggest.c >> Line 3: '/empty_file_to_include.h' file not found, did you mean >> 'empty_file_to_include.h'? >> >> 1 error generated. >> >> >> error: command failed with exit status: 1 &

Re: r342668 - Add testcases for r342667.

processor\include-leading-nonalpha-suggest.c > Line 3: '/empty_file_to_include.h' file not found, did you mean > 'empty_file_to_include.h'? > > 1 error generated. > > > error: command failed with exit status: 1 > > Oof. Thanks. If I don't have something in 10 minutes I'll

r342668 - Add testcases for r342667.

Author: echristo Date: Thu Sep 20 10:22:43 2018 New Revision: 342668 URL: http://llvm.org/viewvc/llvm-project?rev=342668=rev Log: Add testcases for r342667. Added: cfe/trunk/test/Preprocessor/include-leading-nonalpha-no-suggest.c

r342667 - r342177 introduced a hint in cases where an #included file is not found. It tries to find a suggestion by removing leading or trailing non-alphanumeric characters and checking if a matching

Author: echristo Date: Thu Sep 20 10:21:56 2018 New Revision: 342667 URL: http://llvm.org/viewvc/llvm-project?rev=342667=rev Log: r342177 introduced a hint in cases where an #included file is not found. It tries to find a suggestion by removing leading or trailing non-alphanumeric characters

Re: r342053 - [CodeGen] Align rtti and vtable data

Thanks for looking Jordan! On Mon, Sep 17, 2018, 11:16 AM Jordan Rupprecht wrote: > > Interesting, what kind of failures? > > > > If they are causing you problems, of course feel free to revert. > > > > Dave > > Turns out they are all real issues which running the test under asan > mode flags

Re: r342053 - [CodeGen] Align rtti and vtable data

Hi David, I'm seeing test failures after this patch. I'm trying to get a test case reduced, but can we revert until we figure it out? Thanks! -eric On Wed, Sep 12, 2018 at 7:10 AM David Green via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: dmgreen > Date: Wed Sep 12 07:09:06

Re: [PATCH] D51358: [driver] Do not pass "-flavor old-gnu" option to LLD linker

LGTM On Tue, Aug 28, 2018, 7:49 AM Simon Atanasyan via Phabricator < revi...@reviews.llvm.org> wrote: > atanasyan created this revision. > atanasyan added reviewers: echristo, ruiu. > > The "-flavor old-gnu" option were introduced to enable old version of LLD > ELF linker implementation. This

Re: r338321 - Fix use of uninitialized variable in r338299

On Tue, Jul 31, 2018 at 3:59 PM wrote: > What might be missing is the impl of CreateMemberType: > > llvm::DIType *CGDebugInfo::CreateMemberType(llvm::DIFile *Unit, QualType > FType, > StringRef Name, uint64_t > *Offset) { >llvm::DIType *FieldTy =

Re: r338321 - Fix use of uninitialized variable in r338299

I'm probably missing something, from looking here: FieldOffset = 0; if (CGM.getLangOpts().OpenCL) { FType = CGM.getContext().IntTy; EltTys.push_back(CreateMemberType(Unit, FType, "__size", )); EltTys.push_back(CreateMemberType(Unit, FType, "__align", )); } else { FType =

Re: r338321 - Fix use of uninitialized variable in r338299

Is 0 right for FieldOffset for OpenCL here? Seems a little odd. -eric On Mon, Jul 30, 2018 at 3:56 PM Scott Linder via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: scott.linder > Date: Mon Jul 30 15:52:07 2018 > New Revision: 338321 > > URL:

r338328 - Revert "Add a definition for FieldSize that seems to make sense here."

Author: echristo Date: Mon Jul 30 16:21:51 2018 New Revision: 338328 URL: http://llvm.org/viewvc/llvm-project?rev=338328=rev Log: Revert "Add a definition for FieldSize that seems to make sense here." This reverts commit r338327, the problem was previously fixed in r338321. Modified:

r338327 - Add a definition for FieldSize that seems to make sense here.

Author: echristo Date: Mon Jul 30 16:17:27 2018 New Revision: 338327 URL: http://llvm.org/viewvc/llvm-project?rev=338327=rev Log: Add a definition for FieldSize that seems to make sense here. This could be sunk out of the if statements, but fix the warning for now. Modified:

r337321 - Remove unnecessary trailing ; in macro intrinsic definition.

Author: echristo Date: Tue Jul 17 13:22:17 2018 New Revision: 337321 URL: http://llvm.org/viewvc/llvm-project?rev=337321=rev Log: Remove unnecessary trailing ; in macro intrinsic definition. Modified: cfe/trunk/lib/Headers/avx512dqintrin.h Modified: cfe/trunk/lib/Headers/avx512dqintrin.h

  1   2   3   4   5   >