[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

2023-02-07 Thread Erik Desjardins via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd768b97424f9: [Support] change StringMap hash function from djbHash to xxHash (authored by erikdesjardins). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

2023-02-04 Thread Erik Desjardins via Phabricator via cfe-commits
erikdesjardins updated this revision to Diff 494861. erikdesjardins added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142862/new/ https://reviews.llvm.org/D142862 Files:

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

2023-02-04 Thread Erik Desjardins via Phabricator via cfe-commits
erikdesjardins updated this revision to Diff 494836. erikdesjardins edited the summary of this revision. erikdesjardins added a comment. update description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142862/new/ https://reviews.llvm.org/D142862

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

2023-02-04 Thread Erik Desjardins via Phabricator via cfe-commits
erikdesjardins updated this revision to Diff 494835. erikdesjardins added a comment. rebase, remove now-unnecessary test changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142862/new/ https://reviews.llvm.org/D142862 Files:

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

2023-02-02 Thread Erik Desjardins via Phabricator via cfe-commits
erikdesjardins added inline comments. Comment at: mlir/test/Transforms/print-op-graph.mlir:9 // DFG: subgraph {{.*}} { -// DFG: v[[ARG0:.*]] [label = "arg0" -// DFG: v[[CONST10:.*]] [label ={{.*}}10 : i32 +// DFG:

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

2023-02-01 Thread Erik Desjardins via Phabricator via cfe-commits
erikdesjardins added a comment. In D142862#4089860 , @serge-sans-paille wrote: > Can you take a shot against https://llvm-compile-time-tracker.com/ so that > we get an hint of the practical speedup? I ran rustc perf tests using a patched LLVM in

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

2023-02-01 Thread Erik Desjardins via Phabricator via cfe-commits
erikdesjardins updated this revision to Diff 494155. erikdesjardins added a comment. rebase over landed D142861 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142862/new/ https://reviews.llvm.org/D142862 Files:

[PATCH] D142861: [Clang] avoid relying on StringMap iteration order when roundtripping -analyzer-config

2023-01-31 Thread Erik Desjardins via Phabricator via cfe-commits
erikdesjardins added a comment. I don't have commit access, please commit this on my behalf: `Erik Desjardins ` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142861/new/ https://reviews.llvm.org/D142861

[PATCH] D142861: [Clang] avoid relying on StringMap iteration order when roundtripping -analyzer-config

2023-01-30 Thread Erik Desjardins via Phabricator via cfe-commits
erikdesjardins updated this revision to Diff 493426. erikdesjardins added a comment. Improve code style. `ninja check-clang` still passes (as expected) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142861/new/ https://reviews.llvm.org/D142861

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

2023-01-30 Thread Erik Desjardins via Phabricator via cfe-commits
erikdesjardins added a subscriber: nikic. erikdesjardins added a comment. In D142862#4089860 , @serge-sans-paille wrote: > Can you take a shot against https://llvm-compile-time-tracker.com/ so that > we get an hint of the practical speedup? I don't

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

2023-01-29 Thread Erik Desjardins via Phabricator via cfe-commits
erikdesjardins added inline comments. Comment at: llvm/test/DebugInfo/X86/gnu-public-names.ll:68-71 ; ASM: .byte 32 # Attributes: VARIABLE, EXTERNAL +; ASM-NEXT: .asciz "ns::global_namespace_variable" # External Name +; ASM: .byte 32

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

2023-01-29 Thread Erik Desjardins via Phabricator via cfe-commits
erikdesjardins created this revision. Herald added subscribers: Moerafaat, zero9178, Enna1, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, wenlei, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen,

[PATCH] D142861: [Clang] avoid relying on StringMap iteration order when roundtripping -analyzer-config

2023-01-29 Thread Erik Desjardins via Phabricator via cfe-commits
erikdesjardins created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, mgrang, baloghadamsoftware. Herald added a project: All. erikdesjardins requested review of this revision. Herald added a project: clang. Herald added a subscriber: