[PATCH] D102459: [clang][ObjC] Allow different availability annotation on a method when implementing an optional protocol requirement

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102459/new/ https://reviews.llvm.org/D102459 ___ cfe-commits

[PATCH] D90188: Add support for attribute 'using_if_exists'

erik.pilkington added a comment. Does anyone have any remaining concerns or a desire to take another pass through this patch? If not, then I'll commit this later this week on Aaron's LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90188/new/ https://reviews.llvm.org/D90188

[PATCH] D90188: Add support for attribute 'using_if_exists'

erik.pilkington added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90188/new/ https://reviews.llvm.org/D90188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D95845: [ObjC] Add a command line flag that disables recognition of objc_direct for testability

This revision was automatically updated to reflect the committed changes. Closed by commit rGb660abc80d0d: [ObjC] Add a command line flag that disables recognition of objc_direct for… (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D99661: [SemaObjC] Fix a -Wbridge-cast false-positive

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG803b79221edf: [SemaObjC] Fix a -Wbridge-cast false-positive (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM

[PATCH] D99661: [SemaObjC] Fix a -Wbridge-cast false-positive

erik.pilkington updated this revision to Diff 334801. erik.pilkington added a comment. In D99661#2662601 , @ahatanak wrote: > Should we try to restore the behavior prior to > https://reviews.llvm.org/rG09abecef7bbfda18d34f046954eaa4d491062839 as much >

[PATCH] D99661: [SemaObjC] Fix a -Wbridge-cast false-positive

erik.pilkington created this revision. erik.pilkington added reviewers: arphaman, ahatanak. erik.pilkington requested review of this revision. Clang used to emit a bad -Wbridge-cast diagnostic on the cast in the attached test. This was because, after 09abecef7

[PATCH] D95845: [ObjC] Add a command line flag that disables recognition of objc_direct for testability

erik.pilkington updated this revision to Diff 334136. erik.pilkington added a comment. - Use the new marshaling infrastructure - Fix a few places in Sema where we manually checked for `ObjCDirectAttr` instead of using `isDirectMethod` CHANGES SINCE LAST ACTION

[PATCH] D90188: Add support for attribute 'using_if_exists'

erik.pilkington added inline comments. Comment at: clang/test/SemaCXX/using-if-exists.cpp:11 + +using NotNS::x UIE; // expected-error{{use of undeclared identifier 'NotNS'}} +} // test_basic Quuxplusone wrote: > Do you also have a test for `using NS::NotNS::x

[PATCH] D90188: Add support for attribute 'using_if_exists'

erik.pilkington updated this revision to Diff 333873. erik.pilkington marked 4 inline comments as done. erik.pilkington added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90188/new/ https://reviews.llvm.org/D90188 Files:

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

erik.pilkington updated this revision to Diff 333862. erik.pilkington marked 4 inline comments as done. erik.pilkington added a comment. Address @aaron.ballman's review comments. Also, fix a bug where we failed to properly parse an inherited constructor declaration with a trailing attribute.

[PATCH] D55212: Handle alloc_size attribute on function pointers

erik.pilkington accepted this revision. erik.pilkington added a comment. In D55212#2641301 , @aaron.ballman wrote: > I think folks will have a chance to react if we apply it to trunk now, but I > am wondering if anyone's had a chance to investigate

[PATCH] D96175: [clang] Add support for attribute 'swift_async_error'

This revision was automatically updated to reflect the committed changes. Closed by commit rG1e8afba6f176: [clang] Add support for attribute swift_async_error (authored by erik.pilkington). Herald added a project: clang. Changed prior to commit:

[PATCH] D96175: [clang] Add support for attribute 'swift_async_error'

erik.pilkington added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5977 +checkSwiftAsyncErrorBlock(S, D, ErrorAttr, AsyncAttr); +} + aaron.ballman wrote: > Should there be a diagnostic to combine `swift_error` and `swift_async_error` > on

[PATCH] D96175: [clang] Add support for attribute 'swift_async_error'

erik.pilkington updated this revision to Diff 322152. erik.pilkington marked 2 inline comments as done. erik.pilkington added a comment. Get rid of a useless `return`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96175/new/ https://reviews.llvm.org/D96175 Files:

[PATCH] D96175: [clang] Add support for attribute 'swift_async_error'

erik.pilkington created this revision. erik.pilkington added reviewers: doug.gregor, aaron.ballman. Herald added subscribers: jdoerfert, jkorous. erik.pilkington requested review of this revision. This attribute specifies how an error is represented for a swift async method. rdar://71941280

[PATCH] D95845: [ObjC] Add a command line flag that disables recognition of objc_direct for testability

erik.pilkington created this revision. erik.pilkington added reviewers: arphaman, MadCoder, rjmccall. Herald added subscribers: dexonsmith, dang, ributzka, jkorous. Herald added a reviewer: jansvoboda11. erik.pilkington requested review of this revision. Programmers would like to be able to test

[PATCH] D95482: [PATCH] [clang] Fix bug 48848 by removing assertion related to recoverFromMSUnqualifiedLookup

erik.pilkington added a comment. Sorry, yeah, I'm OK with this change. Comment at: clang/test/SemaCXX/lambda-expressions.cpp:671 +#else +template +void Decider(const RT , ET ) { I think it makes more sense for this test to be in its own file since entire

[PATCH] D93260: Frontend: Simplify handling of non-seeking streams in CompilerInstance, NFC

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93260/new/ https://reviews.llvm.org/D93260

[PATCH] D93249: Frontend: Fix memory leak in CompilerInstance::setVerboseOutputStream

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93249/new/ https://reviews.llvm.org/D93249

[PATCH] D93248: Frontend: Fix layering between create{,Default}OutputFile, NFC

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93248/new/ https://reviews.llvm.org/D93248

[PATCH] D93247: [Sema] Fix a miscompile by retaining array qualifiers when folding VLAs to constant arrays

This revision was automatically updated to reflect the committed changes. Closed by commit rG95b2dab19910: [Sema] Fix a miscompile by retaining array qualifiers when folding VLAs to… (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D93247: [Sema] Fix a miscompile by retaining array qualifiers when folding VLAs to constant arrays

erik.pilkington created this revision. erik.pilkington added reviewers: rsmith, rjmccall, arphaman. Herald added subscribers: ributzka, jkorous. erik.pilkington requested review of this revision. Fixes rdar://72243125. https://reviews.llvm.org/D93247 Files: clang/lib/Sema/SemaDecl.cpp

[PATCH] D92742: [clang] Add support for attribute 'swift_async'

This revision was automatically updated to reflect the committed changes. erik.pilkington marked 2 inline comments as done. Closed by commit rG5a28e1d9e50e: [clang] Add support for attribute swift_async (authored by erik.pilkington). Herald added a project: clang. Changed prior to commit:

[PATCH] D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result

This revision was automatically updated to reflect the committed changes. Closed by commit rG9cd2413f1ca7: [clang] Add a new nullability annotation for swift async: _Nullable_result (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D92742: [clang] Add support for attribute 'swift_async'

erik.pilkington created this revision. erik.pilkington added reviewers: arphaman, doug.gregor, aaron.ballman. Herald added subscribers: jdoerfert, ributzka, jkorous. erik.pilkington requested review of this revision. This attributes specifies how (or if) a given function or method will be

[PATCH] D92602: [objc] diagnose protocol conformance in categories with direct members in their corresponding class interfaces

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92602/new/ https://reviews.llvm.org/D92602

[PATCH] D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result

erik.pilkington added inline comments. Comment at: clang/test/SemaObjC/nullable-result.m:6 +@class NSError; + +@interface SomeClass doug.gregor wrote: > Can you add a `__has_attribute` check for `_Nullable_result`? Hmm, it looks like __has_attribute doesn't

[PATCH] D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result

erik.pilkington updated this revision to Diff 309569. erik.pilkington marked 3 inline comments as done. erik.pilkington added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92495/new/ https://reviews.llvm.org/D92495 Files:

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

erik.pilkington added a comment. In D90871#2433766 , @thakis wrote: > Looks like this breaks tests on Windows: > http://45.33.8.238/win/29181/step_7.txt > > PTAL, and revert while you investigate if it takes a while to fix. Thanks for letting me know,

[PATCH] D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result

erik.pilkington added inline comments. Comment at: clang/lib/Basic/IdentifierTable.cpp:718-719 + case NullabilityKind::NullableResult: +assert(!isContextSensitive && + "_Nullable_result isn't supported as context-sensitive keyword"); +return

[PATCH] D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result

erik.pilkington updated this revision to Diff 309537. erik.pilkington marked 5 inline comments as done. erik.pilkington added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92495/new/ https://reviews.llvm.org/D92495 Files:

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

This revision was automatically updated to reflect the committed changes. erik.pilkington marked 3 inline comments as done. Closed by commit rG090dd647d98d: [Sema] Fold VLAs to constant arrays in a few more contexts (authored by erik.pilkington). Herald added a project: clang. Changed prior to

[PATCH] D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result

erik.pilkington created this revision. erik.pilkington added reviewers: arphaman, doug.gregor, aaron.ballman. Herald added subscribers: dexonsmith, ributzka, jfb, jkorous. erik.pilkington requested review of this revision. You can read more about the clang attributes for swift async here:

[PATCH] D92355: [clang] add a `swift_async_name` attribute

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/include/clang/Basic/AttrDocs.td:3640 +The argument is a string literal that contains the Swift name of the function or +method.

[PATCH] D92354: [clang] add a new `swift_attr` attribute

erik.pilkington added a comment. Do we need to add APINotes support for this? Comment at: clang/include/clang/Basic/Attr.td:2155 + let Args = [StringArgument<"Attribute">]; + let Documentation = [SwiftAttrDocs]; +} Should we limit this to appear on certain

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

erik.pilkington added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90871/new/ https://reviews.llvm.org/D90871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D90188: Add support for attribute 'using_if_exists'

erik.pilkington added inline comments. Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:1704-1707 +void ASTDeclReader::VisitUnresolvedUsingIfExistsDecl( +UnresolvedUsingIfExistsDecl *D) { + VisitNamedDecl(D); +} aaron.ballman wrote: > I'm not super

[PATCH] D90188: Add support for attribute 'using_if_exists'

erik.pilkington updated this revision to Diff 307670. erik.pilkington marked 4 inline comments as done. erik.pilkington added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90188/new/ https://reviews.llvm.org/D90188 Files:

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

erik.pilkington added a comment. In D91630#235 , @aaron.ballman wrote: > Can you mention this change in the release notes? Also, should we document it > explicitly in the Language Extensions documentation, or do you think this is > too tiny of a

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

erik.pilkington updated this revision to Diff 307669. erik.pilkington marked 6 inline comments as done. erik.pilkington added a comment. Herald added a subscriber: dexonsmith. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91630/new/

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

erik.pilkington created this revision. erik.pilkington added reviewers: aaron.ballman, rsmith, ldionne, Mordante. Herald added subscribers: jdoerfert, ributzka, jkorous. erik.pilkington requested review of this revision. This is split off from D90188 .

[PATCH] D90188: Add support for attribute 'using_if_exists'

erik.pilkington added a comment. In D90188#2397441 , @aaron.ballman wrote: > FWIW, it'd be a bit easier if those changes were split off into their own > patch, as they're orthogonal to `using_if_exists`. Ok, I moved this part to:

[PATCH] D90188: Add support for attribute 'using_if_exists'

erik.pilkington updated this revision to Diff 305788. erik.pilkington marked 6 inline comments as done. erik.pilkington added a comment. Split off parsing support for C++ attributes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90188/new/ https://reviews.llvm.org/D90188 Files:

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

erik.pilkington updated this revision to Diff 305506. erik.pilkington added a comment. Use a bit on Declarator instead of an ad-hoc bool parameter. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90871/new/ https://reviews.llvm.org/D90871 Files: clang/include/clang/Sema/DeclSpec.h

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

erik.pilkington added a reviewer: efriedma. erik.pilkington added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90871/new/ https://reviews.llvm.org/D90871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D90188: Add support for attribute 'using_if_exists'

erik.pilkington updated this revision to Diff 305193. erik.pilkington marked 2 inline comments as done. erik.pilkington added a comment. Herald added a subscriber: jdoerfert. Add support for C++11-style attributes on using-declarations. CHANGES SINCE LAST ACTION

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

erik.pilkington created this revision. erik.pilkington added reviewers: rsmith, rjmccall, arphaman. Herald added subscribers: ributzka, jkorous. erik.pilkington requested review of this revision. D89523 removed support for promoting VLAs to constant arrays when

[PATCH] D90188: Add support for attribute 'using_if_exists'

erik.pilkington marked 3 inline comments as done. erik.pilkington added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:3801 +/// error. +class UnresolvedUsingIfExistsDecl final : public NamedDecl { + UnresolvedUsingIfExistsDecl(DeclContext *DC, SourceLocation

[PATCH] D90188: Add support for attribute 'using_if_exists'

erik.pilkington updated this revision to Diff 302733. erik.pilkington marked 20 inline comments as done. erik.pilkington added a comment. Address review comments, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90188/new/ https://reviews.llvm.org/D90188 Files:

[PATCH] D90188: Add support for attribute 'using_if_exists'

erik.pilkington added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:3801 +/// error. +class UnresolvedUsingIfExistsDecl final : public NamedDecl { + UnresolvedUsingIfExistsDecl(DeclContext *DC, SourceLocation Loc, aaron.ballman wrote: > Why is

[PATCH] D90188: Add support for attribute 'using_if_exists'

erik.pilkington added inline comments. Comment at: clang/test/SemaCXX/using-if-exists-attr.cpp:16 +template +using template_alias UIE = NS::x; // expected-warning {{'using_if_exists' attribute only applies to named declarations, types, and value declarations}} +

[PATCH] D90188: Add support for attribute 'using_if_exists'

erik.pilkington created this revision. erik.pilkington added reviewers: rsmith, aaron.ballman, ldionne. Herald added subscribers: dexonsmith, ributzka, arphaman, jkorous. erik.pilkington requested review of this revision. This attribute applies to a using declaration, and permits importing a

[PATCH] D89475: [SemaObjC] Fix composite pointer type calculation for `void*` and pointer to lifetime qualified ObjC pointer type

This revision was automatically updated to reflect the committed changes. Closed by commit rG351317167e2b: [SemaObjC] Fix composite pointer type calculation for `void*` and pointer to… (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D89475: [SemaObjC] Fix composite pointer type calculation for `void*` and pointer to lifetime qualified ObjC pointer type

erik.pilkington created this revision. erik.pilkington added reviewers: rsmith, rjmccall. Herald added subscribers: ributzka, dexonsmith, jkorous. erik.pilkington requested review of this revision. This fixes a regression introduced in 9a6f4d451ca7aa06b94a407015fbadb456bc09ef

[PATCH] D87102: [Sema] Fix a -Warc-repeated-use-of-weak false-positive by only calling CheckPlaceholderExpr once

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f1be87e2947: [Sema] Fix a -Warc-repeated-use-of-weak false-positive by only calling… (authored by erik.pilkington). Herald added a project: clang. Changed prior to commit:

[PATCH] D87102: [Sema] Fix a -Warc-repeated-use-of-weak false-positive by only calling CheckPlaceholderExpr once

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, ahatanak, fhahn. Herald added subscribers: ributzka, dexonsmith, jkorous. erik.pilkington requested review of this revision. Previously, this code discarded the result of CheckPlaceholderExpr for non-matrix

[PATCH] D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast

This revision was automatically updated to reflect the committed changes. Closed by commit rG9523cf02c22a: [AST] Fix handling of long double and bool in __builtin_bit_cast (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D86881: Make -fvisibility-inlines-hidden apply to static local variables in inline functions on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rGd46f2c51e4c8: Make -fvisibility-inlines-hidden apply to static local variables in inline… (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D67935: Add `#pragma clang deprecated`, used to deprecate macros

erik.pilkington requested review of this revision. erik.pilkington added a comment. @aaron.ballman: Did you happen to get any feedback on macro attributes? There are a growing number of macros that we'd like to be able to deprecate, and having a workable solution would be useful for us.

[PATCH] D86881: Make -fvisibility-inlines-hidden apply to static local variables in inline functions on Darwin

erik.pilkington created this revision. erik.pilkington added a reviewer: arphaman. Herald added subscribers: dang, ributzka, dexonsmith, jkorous. erik.pilkington requested review of this revision. This effectively disables https://reviews.llvm.org/D50968 on Darwin, and provides a command line

[PATCH] D86854: [CodeGen] Make sure the EH cleanup for block captures is conditional when the block literal is in a conditional context

This revision was automatically updated to reflect the committed changes. Closed by commit rGa9a6e62ddff2: [CodeGen] Make sure the EH cleanup for block captures is conditional when the… (authored by erik.pilkington). Herald added a project: clang. Changed prior to commit:

[PATCH] D86854: [CodeGen] Make sure the EH cleanup for block captures is conditional when the block literal is in a conditional context

erik.pilkington created this revision. erik.pilkington added reviewers: ahatanak, rjmccall. Herald added subscribers: danielkiss, ributzka, dexonsmith, jkorous. erik.pilkington requested review of this revision. Previously, clang was crashing on the attached test because the EH cleanup for the

[PATCH] D82611: [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. erik.pilkington marked an inline comment as done. Closed by commit rG7437a9496528: [SemaObjC] Add a warning for @selector expressions that

[PATCH] D81751: [SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional operator

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG2f71cf6d77c5: [SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional… (authored by

[PATCH] D81751: [SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional operator

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG2f71cf6d77c5: [SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional… (authored by

[PATCH] D82611: [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods

This revision was automatically updated to reflect the committed changes. Closed by commit rG7437a9496528: [SemaObjC] Add a warning for @selector expressions that potentially refer to… (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D81751: [SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional operator

erik.pilkington added a reviewer: ahatanak. erik.pilkington added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81751/new/ https://reviews.llvm.org/D81751 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82611: [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods

erik.pilkington added a comment. In D82611#2125868 , @MadCoder wrote: > So the risk with that one is that if someone had say the `-didSomething` > direct selector and that some UIKit/Apple SDK API now adds this as a thing > that you use with

[PATCH] D82611: [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods

erik.pilkington updated this revision to Diff 275759. erik.pilkington marked 3 inline comments as done. erik.pilkington added a comment. Add an off-by-default variant of this warning. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82611/new/ https://reviews.llvm.org/D82611 Files:

[PATCH] D82823: canonicalize macOS 10.16 availability to macOS 11 while preserving uses of if @available macOS 10.16

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM, after mine and Aaron's comments. Comment at: clang/lib/Sema/SemaExpr.cpp:19195-19211 +if (Spec == AvailSpecs.end()) + return None; +if

[PATCH] D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast

erik.pilkington added a comment. Ping, @rsmith did you want to take another look at this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76323/new/ https://reviews.llvm.org/D76323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82611: [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, MadCoder. Herald added subscribers: ributzka, dexonsmith, jkorous. As a heuristic, only warn if the selector matches a method declared in the current interface. rdar://64621668 https://reviews.llvm.org/D82611

[PATCH] D77592: [clang] Frontend components for the relative vtables ABI

erik.pilkington added inline comments. Comment at: clang/lib/CodeGen/ConstantInitBuilder.cpp:132 + return getRelativeOffsetToPosition(offsetType, target, + Builder.SelfReferences.size()); +} Shouldn't this be

[PATCH] D81751: [SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional operator

erik.pilkington created this revision. erik.pilkington added a reviewer: rjmccall. Herald added subscribers: ributzka, dexonsmith, jkorous. We were previously bypassing the conditional expression special case for binary conditional expressions. Also, dig through the OpaqueValueExpr on the left

[PATCH] D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs

This revision was automatically updated to reflect the committed changes. Closed by commit rG95d7ccb70b9c: [PCH] Support writing BuiltinBitCastExprs to PCHs (authored by hyd-dev, committed by erik.pilkington). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM (after a minor comment), thank you for fixing this! Comment at: clang/lib/Serialization/ASTReaderStmt.cpp:3598 + S = new (Context)

[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b529e311a90: [ObjC] Fix AST serialization for pseudo-strong parameters (authored by dgoldman, committed by erik.pilkington). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74813: Function block naming - add hash of parameter type to end of block name

erik.pilkington added a comment. In D74813#2035051 , @alexbdv wrote: > Could I please get a review on this ? Thanks :) ! I still think it makes more sense to directly encode the type instead of hashing it. I'm happy to make the demangler changes for

[PATCH] D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast

erik.pilkington added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76323/new/ https://reviews.llvm.org/D76323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78660: [SemaObjC] Add a warning for dictionary literals with duplicate keys

This revision was automatically updated to reflect the committed changes. Closed by commit rG873e27909539: [SemaObjC] Add a warning for dictionary literals with duplicate keys (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D78660: [SemaObjC] Add a warning for dictionary literals with duplicate keys

erik.pilkington marked an inline comment as done. erik.pilkington added inline comments. Comment at: clang/lib/Sema/SemaExprObjC.cpp:948 +checkOneKey(IntegralKeys, Result.Val.getInt(), Loc); + } +} bendjones wrote: > rjmccall wrote: > > Does

[PATCH] D78660: [SemaObjC] Add a warning for dictionary literals with duplicate keys

erik.pilkington added a comment. Ping! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78660/new/ https://reviews.llvm.org/D78660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74813: [RFC] Add hash of block contents to function block names

erik.pilkington edited reviewers, added: rjmccall; removed: libc++abi. erik.pilkington added a comment. In D74813#2010767 , @alexbdv wrote: > @erik.pilkington would the hash-based numbering be OK for now ? Feel free to drop the demangler changes for

[PATCH] D79094: [SemaObjC] Warn on visibility attributes on an @implementation

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, aaron.ballman. Herald added subscribers: ributzka, dexonsmith, jkorous. D60542 added support for attributes on `@implementation`s, but CodeGen always looks for visibility

[PATCH] D79012: [AST] Fix a crash on a dependent vector_size attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bb686b4b629: [AST] Fix a crash on a dependent vector_size attribute (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79012: [AST] Fix a crash on a dependent vector_size attribute

erik.pilkington created this revision. erik.pilkington added reviewers: erichkeane, aaron.ballman. Herald added subscribers: ributzka, dexonsmith, jkorous. Looks like this was just a copy & paste mistake from `getDependentSizedExtVectorType`. rdar://60092165 Repository: rC Clang

[PATCH] D74813: [RFC] Add hash of block contents to function block names

erik.pilkington added inline comments. Comment at: clang/lib/AST/Mangle.cpp:41 + for (ParmVarDecl *PVD : BD->parameters()) { +Context.mangleTypeName(PVD->getType(), Out); + } >>! In D74813#1996143, @alexbdv wrote: > @dexonsmith, @erik.pilkington - how

[PATCH] D78660: [SemaObjC] Add a warning for dictionary literals with duplicate keys

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, bendjones. Herald added subscribers: ributzka, dexonsmith, jkorous. Duplicate keys in a literal break NSDictionary's invariants. Fixes rdar://50454461 Repository: rC Clang https://reviews.llvm.org/D78660

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM, again :) Thanks for cleaning this up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77233/new/

[PATCH] D74813: [RFC] Add hash of block contents to function block names

erik.pilkington added a comment. The demangler changes should also be made in `libcxxabi/src/demangle`, as there is a copy of the demangler there. This change also needs tests, there should be demangler tests (in libcxxabi/test/test_demangle.cpp), and IRGen tests (in clang/test/CodeGen) that

[PATCH] D78066: [SemaObjC] Forbid storing an unboxed integer literal in an NSNumber

This revision was automatically updated to reflect the committed changes. Closed by commit rG85cca945b4c9: [SemaObjC] Forbid storing an unboxed integer literal in an NSNumber (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast

erik.pilkington added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76323/new/ https://reviews.llvm.org/D76323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

erik.pilkington added inline comments. Comment at: clang/include/clang-c/Index.h:4503 CXObjCPropertyAttr_unsafe_unretained = 0x800, - CXObjCPropertyAttr_class = 0x1000 + CXObjCPropertyAttr_classattr = 0x1000 } CXObjCPropertyAttrKind; plotfi wrote: >

[PATCH] D78066: [SemaObjC] Forbid storing an unboxed integer literal in an NSNumber

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, bendjones, arphaman. Herald added subscribers: ributzka, dexonsmith, jkorous. This fixes a common mistake (the 3 should be @3): `NSNumber *n = 3`. This extends an existing check for NSString. Also, this only errs

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

erik.pilkington requested changes to this revision. erik.pilkington added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang-c/Index.h:4503 CXObjCPropertyAttr_unsafe_unretained = 0x800, - CXObjCPropertyAttr_class = 0x1000 +

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM (after fixing those tests). Thanks for cleaning this up! Comment at: clang/tools/c-index-test/c-index-test.c:1107

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

erik.pilkington added inline comments. Comment at: clang/include/clang/AST/DeclObjCCommon.h:21 +/// Keep this list in sync with LLVM's Dwarf.h ApplePropertyAttributes. +enum ObjCPropertyAttributeKind { + OBJC_PR_noattr = 0x00, plotfi wrote: > plotfi wrote: > >

[PATCH] D74813: [RFC] Add hash of block contents to function block names

erik.pilkington added a comment. What do you think about using the block type instead of a hash? That should be stable across compiler versions, changes to the block body, and changes to referenced declarations. You'd still have to number blocks of the same type within the same function, but

[PATCH] D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast

erik.pilkington added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76323/new/ https://reviews.llvm.org/D76323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   3   4   5   6   >