RE: D34588: Check for _MSC_VER before define _LIBCPP_MSVCRT

2017-07-13 Thread Erik Schwiebert via cfe-commits
These hypothetical targets aren’t so hypothetical. Office for Mac and iOS uses code ported from Windows but actually targeted at running on the Apple (Darwin) platform. We don’t have the MSVC CRT there. 😊 Schwieb -Original Message- From: Reid Kleckner via Phabricator [mailto:revi...@r

RE: r284060 - Implement MS _BitScan intrinsics

2017-06-20 Thread Erik Schwiebert via cfe-commits
walk down >> the hall and ask them. Tomasz is our header maestro (because we play crazy >> #include_next games so we can use both Windows and macOS SDKs!) >> >> We'll get back to you ASAP. >> >> Schwieb >> >> -Original Message- >> From: Bruno C

RE: r284060 - Implement MS _BitScan intrinsics

2017-06-16 Thread Erik Schwiebert via cfe-commits
itScan intrinsics On Tue, Jun 13, 2017 at 8:13 PM, Bruno Cardoso Lopes wrote: > On Mon, Jun 12, 2017 at 2:01 PM, Erik Schwiebert via cfe-commits > wrote: >> SGTM too. Regarding Duncan's last question -- I can't think of any such >> customer. :) If you all think

RE: r284060 - Implement MS _BitScan intrinsics

2017-06-16 Thread Erik Schwiebert via cfe-commits
ntrinsics On Tue, Jun 13, 2017 at 8:13 PM, Bruno Cardoso Lopes wrote: > On Mon, Jun 12, 2017 at 2:01 PM, Erik Schwiebert via cfe-commits > wrote: >> SGTM too. Regarding Duncan's last question -- I can't think of any such >> customer. :) If you all think the right th

RE: r284060 - Implement MS _BitScan intrinsics

2017-06-12 Thread Erik Schwiebert via cfe-commits
SGTM too. Regarding Duncan's last question -- I can't think of any such customer. :) If you all think the right thing for clang to do is to infer LLP64 behavior on LP64 (Darwin) + ms_extensions, then that is fine with me! Thanks all! Schwieb -Original Message- From: dexonsm...@apple.com

RE: r284060 - Implement MS _BitScan intrinsics

2017-06-12 Thread Erik Schwiebert via cfe-commits
Any more thoughts on this from Saleem or Apple folks? Thanks, Schwieb From: Erik Schwiebert Sent: Thursday, June 8, 2017 12:22 PM To: 'Saleem Abdulrasool' ; 'Duncan P. N. Exon Smith' Cc: 'Albert Gutowski' ; 'Reid Kleckner' ; 'David Majnemer' ; 'cfe-commits' Subject: RE: r284060 - Implement M

RE: r284060 - Implement MS _BitScan intrinsics

2017-06-08 Thread Erik Schwiebert via cfe-commits
It’s probably also better to not try to infer our weird desired behavior. It should probably be controlled by a specific driver directive, like “-fms-extensions-lp64-intrinsics” or something like that. Using a new directive means that nobody can accidentally get this behavior if they for some re

RE: r284060 - Implement MS _BitScan intrinsics

2017-06-08 Thread Erik Schwiebert via cfe-commits
Yes, we definitely do not want to introduce pointer-type incompatibility warnings. Predicating the behavior change on LP64 vs LLP64 seems better. What’s the best way to do that? Brian and I can hack on clang a bit, but we’re certainly not experts. Schwieb From: Saleem Abdulrasool [mailto:comp