Dushistov added a comment.
apply all suggestions
http://reviews.llvm.org/D14170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Dushistov marked an inline comment as done.
Dushistov added a comment.
http://reviews.llvm.org/D14170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Dushistov updated this revision to Diff 40485.
Dushistov added a comment.
Replace 'endswith' with 'operator==', also update test to check that all four
ways to call postEvent not produce warning
http://reviews.llvm.org/D14170
Files:
lib/StaticAnalyzer/Checkers/MallocChecker.cpp
Dushistov added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/QtSignalSlotChecker.cpp:114
@@ +113,3 @@
+ printMethodNameWithPramaTypes(Out, C, FName, M,
false);
+ const std::string NS =
qtNormalizeSignature(Out.str());
Dushistov created this revision.
Dushistov added reviewers: dcoughlin, Ayal, xazax.hun, zaks.anna.
Dushistov added a subscriber: cfe-commits.
In Qt 4/5 it is possible connect classes methods in such way:
connect(ObjectPointer1, SIGNAL(methodOfObject1()), ObjectPointer2,
SLOT(methodOfObject2());
Dushistov updated this revision to Diff 39985.
Dushistov added a comment.
mistype, actually I want to use '&&' here, not '||' to not create std::string,
if match failed.
http://reviews.llvm.org/D14170
Files:
lib/StaticAnalyzer/Checkers/MallocChecker.cpp
test/Analysis/Inputs/qt-simulator.h
Dushistov marked an inline comment as done.
Dushistov added a comment.
http://reviews.llvm.org/D14170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Dushistov updated this revision to Diff 39265.
Dushistov added a comment.
Fix line length issue
http://reviews.llvm.org/D14170
Files:
lib/StaticAnalyzer/Checkers/MallocChecker.cpp
test/Analysis/Inputs/qt-simulator.h
test/Analysis/qt_malloc.cpp
Index: test/Analysis/qt_malloc.cpp
Dushistov updated this revision to Diff 39264.
Dushistov added a comment.
I reduce testcase to almost minimal variant.
http://reviews.llvm.org/D14170
Files:
lib/StaticAnalyzer/Checkers/MallocChecker.cpp
test/Analysis/Inputs/qt-simulator.h
test/Analysis/qt_malloc.cpp
Index: