Hi Kadir,
Thank you for looking into this.
Unfortunately, I can't repro this anymore. I wonder if I had a weird stale
clangd or something. Current test (now changed to armv7) does set the
target properly. When I tried last time, it wasn't setting it, and was
defaulting to my system's (darwin).
Th
Hi Kadir,
Can you fix the target_info.test clangd test you committed in this
revision, please?
I see you've tried fixing it later by adding `REQUIRES:
x86-registered-target`, but now it's never running because that feature
isn't (ever) set.
Here's a buildbot run showing it as unsupported (x86 targ
Author: filcab
Date: Fri Nov 2 10:29:04 2018
New Revision: 346001
URL: http://llvm.org/viewvc/llvm-project?rev=346001&view=rev
Log:
Change -fsanitize-address-poison-class-member-array-new-cookie to
-fsanitize-address-poison-custom-array-cookie
Handle it in the driver and propagate it to cc1
Re
LGTM on the clang side too.
Thank you,
Filipe
On Wed, 10 Oct 2018 at 23:33, Richard Smith - zygoloid via Phabricator <
revi...@reviews.llvm.org> wrote:
> rsmith accepted this revision.
> rsmith added a comment.
> This revision is now accepted and ready to land.
>
> This looks good to me. Sounds
Sorry about that. I’m away today but I don’t think you’ve answered my
questions about “why not support standalone UBSan in tests”. Sorry if I
missed the answers if you did. Will review the latest tomorrow.
Thank you,
Filipe
On Mon, 8 Oct 2018 at 07:48, Roman Lebedev via Phabricator <
revi...@rev
Author: filcab
Date: Wed Aug 1 06:41:42 2018
New Revision: 338553
URL: http://llvm.org/viewvc/llvm-project?rev=338553&view=rev
Log:
Use a dummy target so the test passes when default target is for a toolchain
implements useIntegratedAs() -> true
Modified:
cfe/trunk/test/Driver/integrated-as
Author: filcab
Date: Wed Aug 1 06:41:11 2018
New Revision: 338552
URL: http://llvm.org/viewvc/llvm-project?rev=338552&view=rev
Log:
Add REQUIRES: native to a test that assumes it
Modified:
cfe/trunk/test/Driver/darwin-infer-simulator-sdkroot.c
Modified: cfe/trunk/test/Driver/darwin-infer-si
Author: filcab
Date: Thu Jun 28 07:16:13 2018
New Revision: 335858
URL: http://llvm.org/viewvc/llvm-project?rev=335858&view=rev
Log:
Fix test that was failing on Windows due to too many backslashes
Modified:
cfe/trunk/test/Driver/linux-per-target-runtime-dir.c
Modified: cfe/trunk/test/Driver
Author: filcab
Date: Mon Feb 12 03:49:02 2018
New Revision: 324884
URL: http://llvm.org/viewvc/llvm-project?rev=324884&view=rev
Log:
ASan+operator new[]: Add an option for more thorough operator new[] cookie
poisoning
Summary:
Right now clang is skipping array cookie poisoning for any operator
n
Author: filcab
Date: Tue Jan 2 05:46:12 2018
New Revision: 321647
URL: http://llvm.org/viewvc/llvm-project?rev=321647&view=rev
Log:
Revert "ASan+operator new[]: Fix operator new[] cookie poisoning"
This reverts r321645.
I missed a compiler-rt test that needs updating.
Modified:
cfe/trunk/l
Author: filcab
Date: Tue Jan 2 05:21:50 2018
New Revision: 321645
URL: http://llvm.org/viewvc/llvm-project?rev=321645&view=rev
Log:
ASan+operator new[]: Fix operator new[] cookie poisoning
Summary:
The C++ Itanium ABI says:
No cookie is required if the new operator being used is ::operator
new[
Author: filcab
Date: Fri Sep 29 08:45:34 2017
New Revision: 314524
URL: http://llvm.org/viewvc/llvm-project?rev=314524&view=rev
Log:
Fix Modules/{builtin-import.mm,umbrella-header-include-builtin.mm} to be able
to handle non-Darwin targets
Summary: Also makes them pass on Darwin, if the default
Another example + possible fix (two WidthMinusOne, one per (possibly
different) bitwidth): (not fully tested)
int f() {
return 0 << 0L;
}
diff --git a/lib/CodeGen/CGExprScalar.cpp b/lib/CodeGen/CGExprScalar.cpp
index 40d949dece..5c9055d49a 100644
--- a/lib/CodeGen/CGExprScalar.cpp
+++ b/lib/Cod
Author: filcab
Date: Fri Jan 6 08:40:12 2017
New Revision: 291236
URL: http://llvm.org/viewvc/llvm-project?rev=291236&view=rev
Log:
[ubsan] Minimize size of data for type_mismatch (Redo of D19667)
Summary:
This patch makes the type_mismatch static data 7 bytes smaller (and it
ends up being 16 by
Thanks Vedant!
Andrew: does Android not support C++11? I don't understand why it wouldn't
have these funcions.
Thank you,
Filipe
On Mon, 12 Dec 2016 at 18:58, Vedant Kumar wrote:
>
>
> > On Dec 12, 2016, at 10:17 AM, Andrew Ford via Phabricator <
> revi...@reviews.llvm.org> wrote:
>
> >
>
> >
Author: filcab
Date: Mon Dec 12 10:43:40 2016
New Revision: 289446
URL: http://llvm.org/viewvc/llvm-project?rev=289446&view=rev
Log:
[Fix] Add missing include from r289444.
Modified:
cfe/trunk/lib/CodeGen/CGExpr.cpp
Modified: cfe/trunk/lib/CodeGen/CGExpr.cpp
URL:
http://llvm.org/viewvc/llvm
Author: filcab
Date: Mon Dec 12 10:18:40 2016
New Revision: 289444
URL: http://llvm.org/viewvc/llvm-project?rev=289444&view=rev
Log:
[clang] Version support for UBSan handlers
This adds a way for us to version any UBSan handler by itself.
The patch overrides D21289 for a better implementation (we
filcab added a comment.
In https://reviews.llvm.org/D25199#560061, @vsk wrote:
> My question was about whether it's possible to resume normal program
> execution after printing the stack trace from the segv handler. I had assumed
> this is not possible, and (mistakenly) thought that you were su
filcab added a comment.
Please add some printf calls to the test, to show that you have the correct
stack+size, too.
Thanks for working on this.
Filipe
Comment at: lib/asan/asan_thread.cc:141
@@ -140,3 +140,3 @@
if (!fake_stack_save && current_fake_stack)
current_fake_
It seems some people on this thread (I'm sorry if everyone is taking this
into account, but it seemed to me that this was going unnoticed, I want to
make sure everyone is on the same page) is only talking about linking (or
not) the sanitizer runtimes. But that's not the only thing.
Depending on th
Haha, the joke is on me. I had the opposite opinion two years ago (I
guess by virtue of working on the sanitizers for a while, I've come to
see them as default libs?).
Making the behavior more consistent is good, and the r218541
discussion (+220455) makes me think your patch is good. We end up
hav
I don't think so. "No default libs" should mean "no default libs", not
"some default libs". Maybe you're using an alternate sanitizer lib or
something, hence usage of that flag.
Thank you,
Filipe
On Tuesday, 30 August 2016, Chris Bieneman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
filcab added a comment.
In https://reviews.llvm.org/D21695#514080, @vsk wrote:
> Running sanitized programs in production sounds strange to me. But, if there
> isn't really a cost to supporting this, I suppose it's fine.
It does, and most likely this change wouldn't affect them, as I would gue
LGTM.
Thank you,
Filipe
On Tue, Aug 16, 2016 at 10:23 AM, Davide Italiano wrote:
> davide added a comment.
>
> The `Sema` bits look fine to me. I'll let Filipe comment on the sanitizer
> part.
>
>
> https://reviews.llvm.org/D23498
>
>
>
___
cfe-comm
filcab added a subscriber: filcab.
Comment at: test/CodeGen/wrapv-lshr-sanitize.c:1
@@ +1,2 @@
+// RUN: %clang_cc1 -fsanitize=shift-base -emit-llvm %s -o - -triple
x86_64-linux-gnu -fwrapv | opt -instnamer -S | FileCheck %s
+
Do you really need `instnamer`?
filcab added a comment.
In https://reviews.llvm.org/D21695#510788, @vsk wrote:
> After reading through the discussion in https://reviews.llvm.org/D19668, I
> don't think I understood the pros/cons of using a single ABI check (like asan
> does) versus adding version numbers to each handler routi
filcab added a comment.
Ping!
https://reviews.llvm.org/D21695
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
filcab added a comment.
Thanks a lot for working on this!
Filipe
https://reviews.llvm.org/D22463
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
filcab added a subscriber: filcab.
filcab added a comment.
What about branches? I'm guessing we should expect the usual release branches.
But will any person be able to create a branch? Will there be a policy, if this
is the case? Is the policy enforceable?
Comment at: docs/Pr
filcab added a comment.
Ping!
http://reviews.llvm.org/D21695
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
filcab abandoned this revision.
filcab added a comment.
Replaced by http://reviews.llvm.org/D21695
http://reviews.llvm.org/D21289
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
filcab created this revision.
filcab added reviewers: kcc, samsonov, rsmith.
filcab added a subscriber: cfe-commits.
This adds a way for us to version any UBSan handler by itself.
The patch overrides D21289 for a better implementation (we're able to
rev up a single handler).
After this, then we c
filcab created this revision.
filcab added reviewers: kcc, samsonov, rsmith.
filcab added a subscriber: cfe-commits.
This patch introduces a simple way to bump of all the handlers in UBSan.
This way, we can easily break backwards compatibility without it being
confusing for users (a bit like the A
its
wrote:
>
>
> On Tue, May 17, 2016 at 7:07 AM, Filipe Cabecinhas via cfe-commits
> wrote:
>>
>> Author: filcab
>> Date: Tue May 17 09:07:43 2016
>> New Revision: 269765
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=269765&view=rev
>&
Author: filcab
Date: Tue May 17 09:07:43 2016
New Revision: 269765
URL: http://llvm.org/viewvc/llvm-project?rev=269765&view=rev
Log:
Revert "[X86] Add immediate range checks for many of the builtins."
This reverts commit r269619.
Modified:
cfe/trunk/lib/Sema/SemaChecking.cpp
cfe/trunk/te
filcab updated this revision to Diff 57350.
filcab added a comment.
Added a version field.
http://reviews.llvm.org/D19667
Files:
lib/CodeGen/CGExpr.cpp
test/CodeGen/catch-undef-behavior.c
Index: test/CodeGen/catch-undef-behavior.c
===
filcab updated this revision to Diff 57342.
filcab added a comment.
Minor update which never sets an AlignVal to 0.
http://reviews.llvm.org/D19667
Files:
lib/CodeGen/CGExpr.cpp
test/CodeGen/catch-undef-behavior.c
Index: test/CodeGen/catch-undef-behavior.c
==
filcab added a comment.
Hi Richard. Just want to double-check something. If we have no alignment value,
for this check, can we assume 1?
It seems to me that that shouldn't be a problem, but wanted to double-check.
Comment at: lib/CodeGen/CGExpr.cpp:579
@@ -578,1 +578,3 @@
+
> On 13 May 2016, at 07:03, Sean Silva wrote:
>
>
>
> On Thu, May 12, 2016 at 9:51 AM, Filipe Cabecinhas via cfe-commits
> wrote:
> Author: filcab
> Date: Thu May 12 11:51:36 2016
> New Revision: 269309
>
> URL: http://llvm.org/viewvc/llvm-project?rev=269
Author: filcab
Date: Thu May 12 11:51:36 2016
New Revision: 269309
URL: http://llvm.org/viewvc/llvm-project?rev=269309&view=rev
Log:
[ubsan] Add -fsanitize-undefined-strip-path-components=N
Summary:
This option allows the user to control how much of the file name is
emitted by UBSan. Tuning this
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269309: [ubsan] Add
-fsanitize-undefined-strip-path-components=N (authored by filcab).
Changed prior to commit:
http://reviews.llvm.org/D19666?vs=56396&id=57063#toc
Repository:
rL LLVM
http://review
filcab updated this revision to Diff 56396.
filcab added a comment.
Address Richard's comments.
Final Windows fixes (force a Linux target so our mangled label matches).
http://reviews.llvm.org/D19666
Files:
docs/UndefinedBehaviorSanitizer.rst
include/clang/Driver/Options.td
include/clang/
filcab added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:2385-2386
@@ +2384,4 @@
+FilenameString = FilenameString.substr(I - E);
+ else
+FilenameString = llvm::sys::path::filename(FilenameString);
+} else if (PathComponentsToStrip > 0) {
--
filcab updated this revision to Diff 56289.
filcab added a comment.
Improve Windows support
http://reviews.llvm.org/D19666
Files:
docs/UndefinedBehaviorSanitizer.rst
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/CGExpr.cpp
lib/Driver/Tools.cpp
filcab added a comment.
In http://reviews.llvm.org/D19666#422150, @ygribov wrote:
> Can we have generic option for other sanitizers?
Do other sanitizers emit paths this way?
For ASan, for example, we end up emitting them only when there are global
constructors involved, where we'd emit an __as
filcab updated this revision to Diff 56262.
filcab added a comment.
Remove .data() call
http://reviews.llvm.org/D19666
Files:
docs/UndefinedBehaviorSanitizer.rst
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/CGExpr.cpp
lib/Driver/Tools.cpp
lib
filcab updated this revision to Diff 56261.
filcab added a comment.
Update catch-undef-behavior.c
http://reviews.llvm.org/D19667
Files:
lib/CodeGen/CGExpr.cpp
test/CodeGen/catch-undef-behavior.c
Index: test/CodeGen/catch-undef-behavior.c
filcab updated this revision to Diff 56164.
filcab added a comment.
Remove unneeded comments.
Simplify code.
http://reviews.llvm.org/D19666
Files:
docs/UndefinedBehaviorSanitizer.rst
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/CGExpr.cpp
lib/D
filcab updated this revision to Diff 55605.
filcab marked 2 inline comments as done.
filcab added a comment.
Addressed Richard's comments.
Waiting on http://reviews.llvm.org/D19724 (operator- on Path's
reverse_iterator) before landing this.
http://reviews.llvm.org/D19666
Files:
docs/Undefine
filcab added a comment.
http://reviews.llvm.org/D19668 is the compiler-rt side of the patch.
http://reviews.llvm.org/D19667
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
filcab created this revision.
filcab added reviewers: kcc, samsonov, rsmith.
filcab added a subscriber: cfe-commits.
This patch makes the type_mismatch static data 7 bytes smaller (and it ends up
being 16 bytes smaller due to alignment restrictions, at least on some x86-64
environments).
Currentl
filcab created this revision.
filcab added a reviewer: rsmith.
filcab added a subscriber: cfe-commits.
This option allows the user to control how much of the file name is
emitted by UBSan. Tuning this option allows one to save space in the
resulting binary, which is helpful for restricted executio
filcab added a comment.
The patch needs to get through clang-format.
Should we deal with typeid and dynamic_cast, since they're mentioned in the
same paragraph in the standard?
Comment at: lib/Sema/SemaDeclCXX.cpp:3895
@@ +3894,3 @@
+ // Check if member call is actually to
filcab added a comment.
I meant changing the diff, but if you prefer to have a smaller comment, I'm ok
with the different "paths" in the standards being mentioned only in the commit
message.
Comment at: lib/Sema/SemaDeclCXX.cpp:3941
@@ +3940,3 @@
+ // Calling a member fun
filcab added a subscriber: filcab.
filcab added a comment.
You might want to mention that it's 12.6.2p16 in C++14/17 but p13 in C++11.
I wonder if we should have the example in the standard, verbatim. (Plus the
added tests you made)
http://reviews.llvm.org/D19312
filcab abandoned this revision.
filcab added a comment.
Thanks for clarifying, Richard.
I'll think about getting some fixes/tests in for our DRs.
http://reviews.llvm.org/D18654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
That means that our C++11 mode will have some fixes, right?
How can we call what out C++11 mode is? Are there updated versions of
the standard? Are there lists of defects that we have fixed and others
we haven't?
Sorry, I'm not too familiar with how the standard+fixes usually work.
Thank you,
filcab added a subscriber: filcab.
filcab added a comment.
That means that our C++11 mode will have some fixes, right?
How can we call what out C++11 mode is? Are there updated versions of
the standard? Are there lists of defects that we have fixed and others
we haven't?
Sorry, I'm not too famili
filcab created this revision.
filcab added reviewers: rsmith, samsonov.
filcab added a subscriber: cfe-commits.
Clang was using C++14 rules for shifts into the sign bit with any C++
standard. Now it has the C++ <14 special case (same as C).
Using this C++11 standard draft as reference (before CWG
Author: filcab
Date: Tue Mar 1 09:33:52 2016
New Revision: 262341
URL: http://llvm.org/viewvc/llvm-project?rev=262341&view=rev
Log:
[cmake] Add a few more compiler-rt check-* targets for EXTERNAL_COMPILER_RT
Modified:
cfe/trunk/runtime/CMakeLists.txt
Modified: cfe/trunk/runtime/CMakeLists.t
Author: filcab
Date: Tue Mar 1 09:07:19 2016
New Revision: 262340
URL: http://llvm.org/viewvc/llvm-project?rev=262340&view=rev
Log:
[cmake] Try to appease the buildbots.
Modified:
cfe/trunk/runtime/CMakeLists.txt
Modified: cfe/trunk/runtime/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-p
Author: filcab
Date: Tue Mar 1 08:10:38 2016
New Revision: 262336
URL: http://llvm.org/viewvc/llvm-project?rev=262336&view=rev
Log:
[cmake] Pass through the cmake_3_2_USES_TERMINAL variable so we get progress
bars on an external compiler-rt build
Modified:
cfe/trunk/runtime/CMakeLists.txt
Author: filcab
Date: Tue Mar 1 08:08:18 2016
New Revision: 262335
URL: http://llvm.org/viewvc/llvm-project?rev=262335&view=rev
Log:
[cmake] Use CMake's USES_TERMINAL for the test targets.
Modified:
cfe/trunk/runtime/CMakeLists.txt
Modified: cfe/trunk/runtime/CMakeLists.txt
URL:
http://llvm
Author: filcab
Date: Tue Mar 1 08:08:13 2016
New Revision: 262334
URL: http://llvm.org/viewvc/llvm-project?rev=262334&view=rev
Log:
[cmake] Fallback to LLVM_EXTERNAL_COMPILER_RT_SOURCE_DIR if
COMPILER_RT_SRC_ROOT doesn't exist.
Modified:
cfe/trunk/runtime/CMakeLists.txt
Modified: cfe/trunk
Author: filcab
Date: Fri Dec 4 10:18:03 2015
New Revision: 254723
URL: http://llvm.org/viewvc/llvm-project?rev=254723&view=rev
Log:
[PS4] Add an additional test for ASan+UBSan
Modified:
cfe/trunk/test/Driver/fsanitize.c
Modified: cfe/trunk/test/Driver/fsanitize.c
URL:
http://llvm.org/viewv
Handling of values other than lld looked weird.
Can you make it a hard error to use something other than, I guess, ld,
gold, lld?
Or are there other linkers available?
Filipe
On Friday, 13 November 2015, Yaron Keren via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Sure, r253066.
>
>
> 20
itself starts producing (false positive?) warnings about
> uninitialized variables. I didn't get a chance to dig deeper yet.
>
> --Artem
>
> On Fri, Oct 16, 2015 at 8:07 AM, Filipe Cabecinhas via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: fil
Author: filcab
Date: Fri Oct 16 10:07:48 2015
New Revision: 250514
URL: http://llvm.org/viewvc/llvm-project?rev=250514&view=rev
Log:
PS4: Make sure to add the sanitizer runtime before any linker input
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified: cfe/trunk/lib/Driver/Tools.cpp
URL:
htt
Author: filcab
Date: Fri Oct 16 10:07:56 2015
New Revision: 250515
URL: http://llvm.org/viewvc/llvm-project?rev=250515&view=rev
Log:
PS4: Add tests for rtti/vptr-sanitizer interaction
Modified:
cfe/trunk/test/Driver/rtti-options.cpp
Modified: cfe/trunk/test/Driver/rtti-options.cpp
URL:
http
Author: filcab
Date: Fri Oct 16 10:08:01 2015
New Revision: 250516
URL: http://llvm.org/viewvc/llvm-project?rev=250516&view=rev
Log:
[PS4] Add missing tests for -fsanitize=...
Modified:
cfe/trunk/test/Driver/fsanitize.c
cfe/trunk/test/Driver/sanitizer-ld.c
Modified: cfe/trunk/test/Driver
Hi Katya,
On Thu, Oct 15, 2015 at 2:01 AM, Romanova, Katya <
katya_roman...@playstation.sony.com> wrote:
> Filipe,
>
> I have one question regarding the change in debug-option.c that you made
> to get the builds green again… (r250294).
>
>
>
> Basically you changed the generic run line that used
Author: filcab
Date: Wed Oct 14 09:45:36 2015
New Revision: 250298
URL: http://llvm.org/viewvc/llvm-project?rev=250298&view=rev
Log:
Tweak a -g related test for the PS4
Make sure we're matching what we want:
- Always have -generate-arange-section (independent of -g)
- Emit a -dwarf-version=...
Hi all,
I have harnessed the powers of time zones and did the last tweak we needed
to get it comitted.
It's still going through some bots, but I don't foresee big problems. The
fast bots liked it.
Thanks to everyone that reviewed it and worked on it!
Filipe
On Wed, Oct 14, 2015 at 8:54 AM, Ro
Author: filcab
Date: Wed Oct 14 07:25:43 2015
New Revision: 250293
URL: http://llvm.org/viewvc/llvm-project?rev=250293&view=rev
Log:
Bring back r250262: PS4 toolchain
There was a minor problem with a test. Sorry for the noise yesterday.
This patch adds missing pieces to clang, including the PS4
filcab accepted this revision.
filcab added a comment.
This revision is now accepted and ready to land.
LGTM. But let's wait for a !Sony dev to say something too.
Repository:
rL LLVM
http://reviews.llvm.org/D13482
___
cfe-commits mailing list
cfe
filcab updated this revision to Diff 34522.
filcab marked 12 inline comments as done.
filcab added a comment.
This revision is now accepted and ready to land.
Addressed review comments.
http://reviews.llvm.org/D11279
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/Di
filcab abandoned this revision.
filcab added a comment.
We don't need this anymore, since we're making some internal changes.
Thank you for the feedback!
Comment at: include/clang/Driver/Options.td:1853-1854
@@ -1853,1 +1852,4 @@
+def fuse_ld_EQ : Joined<["-"], "fuse-ld=">, Help
Hi Richard,
On Tue, Aug 25, 2015 at 11:01 AM, Richard Smith
wrote:
> On Aug 25, 2015 10:26 AM, "Filipe Cabecinhas" <
> filcab+llvm.phabrica...@gmail.com> wrote:
> >
> > Hi Richard,
> >
> > We wouldn't be able to link with libs matching
> "libinker=*.{dylib,so,...}", I guess. If that is a big pro
Hi Richard,
We wouldn't be able to link with libs matching "libinker=*.{dylib,so,...}",
I guess. If that is a big problem and you'd prefer that we keep this as a
private patch, let me know.
Thank you,
Filipe
On Mon, Aug 24, 2015 at 6:45 PM, Richard Smith
wrote:
> On Mon, Aug 24, 2015 at 5:5
filcab updated this revision to Diff 33085.
filcab marked 3 inline comments as done.
filcab added a comment.
Addressed comments.
http://reviews.llvm.org/D11737
Files:
include/clang/Driver/Options.td
test/Driver/fuse-ld.c
Index: test/Driver/fuse-ld.c
filcab updated this revision to Diff 33030.
filcab marked an inline comment as done.
filcab added a comment.
Addressed Eric's comment.
http://reviews.llvm.org/D11737
Files:
include/clang/Driver/Options.td
test/Driver/fuse-ld.c
Index: test/Driver/fuse-ld.c
==
filcab added a comment.
It seems you missed some `\brief`. Other than that, no complaints on this side.
Comment at: lib/CodeGen/CGExpr.cpp:2303
@@ -2302,4 +2302,3 @@
- if (TrapCond)
-EmitTrapCheck(TrapCond);
+ if (TrapCond) EmitSanitizeTrapCheck(TrapCond);
if (!FatalC
filcab added a subscriber: filcab.
filcab added a comment.
Looks good, thanks for working on this.
I added some code style comments.
Comment at: lib/CodeGen/CGExpr.cpp:2399
@@ -2385,1 +2398,3 @@
+
+void CodeGenFunction::EmitTrapCheck(llvm::Value *Checked, const std::string
&Tra
filcab added a subscriber: filcab.
filcab added a comment.
Looks good.
Comment at: lib/ubsan/ubsan_flags.inc:26
@@ +25,2 @@
+UBSAN_FLAG(bool, report_error_type, false,
+"Print specific error type instead of 'undefined-behavior' in
summary.")
Do we care
This revision was automatically updated to reflect the committed changes.
Closed by commit rL244568: Propagate SourceLocations through to get a Loc on
float_cast_overflow (authored by filcab).
Changed prior to commit:
http://reviews.llvm.org/D11757?vs=31429&id=31765#toc
Repository:
rL LLVM
Author: filcab
Date: Mon Aug 10 23:19:28 2015
New Revision: 244568
URL: http://llvm.org/viewvc/llvm-project?rev=244568&view=rev
Log:
Propagate SourceLocations through to get a Loc on float_cast_overflow
Summary:
float_cast_overflow is the only UBSan check without a source location attached.
This
filcab updated this revision to Diff 31693.
filcab added a comment.
Update to latest trunk. Ping.
http://reviews.llvm.org/D11737
Files:
include/clang/Driver/Options.td
test/Driver/fuse-ld.c
Index: test/Driver/fuse-ld.c
===
---
Author: filcab
Date: Mon Aug 10 02:01:11 2015
New Revision: 244433
URL: http://llvm.org/viewvc/llvm-project?rev=244433&view=rev
Log:
[tests] Remove calls to grep
Modified:
cfe/trunk/test/Index/warning-flags.c
Modified: cfe/trunk/test/Index/warning-flags.c
URL:
http://llvm.org/viewvc/llvm-pr
filcab updated this revision to Diff 31429.
filcab added a comment.
Rebasing off of current trunk.
compiler-rt patch posted at http://reviews.llvm.org/D11793
http://reviews.llvm.org/D11757
Files:
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CGExprComplex.cpp
lib/CodeGen/CGExprScalar.cpp
lib/Code
filcab added a comment.
Marking Richard's comment as done.
http://reviews.llvm.org/D11757
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
90 matches
Mail list logo
