[clang] [clang-tools-extra] [libcxx] Revert "[clang] Enable sized deallocation by default in C++14 onwards (#83774)" (PR #90299)

https://github.com/fmayer approved this pull request. https://github.com/llvm/llvm-project/pull/90299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] Revert "[clang analysis] ExprMutationAnalyzer avoid infinite recursion for recursive forwarding reference" (PR #88765)

https://github.com/fmayer closed https://github.com/llvm/llvm-project/pull/88765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] Revert "[clang analysis] ExprMutationAnalyzer avoid infinite recursion for recursive forwarding reference" (PR #88765)

https://github.com/fmayer created https://github.com/llvm/llvm-project/pull/88765 Reverts llvm/llvm-project#87954 Broke sanitizer bots, e.g. https://lab.llvm.org/buildbot/#/builders/239/builds/6587/steps/10/logs/stdio >From 82b9a06f73df5301ffd950775055304124f63e02 Mon Sep 17 00:00:00 2001

[clang] [clang-tools-extra] [clang analysis] ExprMutationAnalyzer avoid infinite recursion for recursive forwarding reference (PR #87954)

fmayer wrote: This broke the sanitizer bots, e.g. https://lab.llvm.org/buildbot/#/builders/239/builds/6587/steps/10/logs/stdio ``` [==] Running 2 tests from 1 test suite. [--] Global test environment set-up. [--] 2 tests from ExprMutationAnalyzerTest [ RUN ]

[clang] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] Fix SyntaxWarning messages from python 3.12 (PR #86806)

fmayer wrote: LGTM, verified the two strings are the same ``` >>> r"^(.*) \(in (.*)\) \((.*:\d*)\)$" == "^(.*) \(in (.*)\) \((.*:\d*)\)$" True >>> "^( *#([0-9]+) *)(0x[0-9a-f]+) *(?:in *.+)? *\((.*)\+(0x[0-9a-f]+)\)" == >>> r"^( *#([0-9]+) *)(0x[0-9a-f]+)

[clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

fmayer wrote: > . The point of this patch is not to lambast developers or interfere with > their local setups; it's to get the line-ending issues out of the way for > good so they can focus on what they do best. Fair enough. I don't think it will fully make them go away for good, as you

[clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

fmayer wrote: > That wish is fine until you start working with others. Do we actually have that little faith in developers that we think they will check in a 50k line diff? https://github.com/llvm/llvm-project/pull/86318 ___ cfe-commits mailing list

[clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

fmayer wrote: I don't have a strong opinion, but fundamentally I would prefer if the source control system stored exactly the files I have in my checkout, not mess with them in any way. I understand there are practical concerns, but a linter for unexpected CRLF would maybe be an option?

[clang] [clang-repl] Pass triple to IncrementalCompilerBuilder as explicit argument (PR #84174)

fmayer wrote: This triggers the leak detector in our HWASan build bot ``` Note: This is test shard 1 of 23. [==] Running 1 test from 1 test suite. [--] Global test environment set-up. [--] 1 test from IncrementalCompilerBuilder [ RUN ]

[libcxx] [llvm] [lld] [flang] [clang] [lldb] [libc] [libcxxabi] [msan] Unpoison indirect outputs for userspace using llvm.memset.* (PR #79924)

https://github.com/fmayer approved this pull request. https://github.com/llvm/llvm-project/pull/79924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [NFC] Size and element numbers are often swapped when calling calloc (PR #79081)

https://github.com/fmayer closed https://github.com/llvm/llvm-project/pull/79081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [clang] [NFC] Size and element numbers are often swapped when calling calloc (PR #79081)

https://github.com/fmayer approved this pull request. https://github.com/llvm/llvm-project/pull/79081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] hurd: Fix build with -Werror,-Wswitch (PR #78520)

https://github.com/fmayer approved this pull request. Is there a reason you put this first? Otherwise IMO it is slightly neater to put it last. https://github.com/llvm/llvm-project/pull/78520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] hurd: Fix build with -Werror,-Wswitch (PR #78520)

fmayer wrote: Drive-by: is the `llvm_unreachable` actually unreachable? I.e. we never call this function with this case? Otherwise we are introducing UB in `NDEBUG` builds ``` /// In NDEBUG builds, if the platform does not support a builtin unreachable /// then we call an internal LLVM runtime

[clang] [llvm] Hurd: Add x86_64 support (PR #78065)

fmayer wrote: This broke Sanitizer bots: ``` [5/25] Building CXX object tools/clang/lib/Driver/CMakeFiles/obj.clangDriver.dir/ToolChains/Hurd.cpp.o FAILED: tools/clang/lib/Driver/CMakeFiles/obj.clangDriver.dir/ToolChains/Hurd.cpp.o CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache

[clang-tools-extra] [llvm] [clang] [AMDGPU] Reapply 'Sign extend simm16 in setreg intrinsic' (PR #78492)

https://github.com/fmayer approved this pull request. https://github.com/llvm/llvm-project/pull/78492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [libcxx] [lld] [flang] [compiler-rt] [libc] [clang-tools-extra] [clang] [hwasan] Workaround unsupported AssignmentTrackingPass (PR #76547)

https://github.com/fmayer approved this pull request. LGTM, but maybe be more explicit in the commit message how we work around this. https://github.com/llvm/llvm-project/pull/76547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libc] [clang] [openmp] [flang] [libcxx] [llvm] [compiler-rt] [lldb] [mlir] [hwasan] Classify stack overflow, and use after scope (PR #76133)

https://github.com/fmayer approved this pull request. https://github.com/llvm/llvm-project/pull/76133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [openmp] [libc] [compiler-rt] [lldb] [mlir] [flang] [libcxx] [clang] [hwasan] Classify stack overflow, and use after scope (PR #76133)

https://github.com/fmayer commented: Remove this comment? Line 780 ``` // TODO(fmayer): figure out how to distinguish use-after-return and // stack-buffer-overflow. ``` https://github.com/llvm/llvm-project/pull/76133 ___ cfe-commits mailing

[llvm] [openmp] [libc] [compiler-rt] [lldb] [mlir] [flang] [libcxx] [clang] [hwasan] Classify stack overflow, and use after scope (PR #76133)

@@ -221,29 +221,55 @@ static void PrintStackAllocations(const StackAllocationsRingBuffer *sa, for (LocalInfo : frame.locals) { if (!local.has_frame_offset || !local.has_size || !local.has_tag_offset) continue; +if (!(local.name &&

[clang] [llvm] [libcxx] [lldb] [flang] [openmp] [mlir] [libc] [compiler-rt] [hwasan] Classify stack overflow, and use after scope (PR #76133)

@@ -221,29 +221,55 @@ static void PrintStackAllocations(const StackAllocationsRingBuffer *sa, for (LocalInfo : frame.locals) { if (!local.has_frame_offset || !local.has_size || !local.has_tag_offset) continue; +if (!(local.name &&

[llvm] [lldb] [mlir] [libc] [compiler-rt] [flang] [clang] [openmp] [hwasan] Respect strip_path_prefix printing locals (PR #76132)

https://github.com/fmayer approved this pull request. Lgtm thanks https://github.com/llvm/llvm-project/pull/76132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [hwasan] Separate sections in report (PR #76130)

https://github.com/fmayer approved this pull request. https://github.com/llvm/llvm-project/pull/76130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [clang] [hwasan] Separate sections in report (PR #76130)

fmayer wrote: LGTM. Could you explain in the description why we are doing this? https://github.com/llvm/llvm-project/pull/76130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 043d03d - Revert "Reland "Fix __cfi_check not aligned to 4k on relocatable files with no executable code""

Author: Florian Mayer Date: 2023-08-04T14:24:26-07:00 New Revision: 043d03d25bd7eadef66685de298342b35fe6b466 URL: https://github.com/llvm/llvm-project/commit/043d03d25bd7eadef66685de298342b35fe6b466 DIFF: https://github.com/llvm/llvm-project/commit/043d03d25bd7eadef66685de298342b35fe6b466.diff

[clang] a2684ac - [HWASan] use hwasan linker for Android 14+

Author: Florian Mayer Date: 2023-05-26T14:25:46-07:00 New Revision: a2684acfb61d40f441e240035d7f1ba50da637c8 URL: https://github.com/llvm/llvm-project/commit/a2684acfb61d40f441e240035d7f1ba50da637c8 DIFF: https://github.com/llvm/llvm-project/commit/a2684acfb61d40f441e240035d7f1ba50da637c8.diff

[libunwind] f5c9931 - [libunwind] Fix compile error with CROSS_UNWINDING

Author: Florian Mayer Date: 2022-09-30T12:04:19-07:00 New Revision: f5c9931fefcab8de07a6c08c39b582fa58859dc9 URL: https://github.com/llvm/llvm-project/commit/f5c9931fefcab8de07a6c08c39b582fa58859dc9 DIFF: https://github.com/llvm/llvm-project/commit/f5c9931fefcab8de07a6c08c39b582fa58859dc9.diff

[libunwind] a315338 - [libunwind] Handle G in personality string

Author: Florian Mayer Date: 2022-09-21T14:13:32-07:00 New Revision: a3153381af48b2e704750255a704748a13c4c4de URL: https://github.com/llvm/llvm-project/commit/a3153381af48b2e704750255a704748a13c4c4de DIFF: https://github.com/llvm/llvm-project/commit/a3153381af48b2e704750255a704748a13c4c4de.diff

[libunwind] fc6a6ee - [libunwind] undef NDEBUG for assert.h in tests.

Author: Florian Mayer Date: 2022-08-04T19:55:40-07:00 New Revision: fc6a6ee507ec2df0df7d34ba19feccb776297e4c URL: https://github.com/llvm/llvm-project/commit/fc6a6ee507ec2df0df7d34ba19feccb776297e4c DIFF: https://github.com/llvm/llvm-project/commit/fc6a6ee507ec2df0df7d34ba19feccb776297e4c.diff

[libunwind] 53c1584 - [NFC] [libunwind] turn assert into static_assert

Author: Florian Mayer Date: 2022-06-03T16:32:42-07:00 New Revision: 53c1584063e8f3225bfe71724cc7de79576ea61a URL: https://github.com/llvm/llvm-project/commit/53c1584063e8f3225bfe71724cc7de79576ea61a DIFF: https://github.com/llvm/llvm-project/commit/53c1584063e8f3225bfe71724cc7de79576ea61a.diff

[libunwind] 13b8bfc - [libunwind] Add more information to eh_frame_hdr version error

Author: Florian Mayer Date: 2022-06-01T19:48:19-07:00 New Revision: 13b8bfc51451fcfc00f3e3480abaf64b337a43d4 URL: https://github.com/llvm/llvm-project/commit/13b8bfc51451fcfc00f3e3480abaf64b337a43d4 DIFF: https://github.com/llvm/llvm-project/commit/13b8bfc51451fcfc00f3e3480abaf64b337a43d4.diff

[clang] 1d730d8 - [HWASAN] erase lifetime intrinsics if tag is outside.

Author: Florian Mayer Date: 2022-03-01T14:47:33-08:00 New Revision: 1d730d80ce592fde66b1ba6153f08f72778f94ce URL: https://github.com/llvm/llvm-project/commit/1d730d80ce592fde66b1ba6153f08f72778f94ce DIFF: https://github.com/llvm/llvm-project/commit/1d730d80ce592fde66b1ba6153f08f72778f94ce.diff

[clang-tools-extra] 45abbaf - Revert "[clangd] Support `#pragma mark` in the outline"

Author: Florian Mayer Date: 2021-08-10T14:25:52+01:00 New Revision: 45abbaf2e5fbdf27c9f8ba01b34018b0be45b7c9 URL: https://github.com/llvm/llvm-project/commit/45abbaf2e5fbdf27c9f8ba01b34018b0be45b7c9 DIFF: https://github.com/llvm/llvm-project/commit/45abbaf2e5fbdf27c9f8ba01b34018b0be45b7c9.diff

[clang] 835ef6f - [hwasan] Fix stack safety test for old PM.

Author: Florian Mayer Date: 2021-07-27T20:50:46+01:00 New Revision: 835ef6f93d5789d3d7d905462e7574a38b30577d URL: https://github.com/llvm/llvm-project/commit/835ef6f93d5789d3d7d905462e7574a38b30577d DIFF: https://github.com/llvm/llvm-project/commit/835ef6f93d5789d3d7d905462e7574a38b30577d.diff

[clang] 789a4a2 - Revert "[hwasan] Use stack safety analysis."

Author: Florian Mayer Date: 2021-07-22T12:16:16+01:00 New Revision: 789a4a2e5c30b3eee632446d5b99bba808587836 URL: https://github.com/llvm/llvm-project/commit/789a4a2e5c30b3eee632446d5b99bba808587836 DIFF: https://github.com/llvm/llvm-project/commit/789a4a2e5c30b3eee632446d5b99bba808587836.diff

[clang] bde9415 - [hwasan] Use stack safety analysis.

Author: Florian Mayer Date: 2021-07-22T12:04:54+01:00 New Revision: bde9415fef25e9ff6e10595a2f4f5004dd62f10a URL: https://github.com/llvm/llvm-project/commit/bde9415fef25e9ff6e10595a2f4f5004dd62f10a DIFF: https://github.com/llvm/llvm-project/commit/bde9415fef25e9ff6e10595a2f4f5004dd62f10a.diff

[clang] 5f08219 - Revert "[hwasan] Use stack safety analysis."

Author: Florian Mayer Date: 2021-07-20T10:36:46+01:00 New Revision: 5f08219322456b867605e4a19003f58ee418758f URL: https://github.com/llvm/llvm-project/commit/5f08219322456b867605e4a19003f58ee418758f DIFF: https://github.com/llvm/llvm-project/commit/5f08219322456b867605e4a19003f58ee418758f.diff

[clang] e9c63ed - [hwasan] Use stack safety analysis.

Author: Florian Mayer Date: 2021-07-20T10:06:35+01:00 New Revision: e9c63ed10b3bdf6eb3fa76d1a3eb403d6fc6a118 URL: https://github.com/llvm/llvm-project/commit/e9c63ed10b3bdf6eb3fa76d1a3eb403d6fc6a118 DIFF: https://github.com/llvm/llvm-project/commit/e9c63ed10b3bdf6eb3fa76d1a3eb403d6fc6a118.diff

[clang] 807d501 - Revert "[hwasan] Use stack safety analysis."

Author: Florian Mayer Date: 2021-07-19T12:08:32+01:00 New Revision: 807d50100c3c6cd5e6ec89d6ac1afddd0c3f7133 URL: https://github.com/llvm/llvm-project/commit/807d50100c3c6cd5e6ec89d6ac1afddd0c3f7133 DIFF: https://github.com/llvm/llvm-project/commit/807d50100c3c6cd5e6ec89d6ac1afddd0c3f7133.diff

[clang] 12268fe - [hwasan] Use stack safety analysis.

Author: Florian Mayer Date: 2021-07-19T11:54:44+01:00 New Revision: 12268fe14a1a65d4b62f0b6e5beab46ba8501ae7 URL: https://github.com/llvm/llvm-project/commit/12268fe14a1a65d4b62f0b6e5beab46ba8501ae7 DIFF: https://github.com/llvm/llvm-project/commit/12268fe14a1a65d4b62f0b6e5beab46ba8501ae7.diff