[PATCH] D90972: [clang-tidy] Install run-clang-tidy.py in bin/ as run-clang-tidy

[Florian Schmaus via Phabricator via cfe-commits]

Flow added a comment.

In D90972#2580020 , @njames93 wrote:

> In D90972#2446448 , @Flow wrote:
>
>> In D90972#2394516 , @JonasToth 
>> wrote:
>>
>>> LGTM! thanks for fixing.
>>
>> I am unable to commit this myself. The latest version of this change 
>> 
>>  can be found in the install-run-clang-tidy-into-bin 
>> 
>>  on my LLVM fork .
>
> Noticed this is a little stale, Do you still want this landing?

This probably was not addressed to me, but yes I want this to land but need 
someone to sponsor the commit. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90972/new/

https://reviews.llvm.org/D90972

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90972: [clang-tidy] Install run-clang-tidy.py in bin/ as run-clang-tidy

[Florian Schmaus via Phabricator via cfe-commits]

Flow requested review of this revision.
Flow added a comment.

In D90972#2394516 , @JonasToth wrote:

> LGTM! thanks for fixing.

I am unable to commit this myself. The latest version of this change 

 can be found in the install-run-clang-tidy-into-bin 

 on my LLVM fork .


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90972/new/

https://reviews.llvm.org/D90972

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90972: [clang-tidy] Install run-clang-tidy.py in bin/ as run-clang-tidy

[Florian Schmaus via Phabricator via cfe-commits]

Flow updated this revision to Diff 303642.
Flow added a comment.

Use backticks in ReleaseNotes


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90972/new/

https://reviews.llvm.org/D90972

Files:
  clang-tools-extra/clang-tidy/tool/CMakeLists.txt
  clang-tools-extra/docs/ReleaseNotes.rst


Index: clang-tools-extra/docs/ReleaseNotes.rst
===
--- clang-tools-extra/docs/ReleaseNotes.rst
+++ clang-tools-extra/docs/ReleaseNotes.rst
@@ -73,6 +73,9 @@
   ` and
   :doc:`modernize-make-unique `.
 
+- The `run-clang-tidy.py` helper script is now installed in `bin/` as
+  `run-clang-tidy`. It was previously installed in `share/clang/`.
+
 New modules
 ^^^
 
Index: clang-tools-extra/clang-tidy/tool/CMakeLists.txt
===
--- clang-tools-extra/clang-tidy/tool/CMakeLists.txt
+++ clang-tools-extra/clang-tidy/tool/CMakeLists.txt
@@ -55,5 +55,6 @@
   DESTINATION share/clang
   COMPONENT clang-tidy)
 install(PROGRAMS run-clang-tidy.py
-  DESTINATION share/clang
-  COMPONENT clang-tidy)
+  DESTINATION bin
+  COMPONENT clang-tidy
+  RENAME run-clang-tidy)


Index: clang-tools-extra/docs/ReleaseNotes.rst
===
--- clang-tools-extra/docs/ReleaseNotes.rst
+++ clang-tools-extra/docs/ReleaseNotes.rst
@@ -73,6 +73,9 @@
   ` and
   :doc:`modernize-make-unique `.
 
+- The `run-clang-tidy.py` helper script is now installed in `bin/` as
+  `run-clang-tidy`. It was previously installed in `share/clang/`.
+
 New modules
 ^^^
 
Index: clang-tools-extra/clang-tidy/tool/CMakeLists.txt
===
--- clang-tools-extra/clang-tidy/tool/CMakeLists.txt
+++ clang-tools-extra/clang-tidy/tool/CMakeLists.txt
@@ -55,5 +55,6 @@
   DESTINATION share/clang
   COMPONENT clang-tidy)
 install(PROGRAMS run-clang-tidy.py
-  DESTINATION share/clang
-  COMPONENT clang-tidy)
+  DESTINATION bin
+  COMPONENT clang-tidy
+  RENAME run-clang-tidy)
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D91001: [clang-tidy] Install run-clang-tidy.py as run-clang-tidy

[Florian Schmaus via Phabricator via cfe-commits]

Flow abandoned this revision.
Flow added a comment.

All changes introduced by this are now done in https://reviews.llvm.org/D90972


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91001/new/

https://reviews.llvm.org/D91001

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90972: [clang-tidy] Install run-clang-tidy.py in bin/ as run-clang-tidy

[Florian Schmaus via Phabricator via cfe-commits]

Flow updated this revision to Diff 303638.
Flow retitled this revision from "[clang-tidy] Install run-clang-tidy.py in 
bin/ not in share/clang/" to "[clang-tidy] Install run-clang-tidy.py in bin/ as 
run-clang-tidy".

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90972/new/

https://reviews.llvm.org/D90972

Files:
  clang-tools-extra/clang-tidy/tool/CMakeLists.txt
  clang-tools-extra/docs/ReleaseNotes.rst


Index: clang-tools-extra/docs/ReleaseNotes.rst
===
--- clang-tools-extra/docs/ReleaseNotes.rst
+++ clang-tools-extra/docs/ReleaseNotes.rst
@@ -73,6 +73,9 @@
   ` and
   :doc:`modernize-make-unique `.
 
+- The run-clang-tidy.py helper script is now installed in bin/ as
+  run-clang-tidy. It was previously installed in share/clang/.
+
 New modules
 ^^^
 
Index: clang-tools-extra/clang-tidy/tool/CMakeLists.txt
===
--- clang-tools-extra/clang-tidy/tool/CMakeLists.txt
+++ clang-tools-extra/clang-tidy/tool/CMakeLists.txt
@@ -55,5 +55,6 @@
   DESTINATION share/clang
   COMPONENT clang-tidy)
 install(PROGRAMS run-clang-tidy.py
-  DESTINATION share/clang
-  COMPONENT clang-tidy)
+  DESTINATION bin
+  COMPONENT clang-tidy
+  RENAME run-clang-tidy)


Index: clang-tools-extra/docs/ReleaseNotes.rst
===
--- clang-tools-extra/docs/ReleaseNotes.rst
+++ clang-tools-extra/docs/ReleaseNotes.rst
@@ -73,6 +73,9 @@
   ` and
   :doc:`modernize-make-unique `.
 
+- The run-clang-tidy.py helper script is now installed in bin/ as
+  run-clang-tidy. It was previously installed in share/clang/.
+
 New modules
 ^^^
 
Index: clang-tools-extra/clang-tidy/tool/CMakeLists.txt
===
--- clang-tools-extra/clang-tidy/tool/CMakeLists.txt
+++ clang-tools-extra/clang-tidy/tool/CMakeLists.txt
@@ -55,5 +55,6 @@
   DESTINATION share/clang
   COMPONENT clang-tidy)
 install(PROGRAMS run-clang-tidy.py
-  DESTINATION share/clang
-  COMPONENT clang-tidy)
+  DESTINATION bin
+  COMPONENT clang-tidy
+  RENAME run-clang-tidy)
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90972: [clang-tidy] Install run-clang-tidy.py in bin/ not in share/clang/

[Florian Schmaus via Phabricator via cfe-commits]

Flow added a comment.

In D90972#2380640 , @sylvestre.ledru 
wrote:

> By the way, while you are working on it, why not removing the python 
> extension when installing? We don't need to know that it is Python code.

Thanks for the feedback. Please see https://reviews.llvm.org/D91001


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90972/new/

https://reviews.llvm.org/D90972

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D91001: [clang-tidy] Install run-clang-tidy.py as run-clang-tidy

[Florian Schmaus via Phabricator via cfe-commits]

Flow created this revision.
Flow added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, xazax.hun, mgorny.
Herald added a project: clang.
Flow requested review of this revision.

Installed scripts in PATH usually do not carry a filename extension,
since there is no need to know that this is a Python script. For
example Debian and Ubuntu already install this script as
'run-clang-tidy' [1] and hence build systems like Meson also look for
this name first [2].

This changes was suggested by Sylvestre Ledru [3].

1: 
https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/-/blob/60aefb14171ab5c3867a0081844b507fc9f6e015/debian/clang-tidy-X.Y.links.in#L2
2: 
https://github.com/mesonbuild/meson/blob/b6dc4d5e5c6e838de0b52e62d982ba2547eb366d/mesonbuild/scripts/clangtidy.py#L44
3: https://reviews.llvm.org/D90972#2380640


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D91001

Files:
  clang-tools-extra/clang-tidy/tool/CMakeLists.txt


Index: clang-tools-extra/clang-tidy/tool/CMakeLists.txt
===
--- clang-tools-extra/clang-tidy/tool/CMakeLists.txt
+++ clang-tools-extra/clang-tidy/tool/CMakeLists.txt
@@ -56,4 +56,5 @@
   COMPONENT clang-tidy)
 install(PROGRAMS run-clang-tidy.py
   DESTINATION bin
-  COMPONENT clang-tidy)
+  COMPONENT clang-tidy
+  RENAME run-clang-tidy)


Index: clang-tools-extra/clang-tidy/tool/CMakeLists.txt
===
--- clang-tools-extra/clang-tidy/tool/CMakeLists.txt
+++ clang-tools-extra/clang-tidy/tool/CMakeLists.txt
@@ -56,4 +56,5 @@
   COMPONENT clang-tidy)
 install(PROGRAMS run-clang-tidy.py
   DESTINATION bin
-  COMPONENT clang-tidy)
+  COMPONENT clang-tidy
+  RENAME run-clang-tidy)
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90972: [clang-tidy] Install run-clang-tidy.py in bin/ not in share/clang/

[Florian Schmaus via Phabricator via cfe-commits]

Flow added reviewers: alexfh, sylvestre.ledru, Eugene.Zelenko.
Flow added a comment.

Adding involved persons from https://reviews.llvm.org/D12700 as reviewers, 
which was the change introducing `share/clang/` as install location.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90972/new/

https://reviews.llvm.org/D90972

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90972: [clang-tidy] Install run-clang-tidy.py in bin/ not in share/clang/

[Florian Schmaus via Phabricator via cfe-commits]

Flow created this revision.
Flow added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, xazax.hun, mgorny.
Herald added a project: clang.
Flow requested review of this revision.

The run-clang-tidy.py helper script is supposed to be used by the
user, hence it should be placed in the user's PATH. Some
distributions, like Gentoo [1], won't have it in PATH unless it is
installed in bin/.

1: https://bugs.gentoo.org/753380


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D90972

Files:
  clang-tools-extra/clang-tidy/tool/CMakeLists.txt


Index: clang-tools-extra/clang-tidy/tool/CMakeLists.txt
===
--- clang-tools-extra/clang-tidy/tool/CMakeLists.txt
+++ clang-tools-extra/clang-tidy/tool/CMakeLists.txt
@@ -55,5 +55,5 @@
   DESTINATION share/clang
   COMPONENT clang-tidy)
 install(PROGRAMS run-clang-tidy.py
-  DESTINATION share/clang
+  DESTINATION bin
   COMPONENT clang-tidy)


Index: clang-tools-extra/clang-tidy/tool/CMakeLists.txt
===
--- clang-tools-extra/clang-tidy/tool/CMakeLists.txt
+++ clang-tools-extra/clang-tidy/tool/CMakeLists.txt
@@ -55,5 +55,5 @@
   DESTINATION share/clang
   COMPONENT clang-tidy)
 install(PROGRAMS run-clang-tidy.py
-  DESTINATION share/clang
+  DESTINATION bin
   COMPONENT clang-tidy)
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits