[PATCH] D126498: [clangd] Fix hover crashing on integral or enumeral casts

gkll requested review of this revision. gkll marked an inline comment as done. gkll added a comment. Mhm, I think the change here has gone under the radar  CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126498/new/ https://reviews.llvm.org/D126498

[PATCH] D126498: [clangd] Fix hover crashing on integral or enumeral casts

gkll marked 2 inline comments as done. gkll added a comment. Thank you, and sorry for the chaos, this is my first submission to llvm :D Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:3221 + TestTU TU = TestTU::withCode(T.code()); + TU.OmitPredefinedMacros =

[PATCH] D126498: [clangd] Fix hover crashing on integral or enumeral casts

gkll updated this revision to Diff 433304. gkll added a comment. Avoid double negation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126498/new/ https://reviews.llvm.org/D126498 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/unittests/HoverTests.cpp

[PATCH] D126498: [clangd] Fix hover crashing on integral or enumeral casts

gkll updated this revision to Diff 433217. gkll added a comment. Fixed formatting of `Argv` array. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126498/new/ https://reviews.llvm.org/D126498 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/unittests/HoverTests.cpp

[PATCH] D126498: [clangd] Fix hover crashing on integral or enumeral casts

gkll updated this revision to Diff 433211. gkll added a comment. Use `uintptr_t` instead of `unsigned long` for the casts, to ensure the pointer always fits into the integer type. For example on Windows x64 that was previously not the case, because there `unsigned long` is only 32-bits wide.

[PATCH] D126498: [clangd] Fix hover crashing on integral or enumeral casts

gkll updated this revision to Diff 433174. gkll added a comment. Changed return type of non-returning function in test code to void. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126498/new/ https://reviews.llvm.org/D126498 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D126498: [clangd] Fix hover crashing on integral or enumeral casts

gkll added a comment. In D126498#3548168 , @sammccall wrote: > In D126498#3548132 , @gkll wrote: > >> In D126498#3548013 , @sammccall >> wrote: >> >>> Oh wow, my mental

[PATCH] D126498: [clangd] Fix hover crashing on integral or enumeral casts

gkll added a comment. In D126498#3548013 , @sammccall wrote: > Oh wow, my mental model of these was all wrong. > > Thank you! Do you want me to land this for you? Yeah, that would be great, thank you! Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D126498: [clangd] Fix hover crashing on integral or enumeral casts

gkll created this revision. gkll added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. gkll requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.