glenjofe added a comment.
Thanks Eric. Can you commit on my behalf?
https://reviews.llvm.org/D35470
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
glenjofe added inline comments.
Comment at: test/std/utilities/memory/pointer.conversion/to_address.pass.cpp:119
+ASSERT_NOEXCEPT(std::to_address(p4));
+assert(std::to_address(p4) == );
+}
EricWF wrote:
> Shouldn't one of these tests hit a non-noexcept
glenjofe updated this revision to Diff 123531.
glenjofe marked 2 inline comments as done.
glenjofe added a comment.
Address Eric's review comments.
https://reviews.llvm.org/D35470
Files:
include/memory
test/std/utilities/memory/pointer.conversion/to_address.pass.cpp
Index:
glenjofe updated this revision to Diff 123520.
glenjofe added a comment.
Now implements P0653R2 which was accepted in Albuquerque.
https://reviews.llvm.org/D35470
Files:
include/memory
test/std/utilities/memory/pointer.conversion/to_address.pass.cpp
Index:
glenjofe updated this revision to Diff 106965.
glenjofe removed rL LLVM as the repository for this revision.
glenjofe added a comment.
Include full context in the diff.
https://reviews.llvm.org/D35470
Files:
include/memory
glenjofe created this revision.
glenjofe created this object with edit policy "No One".
A tiny patch that implements P0653R0 (or D0653R1 which revises the former with
only a small editorial change after LEWG review).
Repository:
rL LLVM
https://reviews.llvm.org/D35470
Files:
