[PATCH] D103793: [Clang][OpenMP] Monotonic does not apply to SIMD

This revision was automatically updated to reflect the committed changes. Closed by commit rGc6a91ee6: [Clang][OpenMP] Monotonic does not apply to SIMD (authored by huntergr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103793/new/

[PATCH] D103793: [Clang][OpenMP] Monotonic does not apply to SIMD

huntergr added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103793/new/ https://reviews.llvm.org/D103793 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D103793: [Clang][OpenMP] Monotonic does not apply to SIMD

huntergr added a comment. Apologies for not including more of the diff for context, but the test files are large enough that the full diff exceeds the maximum upload size. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103793/new/

[PATCH] D103793: [Clang][OpenMP] Monotonic does not apply to SIMD

huntergr created this revision. huntergr added reviewers: ABataev, kkwli0. Herald added subscribers: guansong, yaxunl. huntergr requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. The codegen for

[PATCH] D75350: [OpenMP] Allow const parameters in declare simd linear clause

This revision was automatically updated to reflect the committed changes. Closed by commit rGad497658d25a: [OpenMP] Allow const parameters in declare simd linear clause (authored by huntergr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75350/new/

[PATCH] D75350: [OpenMP] Allow const parameters in declare simd linear clause

huntergr updated this revision to Diff 247614. huntergr added a comment. - Removed the ) my editor helpfully added to the CHECK line - Added a test to declare_simd_aarch64.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75350/new/

[PATCH] D75350: [OpenMP] Allow const parameters in declare simd linear clause

huntergr updated this revision to Diff 247294. huntergr added a comment. - Added a function body to the test so that it would generate symbols - Added check lines to ensure the mangled name is present - Reformatted the params of Sema::CheckOpenMPLinearDecl to comply with coding style.

[PATCH] D75350: [OpenMP] Allow const parameters in declare simd linear clause

huntergr added inline comments. Comment at: clang/test/OpenMP/declare_simd_codegen.cpp:118 +#pragma omp declare simd notinbranch linear(i) +double constlinear(const int i); + fpetrogalli wrote: > Shouldn't you check that the `_ZGV *` name is generated? Ok, and I

[PATCH] D75350: [OpenMP] Allow const parameters in declare simd linear clause

huntergr created this revision. huntergr added reviewers: ABataev, kkwli0. Herald added a subscriber: guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. Section 2.19.3 (List Item Privatization) of the OpenMP 5.0 standard does not apply to declarative directives, only to

[PATCH] D53137: Scalable vector core instruction support + size queries

huntergr added a comment. Hmm, forgot to add the last round of minor fixes before committing. Sorry about that, will push them as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53137/new/ https://reviews.llvm.org/D53137

[PATCH] D53137: Scalable vector core instruction support + size queries

This revision was automatically updated to reflect the committed changes. Closed by commit rGb302561b763a: [SVE][IR] Scalable Vector size queries and IR instruction support (authored by huntergr). Changed prior to commit: https://reviews.llvm.org/D53137?vs=222593=223835#toc Repository: rG

[PATCH] D53137: Scalable vector core instruction support + size queries

huntergr updated this revision to Diff 222593. huntergr added a comment. Herald added a subscriber: dexonsmith. - Renamed `ScalableSize` to `TypeSize`, including header name. - added `alignTo` function that takes and returns a `TypeSize`. I wasn't sure if this should be added to MathExtras.h

[PATCH] D53137: Scalable vector core instruction support + size queries

huntergr added inline comments. Comment at: llvm/include/llvm/IR/DataLayout.h:454 +auto BaseSize = getTypeSizeInBits(Ty); +return { (BaseSize.getKnownMinSize() + 7) / 8, BaseSize.isScalable() }; } rovka wrote: > We already overload operator /, why not

[PATCH] D53137: Scalable vector core instruction support + size queries

huntergr updated this revision to Diff 221283. huntergr added a comment. Herald added subscribers: cfe-commits, haicheng, eraman. Herald added a project: clang. - Changed existing interface to return ScalableSize objects and added a (mostly) transparent conversion, as per Sander's suggestion. -

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

huntergr abandoned this revision. huntergr added a comment. In D31417#1450587 , @xtian wrote: > LGTM. This provides a consistent behavior same as GCC and ICC w/ > -fopenmp-simd option. To answer, Kelvin's question. it is not directly tied > with

[PATCH] D53138: Scalable type size queries (clang)

huntergr abandoned this revision. huntergr added a comment. Abandoning this. At the devmeeting it was agreed that 'getPrimitiveSizeInBits' should continue to work as-is for fixed-length vectors and only behave differently for scalable vectors. https://reviews.llvm.org/D53138

[PATCH] D53138: Scalable type size queries (clang)

huntergr created this revision. Initial changes for clang to use the scalable type size queries (https://reviews.llvm.org/D53137) This isn't ready for inclusion yet, more discussion on the mailing list required. https://reviews.llvm.org/D53138 Files: lib/CodeGen/CGBuiltin.cpp

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

huntergr added a comment. In https://reviews.llvm.org/D31417#886441, @hfinkel wrote: > Is this still being worked on? Hi, yes it is. Sorry for the delay in posting new changes but priorities shifted a bit and I had to work on something else for a while. I do have a new version that's just

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

huntergr added inline comments. Comment at: lib/Parse/ParseOpenMP.cpp:174 + case OMPD_target_teams_distribute_simd: +DKind = OMPD_simd; +break; ABataev wrote: > huntergr wrote: > > rengolin wrote: > > > I'd like @ABataev to confirm this is

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

huntergr added inline comments. Comment at: lib/Parse/ParseOpenMP.cpp:174 + case OMPD_target_teams_distribute_simd: +DKind = OMPD_simd; +break; rengolin wrote: > I'd like @ABataev to confirm this is the right semantics. Yes, would be good. I

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

huntergr updated this revision to Diff 93841. huntergr added a reviewer: kkwli0. huntergr added a comment. Changed to transform combined constructs to simd in ParseOpenMP.cpp instead of creating a new pragma handler. This also made it easier to add support for 'declare simd': only needed the

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

huntergr added a comment. Hi Renato, In https://reviews.llvm.org/D31417#713162, @rengolin wrote: > I don't know much about Clang's machinery, but would it be possible to have > `-fopenmp-simd` generate the same handler, but with restrictions? I fear this > slight duplication could get

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

huntergr added a comment. In https://reviews.llvm.org/D31417#712008, @fpetrogalli wrote: > Hi Graham, > > thank you for working on this. I understand that you are gonna take care of > the CodeGen side of things for the new `-fopenmp-simd` option in a separate > patch? CodeGen for 'simd'

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

huntergr created this revision. Herald added a subscriber: rengolin. Adds a new flag ('-fopenmp-simd') to clang which enables processing of 'simd' and 'declare simd' pragmas without supporting the rest of OpenMP. The pragma handler will filter out directives and clauses which aren't related to