[PATCH] D34788: [ASTReader] Add test for previous change r306583 / 145692e.

2017-06-29 Thread Graydon Hoare via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL306732: [ASTReader] Add test for previous change r306583 / 145692e. (authored by graydon). Repository: rL LLVM https://reviews.llvm.org/D34788 Files:

[PATCH] D34788: [ASTReader] Add test for previous change r306583 / 145692e.

2017-06-28 Thread Graydon Hoare via Phabricator via cfe-commits
graydon created this revision. Add a test for the change to ASTReader that reproduces the logic for consolidating multiple ObjC interface definitions to the case of multiple ObjC protocol definitions. This test is a modified copy of the test that accompanied the original change to interfaces, in

[PATCH] D34741: [ASTReader] Treat multiple defns of ObjC protocols the same as interfaces.

2017-06-28 Thread Graydon Hoare via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL306583: [ASTReader] Treat multiple defns of ObjC protocols the same as interfaces. (authored by graydon). Repository: rL LLVM https://reviews.llvm.org/D34741 Files:

[PATCH] D34741: [ASTReader] Treat multiple defns of ObjC protocols the same as interfaces.

2017-06-28 Thread Graydon Hoare via Phabricator via cfe-commits
graydon created this revision. In change 2ba19793512, the ASTReader logic for ObjC interfaces was modified to preserve the first definition-data read, "merging" later definitions into it rather than overwriting it (though this "merging" is, in practice, a no-op that discards the later

[PATCH] D31378: [PCH] Attach instance's dependency collectors to PCH external AST sources.

2017-03-29 Thread Graydon Hoare via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL299009: [PCH] Attach instance's dependency collectors to PCH external AST sources. (authored by graydon). Changed prior to commit: https://reviews.llvm.org/D31378?vs=93089=93387#toc Repository: rL

[PATCH] D31378: [PCH] Attach instance's dependency collectors to PCH external AST sources.

2017-03-26 Thread Graydon Hoare via Phabricator via cfe-commits
graydon created this revision. When a PCH is included via -include-pch, clang should treat the current TU as dependent on the sourcefile that the PCH was generated from. This is currently _partly_ accomplished by InitializePreprocessor calling AddImplicitIncludePCH to synthesize an implicit

[PATCH] D28779: [ASTReader] Add a DeserializationListener callback for IMPORTED_MODULES

2017-01-18 Thread Graydon Hoare via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL292436: [ASTReader] Add a DeserializationListener callback for IMPORTED_MODULES (authored by graydon). Changed prior to commit: https://reviews.llvm.org/D28779?vs=84594=84881#toc Repository: rL LLVM

[PATCH] D28790: [Modules] Correct test comment from obsolete earlier version of code. NFC

2017-01-18 Thread Graydon Hoare via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL292435: [Modules] Correct test comment from obsolete earlier version of code. NFC (authored by graydon). Changed prior to commit: https://reviews.llvm.org/D28790?vs=84616=84879#toc Repository: rL

[PATCH] D28790: [Modules] Correct test comment from obsolete earlier version of code. NFC

2017-01-16 Thread Graydon Hoare via Phabricator via cfe-commits
graydon created this revision. Code committed in https://reviews.llvm.org/rL290219 went through a few iterations; test wound up with stale comment. https://reviews.llvm.org/D28790 Files: test/Modules/implicit-private-with-different-name.m Index:

[PATCH] D28779: [ASTReader] Add a DeserializationListener callback for IMPORTED_MODULES

2017-01-16 Thread Graydon Hoare via Phabricator via cfe-commits
graydon created this revision. Add a callback from ASTReader to DeserializationListener when the former reads an IMPORTED_MODULES block. This supports Swift in using PCH for bridging headers. https://reviews.llvm.org/D28779 Files: include/clang/Serialization/ASTDeserializationListener.h

[PATCH] D27852: [modules] Handle modules with nonstandard names in module.private.modulemaps

2016-12-20 Thread Graydon Hoare via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL290219: [modules] Handle modules with nonstandard names in module.private.modulemaps (authored by graydon). Changed prior to commit: https://reviews.llvm.org/D27852?vs=82161=82177#toc Repository: rL

[PATCH] D27852: [modules] Handle modules with nonstandard names in module.private.modulemaps

2016-12-20 Thread Graydon Hoare via Phabricator via cfe-commits
graydon added inline comments. Comment at: test/Modules/implicit-private-with-different-name.m:13 +// expected-warning@Inputs/implicit-private-with-different-name/A.framework/Modules/module.private.modulemap:1{{top-level module 'APrivate' in private module map, expected a

[PATCH] D27852: [modules] Handle modules with nonstandard names in module.private.modulemaps

2016-12-20 Thread Graydon Hoare via Phabricator via cfe-commits
graydon updated this revision to Diff 82161. graydon added a comment. Updates to address review comments https://reviews.llvm.org/D27852 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticLexKinds.td include/clang/Lex/HeaderSearch.h lib/Lex/HeaderSearch.cpp

[PATCH] D27852: [modules] Handle modules with nonstandard names in module.private.modulemaps

2016-12-20 Thread Graydon Hoare via Phabricator via cfe-commits
graydon marked 5 inline comments as done. graydon added a comment. Addressed review comments https://reviews.llvm.org/D27852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27852: [modules] Handle modules with nonstandard names in module.private.modulemaps

2016-12-16 Thread Graydon Hoare via Phabricator via cfe-commits
graydon created this revision. graydon added reviewers: manmanren, doug.gregor. graydon added a subscriber: cfe-commits. The module system supports accompanying a primary module (say Foo) with an auxiliary "private" module (defined in an adjacent module.private.modulemap file) that augments the

[PATCH] D27580: [modules] Add optional out-param to ASTReader::ReadAST for imported submodules.

2016-12-09 Thread Graydon Hoare via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL289276: [modules] Add optional out-param to ASTReader::ReadAST for imported submodules. (authored by graydon). Changed prior to commit: https://reviews.llvm.org/D27580?vs=80782=80952#toc Repository:

[PATCH] D27580: [modules] Add optional out-param to ASTReader::ReadAST for imported submodules.

2016-12-08 Thread Graydon Hoare via Phabricator via cfe-commits
graydon created this revision. graydon added reviewers: doug.gregor, manmanren, rsmith. graydon added a subscriber: cfe-commits. The Swift frontend is acquiring the ability to load non-module PCH files containing bridging definitions from C/ObjC. As part of this work, it needs to know which