[PATCH] D145183: [libc++] Implement `stop_token`

huixie90 updated this revision to Diff 524387. huixie90 added a comment. Herald added subscribers: cfe-commits, llvm-commits, lldb-commits, Sanitizers, TinaAMD, hoy, bviyer, wlei, jplehr, mgehre-amd, luke, hanchung, jsetoain, Moerafaat, zero9178, pcwang-thead, anlunx, Enna1, bzcheeseman, mattd,

[PATCH] D128611: [libc++] Implement `std::ranges::merge`

huixie90 updated this revision to Diff 440493. huixie90 added a comment. Herald added subscribers: cfe-commits, llvm-commits, libc-commits, openmp-commits, lldb-commits, Sanitizers, steakhal, nlopes, mtrofin, jsji, Enna1, bzcheeseman, kosarev, jsilvanus, mattd, gchakrabarti, ThomasRaoux,

[PATCH] D115107: [clang][clangd] Desugar array type.

This revision was automatically updated to reflect the committed changes. Closed by commit rG53219009aaeb: [clang][clangd] Desugar array type. (authored by lh123). Changed prior to commit: https://reviews.llvm.org/D115107?vs=391884=393110#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D114665: [clangd] Make a.k.a printing configurable.

This revision was automatically updated to reflect the committed changes. lh123 marked 3 inline comments as done. Closed by commit rG6fe577b1c1e4: [clangd] Make a.k.a printing configurable. (authored by lh123). Changed prior to commit: https://reviews.llvm.org/D114665?vs=391546=392648#toc

[PATCH] D114522: [clangd] Add desugared type to hover

This revision was automatically updated to reflect the committed changes. lh123 marked 2 inline comments as done. Closed by commit rGec64d10340da: [clangd] Add desugared type to hover (authored by lh123). Changed prior to commit: https://reviews.llvm.org/D114522?vs=391545=392640#toc

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1271 OS << " = " << *P.Default; + if (P.Type && P.Type->AKA) +OS << llvm::formatv(" (aka {0})", *P.Type->AKA); lh123 wrote: > sammccall wrote: > > kadircet wrote: > > >

[PATCH] D115108: [clangd] Print type for VarTemplateDecl in hover.

This revision was automatically updated to reflect the committed changes. Closed by commit rG51dc466642c5: [clangd] Print type for VarTemplateDecl in hover. (authored by lh123). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115108/new/

[PATCH] D114665: [clangd] Make a.k.a printing configurable.

lh123 marked an inline comment as done. lh123 added inline comments. Comment at: clang-tools-extra/clangd/ConfigFragment.h:271 + /// Describes hover preferences. + struct HoverBlock { +/// Whether hover show a.k.a type. sammccall wrote: > One question is

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1271 OS << " = " << *P.Default; + if (P.Type && P.Type->AKA) +OS << llvm::formatv(" (aka {0})", *P.Type->AKA); sammccall wrote: > kadircet wrote: > > sammccall wrote: > > >

[PATCH] D115108: [clangd] Print type for VarTemplateDecl in hover.

lh123 created this revision. lh123 added reviewers: kadircet, sammccall. lh123 added a project: clang-tools-extra. Herald added subscribers: usaxena95, arphaman. lh123 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Print type for

[PATCH] D115107: [clang][clangd] Desugar array type.

lh123 created this revision. lh123 added reviewers: sammccall, kadircet. lh123 added projects: clang, clang-tools-extra. Herald added subscribers: usaxena95, arphaman. lh123 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Desugar array type.

[PATCH] D114665: [clangd] Make a.k.a printing configurable.

lh123 updated this revision to Diff 391546. lh123 added a comment. rebase to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114665/new/ https://reviews.llvm.org/D114665 Files: clang-tools-extra/clangd/Config.h

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 updated this revision to Diff 391545. lh123 added a comment. rebase to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D114621: [clangd] Show parameters for construct.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7bb785cc339b: [clangd] Show parameters for construct. (authored by lh123). Changed prior to commit: https://reviews.llvm.org/D114621?vs=391537=391542#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D114621: [clangd] Show parameters for construct.

lh123 updated this revision to Diff 391537. lh123 marked 3 inline comments as done. lh123 added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114621/new/ https://reviews.llvm.org/D114621 Files:

[PATCH] D114665: [clangd] Make a.k.a printing configurable.

lh123 updated this revision to Diff 390158. lh123 retitled this revision from "[clangd] Add a way to enable a.k.a print through config" to "[clangd] Make a.k.a printing configurable.". lh123 added a comment. fix testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 updated this revision to Diff 390154. lh123 added a comment. format again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 updated this revision to Diff 390153. lh123 added a comment. format code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D114665: [clangd] Add a way to enable a.k.a print through config

lh123 created this revision. lh123 added reviewers: sammccall, kadircet. lh123 added a project: clang-tools-extra. Herald added subscribers: usaxena95, arphaman. lh123 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Currently, a.k.a printing is

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 updated this revision to Diff 390149. lh123 marked 13 inline comments as done. lh123 added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files:

[PATCH] D114621: [clangd] Show parameters for construct.

lh123 marked an inline comment as done. lh123 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1065 + if (Parameters && !Parameters->empty()) { +Output.addParagraph().appendText("Parameters: "); kadircet wrote: > it's a subtle

[PATCH] D114621: [clangd] Show parameters for construct.

lh123 updated this revision to Diff 390143. lh123 added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114621/new/ https://reviews.llvm.org/D114621 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 updated this revision to Diff 389968. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Hover.h

[PATCH] D114621: [clangd] Show parameters for construct.

lh123 created this revision. lh123 added reviewers: sammccall, kadircet. lh123 added a project: clang-tools-extra. Herald added subscribers: usaxena95, arphaman. lh123 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Show parameters for construct.

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:166 +if (ShouldAKA) + AKA = Result + DesugaredTy.getAsString(PP); + } lh123 wrote: > lh123 wrote: > > It seems we lost `namespace qualifiers`. > > It always display

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:166 +if (ShouldAKA) + AKA = Result + DesugaredTy.getAsString(PP); + } lh123 wrote: > It seems we lost `namespace qualifiers`. > It always display `std::string` as

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:166 +if (ShouldAKA) + AKA = Result + DesugaredTy.getAsString(PP); + } It seems we lost `namespace qualifiers`. It always display `std::string` as `basic_string` Repository:

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:691 } else { HI.Definition = printType(QT, PP); sammccall wrote: > This seems like a pretty important case to handle. > A wrinkle is that this gets treated as C++ code (e.g.

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 updated this revision to Diff 389931. lh123 added a comment. Herald added a reviewer: gkistanova. Move some `desugared type` to `Definition`. Repository: rZORG LLVM Github Zorg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files:

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 updated this revision to Diff 389924. lh123 added a comment. rename `TTP` to `TAT`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 updated this revision to Diff 389921. lh123 added a comment. handle `TypeAliasTemplateDecl`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 updated this revision to Diff 389915. lh123 retitled this revision from "[clangd] Add canonical type to hover" to "[clangd] Add desugared type to hover". lh123 edited the summary of this revision. lh123 added a comment. 1. rename `CanType` to `DesugaredTy`. 2. fix some bug in compare

[PATCH] D114522: [clangd] Add canonical type to hover

lh123 updated this revision to Diff 389911. lh123 added a comment. fix some bug. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D114522: [clangd] Add canonical type to hover

lh123 updated this revision to Diff 389909. lh123 added a comment. Herald added a project: clang. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files:

[PATCH] D114522: [clangd] Add canonical type to hover

lh123 added a comment. Related discussions: D72498 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 ___ cfe-commits mailing

[PATCH] D114522: [clangd] Add canonical type to hover

lh123 updated this revision to Diff 389638. lh123 added a comment. format code and add testcase for template. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D114522: [clangd] Add canonical type to hover

lh123 updated this revision to Diff 389452. lh123 added a comment. add testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D114522: [clangd] Add canonical type to hover

lh123 created this revision. lh123 added reviewers: kadircet, sammccall. lh123 added a project: clang-tools-extra. Herald added subscribers: usaxena95, arphaman. lh123 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Add canonical type to hover

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

This revision was automatically updated to reflect the committed changes. Closed by commit rG83fae3f76269: [CodeComplete] Add code completion after function equals (authored by lh123). Changed prior to commit: https://reviews.llvm.org/D82548?vs=274496=274685#toc Repository: rG LLVM Github

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

lh123 added a comment. In D82548#2124546 , @MaskRay wrote: > Hi, your git commit contains extra Phabricator tags. You can drop > `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git > commit with the following script: > > arcfilter

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

lh123 updated this revision to Diff 274496. lh123 added a comment. Add the missing `operator!=`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82548/new/ https://reviews.llvm.org/D82548 Files: clang/include/clang/Sema/Sema.h

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

lh123 updated this revision to Diff 274491. lh123 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82548/new/ https://reviews.llvm.org/D82548 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/ParseDecl.cpp

[PATCH] D82714: [clangd] Remove redundant `findRefs` calls. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG84ced55d9b7b: [clangd] Remove redundant `findRefs` calls. NFC. (authored by lh123). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82714/new/

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

lh123 updated this revision to Diff 273942. lh123 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82548/new/ https://reviews.llvm.org/D82548 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/ParseDecl.cpp

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

lh123 updated this revision to Diff 273925. lh123 edited the summary of this revision. lh123 added a comment. Rebase to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82548/new/ https://reviews.llvm.org/D82548 Files:

[PATCH] D82714: [clangd] Remove redundant `findRefs` calls. NFC.

lh123 created this revision. lh123 added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. lh123 updated this revision to Diff 273928. lh123 added a comment. Rebase to head. Remove

[PATCH] D82714: [clangd] Remove redundant `findRefs` calls. NFC.

lh123 updated this revision to Diff 273928. lh123 added a comment. Rebase to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82714/new/ https://reviews.llvm.org/D82714 Files: clang-tools-extra/clangd/XRefs.cpp Index:

[PATCH] D82535: [CodeComplete] Add code completion for using alias.

lh123 updated this revision to Diff 273631. lh123 added a comment. Rebase to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82535/new/ https://reviews.llvm.org/D82535 Files: clang/lib/Sema/SemaCodeComplete.cpp

[PATCH] D82548: [CodeComplete] add code completion for `delete` and `default` specifier.

lh123 created this revision. lh123 added a reviewer: kadircet. Herald added a project: clang. Herald added a subscriber: cfe-commits. lh123 added a parent revision: D82535: [CodeComplete] Add code completion for using alias.. add code completion for `delete` and `default` specifier.

[PATCH] D82535: [CodeComplete] Add code completion for using alias.

lh123 updated this revision to Diff 273321. lh123 marked 3 inline comments as done. lh123 added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82535/new/ https://reviews.llvm.org/D82535 Files:

[PATCH] D82535: [CodeComplete] Add code completion for using alias.

lh123 updated this revision to Diff 273287. lh123 added a comment. format code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82535/new/ https://reviews.llvm.org/D82535 Files: clang/lib/Sema/SemaCodeComplete.cpp

[PATCH] D82535: [CodeComplete] Add code completion for using alias.

lh123 created this revision. lh123 added a reviewer: kadircet. Herald added a project: clang. Herald added a subscriber: cfe-commits. lh123 added a parent revision: D82373: [CodeComplete] Tweak code completion for `typename`.. Add code completion for using alias. Repository: rG LLVM Github

[PATCH] D82373: [CodeComplete] Tweak code completion for `typename`.

lh123 updated this revision to Diff 273074. lh123 retitled this revision from "[CodeComplete] Tweak code completion for `typename` and `using`." to "[CodeComplete] Tweak code completion for `typename`.". lh123 added a comment. Address comment. I will add `using $alias$ = $type$;` in a separate

[PATCH] D82373: [CodeComplete] Tweak code completion for `typename` and `using`.

lh123 marked an inline comment as done. lh123 added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:2058 Builder.AddChunk(CodeCompletionString::CK_HorizontalSpace); - Builder.AddPlaceholderChunk("qualifier"); - Builder.AddTextChunk("::");

[PATCH] D82373: [CodeComplete] Tweak code completion for `typename` and `using`.

lh123 marked an inline comment as done. lh123 added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:2058 Builder.AddChunk(CodeCompletionString::CK_HorizontalSpace); - Builder.AddPlaceholderChunk("qualifier"); - Builder.AddTextChunk("::");

[PATCH] D82373: [CodeComplete] Tweak code completion for `typename`

lh123 added a comment. If this patch looks good, please land it for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82373/new/ https://reviews.llvm.org/D82373 ___ cfe-commits mailing list

[PATCH] D82373: [CodeComplete] Tweak code completion for `typename`

lh123 updated this revision to Diff 272994. lh123 edited the summary of this revision. lh123 added a comment. address comment. Also tweak code completion behavior for `using`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82373/new/

[PATCH] D82373: [CodeComplete] Tweak code completion for `typename`

lh123 created this revision. lh123 added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, usaxena95, ilya-biryukov. Herald added a project: clang. lh123 retitled this revision from "[CodeComplete] Tweak code completion for "typename" to "[CodeComplete] Tweak code completion

[PATCH] D72623: [clangd] Rearrange type, returntype and parameters in hover card

lh123 added a comment. I think the character "" should be avoided, as it may not display properly in some environments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72623/new/ https://reviews.llvm.org/D72623

[PATCH] D72498: [clangd] Print underlying type for decltypes in hover

lh123 added a comment. In D72498#1816339 , @sammccall wrote: > In D72498#1816244 , @ilya-biryukov > wrote: > > > In D72498#1815500 , @lh123 wrote: > > > > > - hover over

[PATCH] D72500: [clangd] Show hower info for expressions

lh123 added a comment. In D72500#1813975 , @sammccall wrote: > I think we should avoid triggering for literals. Maybe some exceptions, but a > hover saying that 0 is an int with value 0 seems silly. Yes, hovering over `IntegerLiteral/FloatingLiteral`

[PATCH] D72498: [clangd] Print underlying type for decltypes in hover

lh123 added a comment. In D72498#1813902 , @ilya-biryukov wrote: > Could it be the case that we want to show the canonical types (i.e. without > all syntax sugar)? > Maybe we want both the normal type and the canonical type? +1,I think it would be

[PATCH] D72498: [clangd] Print underlying type for decltypes in hover

lh123 added a comment. > what do you think about unwrapping decltype only when it's a return value > (optional: of a function whose leading return type is auto) to narrowly catch > this idiom? I think it's worth fixing in the declarations too. int (int a, int b); template auto

[PATCH] D72498: [clangd] Print underlying type for decltypes in hover

lh123 added a comment. In D72498#1814008 , @sammccall wrote: > I think i'm also comfortable with marking the linked bug as wontfix. The previous example is just minimal repo. template auto sum(T1 , T2 ) ->decltype(t1 + t2)) { return

[PATCH] D71172: [clang][Tooling] Fix potential UB in ExpandResponseFilesCompilationDatabase

lh123 updated this revision to Diff 232771. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71172/new/ https://reviews.llvm.org/D71172 Files: clang/lib/Tooling/ExpandResponseFilesCompilationDatabase.cpp Index:

[PATCH] D71172: [clang][Tooling] Fix potential UB in ExpandResponseFilesCompilationDatabase

lh123 updated this revision to Diff 232770. lh123 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71172/new/ https://reviews.llvm.org/D71172 Files: clang/lib/Tooling/ExpandResponseFilesCompilationDatabase.cpp

[PATCH] D71172: [clang][Tooling] Fix potential UB in ExpandResponseFilesCompilationDatabase

lh123 added a comment. @sammccall Could you commit this, I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71172/new/ https://reviews.llvm.org/D71172 ___ cfe-commits mailing

[PATCH] D71172: [clang][Tooling] Fix potential UB in ExpandResponseFilesCompilationDatabase

lh123 created this revision. lh123 added reviewers: kadircet, sammccall, hokein. Herald added subscribers: cfe-commits, usaxena95, ilya-biryukov. Herald added a project: clang. `vector::assign` will cause UB at here. fixes: https://github.com/clangd/clangd/issues/223 Repository: rG LLVM

[PATCH] D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json

lh123 added a comment. In D70222#1763553 , @kadircet wrote: > Thanks a lot for working on this patch, LGTM! > > again please make sure the changes are clang-formatted. I'm sure the code has been formatted. > Do you have commit access? I don't have

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231510. lh123 marked an inline comment as done. lh123 added a comment. fix typo: "Could not convert UTF16 To UTF8" -> "Could not convert UTF16 to UTF8" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 marked 3 inline comments as done. lh123 added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:1069 + return llvm::createStringError( + std::make_error_code(std::errc::illegal_byte_sequence), + "Could not convert UTF16 To UTF8");

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 marked an inline comment as done. lh123 added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:1069 + return llvm::createStringError( + std::make_error_code(std::errc::illegal_byte_sequence), + "Could not convert UTF16 To UTF8");

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231395. lh123 marked an inline comment as done. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files:

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 231393. lh123 marked 5 inline comments as done. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files:

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231390. lh123 marked 6 inline comments as done. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files:

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231384. lh123 added a comment. fixes no matching constructor for initialization of `llvm::StringError`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files:

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231381. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: llvm/include/llvm/Support/CommandLine.h

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231377. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: llvm/include/llvm/Support/CommandLine.h

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231361. lh123 added a comment. Sorry, upload the wrong patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: llvm/include/llvm/Support/CommandLine.h

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231359. Herald added a subscriber: mgorny. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: clang/include/clang/Tooling/CompilationDatabase.h

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 231357. lh123 marked 6 inline comments as done. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files:

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231353. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: llvm/include/llvm/Support/CommandLine.h

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231349. lh123 marked 3 inline comments as done. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files:

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 marked 3 inline comments as done. lh123 added inline comments. Comment at: llvm/include/llvm/Support/CommandLine.h:47 +class FileSystem; +IntrusiveRefCntPtr getRealFileSystem(); + kadircet wrote: > now that we are also pulling the the function, I think it

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231242. lh123 marked an inline comment as done. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files:

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 231235. lh123 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang/include/clang/Tooling/CompilationDatabase.h

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231234. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: llvm/include/llvm/Support/CommandLine.h

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 231217. lh123 set the repository for this revision to rG LLVM Github Monorepo. lh123 added a comment. rebase to D70769 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231215. lh123 added a comment. address comments and delete unused code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: clang/tools/driver/driver.cpp lld/COFF/DriverUtils.cpp

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231213. lh123 added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: clang/tools/driver/driver.cpp lld/COFF/DriverUtils.cpp lld/ELF/DriverUtils.cpp

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 added a comment. In D70769#1761394 , @jhenderson wrote: > Are there any instances where we DON'T want to get the real file system? If > not, could the `*llvm::vfs::getRealFileSystem()` call be put inside > `cl::ExpandResponseFiles`? This patch

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 created this revision. lh123 added a reviewer: kadircet. Herald added subscribers: llvm-commits, cfe-commits, seiya, rupprecht, MaskRay, jakehehrlich, aheejin, hiraditya, arichardson, sbc100, emaste. Herald added a reviewer: espindola. Herald added a reviewer: alexshap. Herald added a

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 marked an inline comment as done. lh123 added inline comments. Comment at: clang/lib/Tooling/ExpandResponseFilesCompilationDatabase.cpp:167 +for (auto : Cmds) { + expandResponseFiles(Cmd, Tokenizer); +} lh123 wrote: > lh123 wrote: > >

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 marked an inline comment as done. lh123 added inline comments. Comment at: clang/lib/Tooling/ExpandResponseFilesCompilationDatabase.cpp:167 +for (auto : Cmds) { + expandResponseFiles(Cmd, Tokenizer); +} lh123 wrote: > kadircet wrote: > > so

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 231051. lh123 added a comment. address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang/include/clang/Tooling/CompilationDatabase.h clang/lib/Tooling/CMakeLists.txt

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 marked an inline comment as done. lh123 added inline comments. Comment at: clang/lib/Tooling/CompilationDatabase.cpp:402 llvm::sys::path::append(DatabasePath, "compile_flags.txt"); -return FixedCompilationDatabase::loadFromFile(DatabasePath, ErrorMessage); +

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 marked an inline comment as done. lh123 added inline comments. Comment at: clang/lib/Tooling/ExpandResponseFilesCompilationDatabase.cpp:167 +for (auto : Cmds) { + expandResponseFiles(Cmd, Tokenizer); +} kadircet wrote: > so it looks like we

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 230756. lh123 added a comment. Expand response files before `inferMissingCompileCommands` and `inferTargetAndDriverMode` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files:

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 230752. lh123 added a comment. Herald added a subscriber: mgorny. Address comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang/include/clang/Tooling/CompilationDatabase.h

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 230060. lh123 added a comment. fixes some bug and add more test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang/include/clang/Tooling/CompilationDatabase.h

  1   2   >