[clang] [clang] Processing real directories added as virtual ones (PR #91645)

ivanmurashko wrote: Hi @sam-mccall, The patch touches some fairly old code that hasn't been modified for a long time. You are one of the few people who worked on it recently, around two years ago. I would appreciate any comments and a review of the suggested patch.

[clang] [Modules] Enable MS Windows test for implicit-module-no-timestamp.cpp (PR #91738)

https://github.com/ivanmurashko closed https://github.com/llvm/llvm-project/pull/91738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Modules] Enable MS Windows test for implicit-module-no-timestamp.cpp (PR #91738)

ivanmurashko wrote: @dmpolukhin , the test was successfully passed on MS Windows. There is the corresponding record from the build log ``` _bk;t=1715380522596PASS: Clang :: Modules/implicit-module-no-timestamp.cpp (12618 of 20053) ``` https://github.com/llvm/llvm-project/pull/91738

[clang] [Modules] Enable MS Windows test for implicit-module-no-timestamp.cpp (PR #91738)

https://github.com/ivanmurashko edited https://github.com/llvm/llvm-project/pull/91738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Modules] Enable MS Windows test for implicit-module-no-timestamp.cpp (PR #91738)

https://github.com/ivanmurashko created https://github.com/llvm/llvm-project/pull/91738 There is a followup commit for #90319. The windows test was disabled at that commit but it should pass on MS Windows and it would be good to have it enabled. >From 6e5bd93173a8515749115f45c993ddf472437c79

[clang] [clang] Processing real directories added as virtual ones (PR #91645)

https://github.com/ivanmurashko edited https://github.com/llvm/llvm-project/pull/91645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Processing real directories added as virtual ones (PR #91645)

https://github.com/ivanmurashko edited https://github.com/llvm/llvm-project/pull/91645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Processing real directories added as virtual ones (PR #91645)

https://github.com/ivanmurashko edited https://github.com/llvm/llvm-project/pull/91645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Processing real directories added as virtual ones (PR #91645)

https://github.com/ivanmurashko created https://github.com/llvm/llvm-project/pull/91645 The `FileManager` might create a virtual directory that can be used later as a search path. If the added record is a real directory that is present on a disk, we might encounter a false cache miss and add

[clang] [Modules] Process include files changes with -fmodules-validate-input-files-content and -fno-pch-timestamp options (PR #90319)

https://github.com/ivanmurashko closed https://github.com/llvm/llvm-project/pull/90319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Modules] Process include files changes with -fmodules-validate-input-files-content and -fno-pch-timestamp options (PR #90319)

https://github.com/ivanmurashko updated https://github.com/llvm/llvm-project/pull/90319 >From 71796a80e15b6700fec23fbec70635aae455b188 Mon Sep 17 00:00:00 2001 From: Ivan Murashko Date: Fri, 26 Apr 2024 22:45:26 +0100 Subject: [PATCH] [Modules] Process include files changes with

[clang] [Modules] Process include files changes with -fmodules-validate-input-files-content and -fno-pch-timestamp options (PR #90319)

@@ -0,0 +1,34 @@ +// UNSUPPORTED: system-windows +// RUN: rm -rf %t +// RUN: split-file %s %t +// RUN: cd %t +// +// RUN: cp a1.h a.h +// RUN: %clang -fmodules -fmodules-validate-input-files-content -Xclang -fno-pch-timestamp -fimplicit-modules -fmodule-map-file=module.modulemap

[clang] [Modules] Process include files changes with -fmodules-validate-input-files-content and -fno-pch-timestamp options (PR #90319)

https://github.com/ivanmurashko updated https://github.com/llvm/llvm-project/pull/90319 >From 3c36295b5f0f1e011e11d57c5ec4e685cb917cab Mon Sep 17 00:00:00 2001 From: Ivan Murashko Date: Fri, 26 Apr 2024 22:45:26 +0100 Subject: [PATCH] [Modules] Process include files changes with

[clang] [Modules] Process include files changes with -fmodules-validate-input-files-content and -fno-pch-timestamp options (PR #90319)

@@ -0,0 +1,34 @@ +// UNSUPPORTED: system-windows +// RUN: rm -rf %t +// RUN: split-file %s %t +// RUN: cd %t +// +// RUN: cp a1.h a.h +// RUN: %clang -fmodules -fmodules-validate-input-files-content -Xclang -fno-pch-timestamp -fimplicit-modules -fmodule-map-file=module.modulemap

[clang] [Modules] Process include files changes with -fmodules-validate-input-files-content and -fno-pch-timestamp options (PR #90319)

https://github.com/ivanmurashko updated https://github.com/llvm/llvm-project/pull/90319 >From 48a019ead18d3e8aeb5d10d0301c2567ef1c5cd7 Mon Sep 17 00:00:00 2001 From: Ivan Murashko Date: Fri, 26 Apr 2024 22:45:26 +0100 Subject: [PATCH] [Modules] Process include files changes with

[clang] [Modules] Process include files changes with -fmodules-validate-input-files-content and -fno-pch-timestamp options (PR #90319)

https://github.com/ivanmurashko updated https://github.com/llvm/llvm-project/pull/90319 >From 2a07774317c288ebe6cc55fed2fafd2989ba853e Mon Sep 17 00:00:00 2001 From: Ivan Murashko Date: Fri, 26 Apr 2024 22:45:26 +0100 Subject: [PATCH] [Modules] Process include files changes with

[clang] [Modules] Process include files changes with -fmodules-validate-input-files-content and -fno-pch-timestamp options (PR #90319)

https://github.com/ivanmurashko edited https://github.com/llvm/llvm-project/pull/90319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Modules] Process include files changes with -fmodules-validate-input-files-content and -fno-pch-timestamp options (PR #90319)

https://github.com/ivanmurashko updated https://github.com/llvm/llvm-project/pull/90319 >From e8e9502f117d5559c4da225b0e24fe6db9c27751 Mon Sep 17 00:00:00 2001 From: Ivan Murashko Date: Fri, 26 Apr 2024 22:45:26 +0100 Subject: [PATCH] [Modules] Process include files changes with

[clang] [Modules] Process include files changes with -fmodules-validate-input-files-content and -fno-pch-timestamp options (PR #90319)

https://github.com/ivanmurashko updated https://github.com/llvm/llvm-project/pull/90319 >From ee4153f6b828c40a56b5b35d6e42cd193a1b5c31 Mon Sep 17 00:00:00 2001 From: Ivan Murashko Date: Fri, 26 Apr 2024 22:45:26 +0100 Subject: [PATCH] [Modules] Process include files changes with

[clang] [Modules] Process include files changes with -fmodules-validate-input-files-content and -fno-pch-timestamp options (PR #90319)

https://github.com/ivanmurashko updated https://github.com/llvm/llvm-project/pull/90319 >From ee4153f6b828c40a56b5b35d6e42cd193a1b5c31 Mon Sep 17 00:00:00 2001 From: Ivan Murashko Date: Fri, 26 Apr 2024 22:45:26 +0100 Subject: [PATCH] [Modules] Process include files changes with

[clang] [Modules] Process include files changes with -fmodules-validate-input-files-content and -fno-pch-timestamp options (PR #90319)

https://github.com/ivanmurashko created https://github.com/llvm/llvm-project/pull/90319 There were two diffs that introduced some options useful when you build modules externally and cannot rely on file modification time as the key for detecting input file changes: -

[clang-tools-extra] d03a7f1 - [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free

Author: Ivan Murashko Date: 2023-09-04T18:53:49+01:00 New Revision: d03a7f15f019beb1896872ba9321cfed5f16a05f URL: https://github.com/llvm/llvm-project/commit/d03a7f15f019beb1896872ba9321cfed5f16a05f DIFF: https://github.com/llvm/llvm-project/commit/d03a7f15f019beb1896872ba9321cfed5f16a05f.diff

[clang-tools-extra] 56ac9d4 - [clangd] Add library for clangd main function

Author: Ivan Murashko Date: 2023-07-11T21:48:50+01:00 New Revision: 56ac9d46a7c1468d587ccec02a781e52d0bb298a URL: https://github.com/llvm/llvm-project/commit/56ac9d46a7c1468d587ccec02a781e52d0bb298a DIFF: https://github.com/llvm/llvm-project/commit/56ac9d46a7c1468d587ccec02a781e52d0bb298a.diff

[clang] a8ad413 - [RFC][clangd] Move preamble index out of document open critical path

Author: Kugan Vivekanandarajah Date: 2023-06-12T12:56:41+01:00 New Revision: a8ad413f0d18c07a4adaa0d547e0096874d809c5 URL: https://github.com/llvm/llvm-project/commit/a8ad413f0d18c07a4adaa0d547e0096874d809c5 DIFF:

[clang] f8536fb - [clang][HeaderSearch] Fix implicit module when using header maps

Author: Ivan Murashko Date: 2023-05-28T11:49:51+01:00 New Revision: f8536fb11e3d71d009c9002b5aa2ef32983ac7dc URL: https://github.com/llvm/llvm-project/commit/f8536fb11e3d71d009c9002b5aa2ef32983ac7dc DIFF: https://github.com/llvm/llvm-project/commit/f8536fb11e3d71d009c9002b5aa2ef32983ac7dc.diff

[clang] d604c57 - [NFC] Use find_last_of when seraching for code in getRawCommentForDeclNoCacheImpl

Author: Kugan Vivekanandarajah Date: 2023-02-21T16:25:46Z New Revision: d604c57164ecdb3084c8d00f9575158fddc30f81 URL: https://github.com/llvm/llvm-project/commit/d604c57164ecdb3084c8d00f9575158fddc30f81 DIFF:

[clang] 557e32e - [clang] SIGSEGV fix at clang::ASTContext::getRawCommentForDeclNoCacheImpl

Author: Ivan Murashko Date: 2022-08-12T00:05:59+01:00 New Revision: 557e32e002edd2a5a9e728d96b098bffa33e34d0 URL: https://github.com/llvm/llvm-project/commit/557e32e002edd2a5a9e728d96b098bffa33e34d0 DIFF: https://github.com/llvm/llvm-project/commit/557e32e002edd2a5a9e728d96b098bffa33e34d0.diff

[clang] e78c80e - [clang] SourceManager: fix at SourceManager::getFileIDLoaded for the case of invalid SLockEntry

Author: Ivan Murashko Date: 2022-08-10T16:37:42+01:00 New Revision: e78c80e3d622d455934102dabd765a60ac917739 URL: https://github.com/llvm/llvm-project/commit/e78c80e3d622d455934102dabd765a60ac917739 DIFF: https://github.com/llvm/llvm-project/commit/e78c80e3d622d455934102dabd765a60ac917739.diff

[clang-tools-extra] 987f9cb - [clang-tidy] Add proper emplace checks to modernize-use-emplace

Author: Nicolas van Kempen Date: 2022-06-03T00:14:57+01:00 New Revision: 987f9cb6b9708ff16980c4f8c3f8ba4674463fb5 URL: https://github.com/llvm/llvm-project/commit/987f9cb6b9708ff16980c4f8c3f8ba4674463fb5 DIFF:

[clang] 2deebc0 - [RFC] Add and sort decl to maintain order instead of inserting in order

Author: Kugan Vivekanandarajah Date: 2022-05-03T17:06:22+01:00 New Revision: 2deebc0048f92811dc92c7e41d357683b84febf7 URL: https://github.com/llvm/llvm-project/commit/2deebc0048f92811dc92c7e41d357683b84febf7 DIFF:

[clang] f6112f4 - [docs] PCH usage documentation update

Author: Ivan Murashko Date: 2022-05-03T08:26:13+01:00 New Revision: f6112f490cfeed05b42ae33cc994292000aee0da URL: https://github.com/llvm/llvm-project/commit/f6112f490cfeed05b42ae33cc994292000aee0da DIFF: https://github.com/llvm/llvm-project/commit/f6112f490cfeed05b42ae33cc994292000aee0da.diff

[clang] 71d7c8d - [clangd] Crash in __memcmp_avx2_movbe

Author: Ivan Murashko Date: 2022-02-10T09:40:44-08:00 New Revision: 71d7c8d870db3b2da1fe1b3f54be77163c55dcd2 URL: https://github.com/llvm/llvm-project/commit/71d7c8d870db3b2da1fe1b3f54be77163c55dcd2 DIFF: https://github.com/llvm/llvm-project/commit/71d7c8d870db3b2da1fe1b3f54be77163c55dcd2.diff