[PATCH] D93490: [clang-format] PR48539 ReflowComments breaks Qt translation comments

JVApen added a comment. In D93490#2467733 , @MyDeveloperDay wrote: > remove // = and // ~ cases Wouldn't it make sense to explicitly document that `//=` and `//~` are not put in here as reflowing them results in wrong results? CHANGES SINCE LAST

[PATCH] D93490: [clang-format] PR48539 ReflowComments breaks Qt translation comments

JVApen added a comment. In D93490#2463068 , @MyDeveloperDay wrote: > Maybe @JVApen can help as they logged > https://bugs.llvm.org/show_bug.cgi?id=48539 > > I'm not a Qt developer so I can't really comment beyond fixing what was in > the bug rpeort We

[PATCH] D60996: [clang-format] Fix bug in reflow of block comments containing CR/LF

JVApen added subscribers: Rakete, djasper, klimek, mlekena, MyDeveloperDay, owenpan, sammccall, shenhan. JVApen added a comment. Any chance we can still get this in LLVM 11? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60996/new/

[PATCH] D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment

JVApen added a comment. I'm missing some documentation to understand the corner cases. How does this check behave with suppressed warnings for checks which ain't currently checked. (Using -no-... on a code base or suppressing the warnings via the pragmas) https://reviews.llvm.org/D41326

[PATCH] D40937: [clang-tidy] Infinite loop checker

JVApen added a comment. How does this check deal with atomic members? struct A { std:: atomic a; void f() const { while (a); } }; https://reviews.llvm.org/D40937 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33537: [clang-tidy] Exception Escape Checker

JVApen added a comment. Looking at the documentation and the examples, it is unclear to me what the behavior of checking is when you call a function without throw/noexcept if you can't see the implementation. (Other cpp file) https://reviews.llvm.org/D33537

[PATCH] D39799: [Tooling] Use FixedCompilationDatabase when `compile_flags.txt` is found.

JVApen added a comment. How does this new file know if it should handle it's flags as it does in clang.exe or clang-cl.exe? Repository: rL LLVM https://reviews.llvm.org/D39799 ___ cfe-commits mailing list cfe-commits@lists.llvm.org