Re: [PATCH] D6833: Clang-format: Braces Indent Style Whitesmith

2019-06-12 Thread JVApen via cfe-commits
Hello Tim, I am no longer working on this. I've spent my time convincing my colleagues that clang-format is useful enough to change our braces, with success. I remember also being stuck on the enumerations. Good luck! On Wed, Jun 12, 2019, 04:16 Tim Wojtulewicz via Phabricator <

Re: [PATCH] D18300: [clang-tidy] ProTypeMemberInitCheck - check that field decls do not have in-class initializer

2016-03-20 Thread JVApen via cfe-commits
JVApen accepted this revision. JVApen added a comment. This revision is now accepted and ready to land. I'm not sure if I'm the right person to do reviews, as I'm mostly a user of the tool and have not yet done any developments or bug fixes to it. However, from what I know from coding, this

Re: [PATCH] D14484: Formatting constructor initializer lists by putting them always on different lines

2015-11-08 Thread JVApen via cfe-commits
JVApen added a comment. In http://reviews.llvm.org/D14484#284767, @djasper wrote: > Please read > > http://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options > > Does your style option qualify? - Is it used by a project of significant size? Yes, we use the

[PATCH] D14484: Formatting constructor initializer lists by putting them always on different lines

2015-11-08 Thread JVApen via cfe-commits
JVApen created this revision. JVApen added a reviewer: djasper. JVApen added a subscriber: cfe-commits. JVApen set the repository for this revision to rL LLVM. Herald added a subscriber: klimek. Hi all, I've been playing around with the clang for a while now and really enjoy it. Unfortunately