[PATCH] D68055: Add -fgnuc-version= to control __GNUC__ and other GCC macros

2019-10-09 Thread Jacob Lifshay via Phabricator via cfe-commits 
programmerjake requested changes to this revision.
programmerjake added inline comments.
This revision now requires changes to proceed.



Comment at: clang/lib/Frontend/InitPreprocessor.cpp:589
+if (LangOpts.CPlusPlus) {
+  Builder.defineMacro("__GNUG__", Twine(GNUCMinor));
+  Builder.defineMacro("__GXX_WEAK__");

Pretty sure that should be `GNUCMajor`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68055/new/

https://reviews.llvm.org/D68055



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D68055: Add -fgnuc-version= to control __GNUC__ and other GCC macros

2019-10-02 Thread Jacob Lifshay via Phabricator via cfe-commits 
programmerjake added a comment.

The `__GNUG__` macro is defined to be 4 rather than matching `__GNUC__`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68055/new/

https://reviews.llvm.org/D68055



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D68055: Add -fgnuc-version= to control __GNUC__ and other GCC macros

2019-09-30 Thread Jacob Lifshay via Phabricator via cfe-commits 
programmerjake added a comment.

Shouldn't `__GNUG__` match `__GNUC__`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68055/new/

https://reviews.llvm.org/D68055



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits