Re: [PATCH] D52660: [CMake][Fuchsia] Use libc++ ABIv2 for Fuchsia toolchain

2018-09-28 Thread Jake Ehrlich via cfe-commits
We have no such desire. I think we're fine being the test subjects for ABIv2 however. On Fri, Sep 28, 2018, 4:51 PM Louis Dionne via Phabricator < revi...@reviews.llvm.org> wrote: > ldionne added a comment. > > In https://reviews.llvm.org/D52660#1249709, @kristina wrote: > > > LGTM. Can we

r319269 - Reland "Fix vtable not receiving hidden visibility when using push(visibility)"

2017-11-29 Thread Jake Ehrlich via cfe-commits
Author: jakehehrlich Date: Tue Nov 28 16:54:20 2017 New Revision: 319269 URL: http://llvm.org/viewvc/llvm-project?rev=319269=rev Log: Reland "Fix vtable not receiving hidden visibility when using push(visibility)" I had to reland this change in order to make the test work on windows This change

r317960 - Add CLANG_DEFAULT_OBJCOPY to allow Clang to use llvm-objcopy for dwarf fission

2017-11-10 Thread Jake Ehrlich via cfe-commits
Author: jakehehrlich Date: Fri Nov 10 17:15:41 2017 New Revision: 317960 URL: http://llvm.org/viewvc/llvm-project?rev=317960=rev Log: Add CLANG_DEFAULT_OBJCOPY to allow Clang to use llvm-objcopy for dwarf fission llvm-objcopy is getting to where it can be used in non-trivial ways (such as for