[PATCH] D73629: [analyzer] vfork checker: allow execve after vfork

2020-02-17 Thread Jan Včelák via Phabricator via cfe-commits
janvcelak updated this revision to Diff 245025. janvcelak added a comment. I'm attaching updated version with tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73629/new/ https://reviews.llvm.org/D73629 Files: clang/lib/StaticAnalyzer/Checkers/VforkChecker.cpp clang/test/Analysi

[PATCH] D73629: [analyzer] vfork checker: allow execve after vfork

2020-02-11 Thread Jan Včelák via Phabricator via cfe-commits
janvcelak added a comment. Herald added a subscriber: martong. Please, can the reviewers respond to my comments? I would like to know if this needs additional revision or if it can be accepted as is. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73629/new/ https://reviews.llvm.org/D736

[PATCH] D73629: [analyzer] vfork checker: allow execve after vfork

2020-01-30 Thread Jan Včelák via Phabricator via cfe-commits
janvcelak added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/VforkChecker.cpp:109 "execvpe", + "execve", nullptr xazax.hun wrote: > Well, this is not the case now, but I wonder if it would also make sense to > sort this list

[PATCH] D73629: [analyzer] vfork checker: allow execve after vfork

2020-01-30 Thread Jan Včelák via Phabricator via cfe-commits
janvcelak added a comment. In D73629#1847750 , @NoQ wrote: > We should add a test for this (cf. `test/Analysis/vfork.c`). There is already a test to check if the whitelist works by making sure that call to `execl` doesn't generate the warning. I think t

[PATCH] D73629: [analyzer] vfork checker: allow execve after vfork

2020-01-29 Thread Jan Včelák via Phabricator via cfe-commits
janvcelak updated this revision to Diff 241245. janvcelak added a comment. Sorry. I missed that step in contribution guidelines. I'm attaching updated version with larger context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73629/new/ https://reviews.llvm.org/D73629 Files: clang/l

[PATCH] D73629: [analyzer] vfork checker: allow execve after vfork

2020-01-29 Thread Jan Včelák via Phabricator via cfe-commits
janvcelak created this revision. janvcelak added a reviewer: dcoughlin. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. `execve` is missing in the list of functions th