janosimas marked 2 inline comments as done.
janosimas added a comment.
Yes, I'll need help landing it
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D49864/new/
https://reviews.llvm.org/D49864
___
janosimas updated this revision to Diff 400854.
janosimas added a comment.
I changed the wording and added an example as suggested.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D49864/new/
https://reviews.llvm.org/D49864
Files:
janosimas updated this revision to Diff 398314.
janosimas added a comment.
Herald added a subscriber: carlosgalvezp.
I added a comment in the docs noting this is a breaking change.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D49864/new/
janosimas added a comment.
ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D49864/new/
https://reviews.llvm.org/D49864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
janosimas added a comment.
That makes sense.
Should I add it somewhere? Or do I need to talk to someone?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D49864/new/
https://reviews.llvm.org/D49864
___
janosimas updated this revision to Diff 347622.
janosimas added a comment.
Fix test issue.
Use correct clang-tidy flag
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D49864/new/
https://reviews.llvm.org/D49864
Files:
janosimas updated this revision to Diff 347489.
janosimas added a comment.
Fix a mistake in my last patch.
I added a `--` in a command that should not have it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D49864/new/
janosimas added a comment.
> Hmm, I'm not certain what's going on there. When I try to upload a patch for
> the review, Phab lets me upload it (but I didn't try to submit the changes).
> At what stage are you getting the failure? Is it when uploading the patch
> itself, or at some other point?
janosimas updated this revision to Diff 347459.
janosimas added a comment.
I manage to upload it, copy-pasting the content to the text box. I have no idea
why it is not working with the upload.
Updates from the last change
- Modified the tests to match the input
- Addend file context
janosimas added a comment.
I found the issue with my diff and I was able to get the expected file.
I'm still having issues uploading the file, this is the message I get in the
browser console:
POST https://reviews.llvm.org/differential/revision/update/49864/ 500
Repository:
rG LLVM
janosimas added a comment.
Hi, sorry for taking so long for such a small change.
I did the changes and generated a diff with the requested context.
It's a huge file with a lot more diff than my changes, is that right?
When I try to upload it, I'm getting `Unhandled Exception ("Exception")`, no
janosimas updated this revision to Diff 298865.
janosimas added a comment.
Here a diff with the rebased code
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D49864/new/
https://reviews.llvm.org/D49864
Files:
janosimas added a comment.
I also noticed there is a `clang-format-diff` that also has the `-p` option, it
would be nice to update it for consistency.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D49864/new/
https://reviews.llvm.org/D49864
janosimas updated this revision to Diff 234005.
janosimas added a comment.
Herald added a subscriber: mgehre.
Herald added a project: clang.
I reviewed the code over the discussion with the `--` option,
I also changed the `-p` optin to `-strip` to avoid confusion with the
`clang-tidy` option.
janosimas added a comment.
I like a lot of this syntax you proposed, makes a lot more sense to me.
The script will be shorter and the doc will be "auto updated" with the
clang-tidy doc.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49864
janosimas added a comment.
I was thinking about the usage of `--` and `-extra-arg`, don't they do the same
thing?
To be honest, for me, the current behavior of `--` doesn't make much sense. If
there is a use case for `-extra-arg-before` and `-extra-arg`, they are much
more clearer in intent.
janosimas added inline comments.
Comment at: clang-tidy/tool/clang-tidy-diff.py:123-130
if args.fix:
command.append('-fix')
if args.checks != '':
command.append('-checks=' + quote + args.checks + quote)
if args.quiet:
command.append('-quiet')
if
janosimas requested review of this revision.
janosimas added inline comments.
Comment at: clang-tidy/tool/clang-tidy-diff.py:123-130
if args.fix:
command.append('-fix')
if args.checks != '':
command.append('-checks=' + quote + args.checks + quote)
if
janosimas added a comment.
To use in a git pre-commit I wanted to use the flags:
-warnings-as-errors=*
-header-filter=.*
I wanted that the script returned an error value for my selected checks, even
if they are just warnings.
Repository:
rCTE Clang Tools Extra
janosimas created this revision.
janosimas added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
When the argument -- is passed to clang-tidy-diff.py it should pass the
following arguments to clang-tidy.
It does that but also includes -- as an argument,
there should be a +1
20 matches
Mail list logo
