[PATCH] D75768: Add a warning for builtin_return_address/frame_address with > 0 argument

2020-03-09 Thread Jeremy Stenglein via Phabricator via cfe-commits
jstenglein added a comment. In D75768#1912519 , @erichkeane wrote: > I did a bit of research and I don't think i know of anything better than > 'most' here, and noone else had an opinion at the end of last week so I'll > take that silence as consent.

[PATCH] D75768: Add a warning for builtin_return_address/frame_address with > 0 argument

2020-03-06 Thread Jeremy Stenglein via Phabricator via cfe-commits
jstenglein added a comment. In D75768#1910339 , @erichkeane wrote: > In D75768#1910324 , @jstenglein > wrote: > > > In D75768#1910303 , @erichkeane > > wrote: > > > > >

[PATCH] D75768: Add a warning for builtin_return_address/frame_address with > 0 argument

2020-03-06 Thread Jeremy Stenglein via Phabricator via cfe-commits
jstenglein added a comment. In D75768#1910303 , @erichkeane wrote: > Any reason to not put this in -Wall like GCC? I'm not terribly knowledgeable > about the intended guidance for adding to Wmost, so if you can clarify this > decision I'd be grateful.

[PATCH] D75768: Add a warning for builtin_return_address/frame_address with > 0 argument

2020-03-06 Thread Jeremy Stenglein via Phabricator via cfe-commits
jstenglein created this revision. jstenglein added reviewers: efriedma, lebedev.ri, rsmith, erichkeane. jstenglein added a project: clang. Herald added a subscriber: cfe-commits. Clang is missing a warning for __builtin_return_address/__builtin_frame_address called with > 0 argument. Gcc