[PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8de9f2b558a0: Move SubtargetFeature.h from MC to TargetParser (authored by jobnoorman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

jobnoorman updated this revision to Diff 534456. jobnoorman added a comment. Herald added a subscriber: wangpc. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150549/new/ https://reviews.llvm.org/D150549 Files:

[PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

jobnoorman added a comment. In D150549#4380786 , @MaskRay wrote: > If we are certain this will not be reverted and cause churn, making the > header switch in one single patch looks fine to me... Great. I'm not sure if we can ever be a 100% certain it

[PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

jobnoorman added a comment. Friendly ping. Any thoughts on my previous comment @MaskRay? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150549/new/ https://reviews.llvm.org/D150549 ___ cfe-commits

[PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

jobnoorman added a comment. In D150549#4351614 , @MaskRay wrote: > In D150549#4349531 , @jobnoorman > wrote: > >> In D150549#4347056 , @MaskRay >> wrote: >> >>> This

[PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

jobnoorman added a comment. In D150549#4347056 , @MaskRay wrote: > This seems fine, but please consider making `MC/SubtargetFeature.h` a > forwarding header temporarily. To be clear: do you want me to check-in this forwarding header or should I just

[PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

jobnoorman created this revision. jobnoorman added reviewers: chandlerc, grosbach, andreadb, MaskRay, craig.topper. Herald added subscribers: bviyer, asb, luke, Moerafaat, zero9178, bzcheeseman, pmatos, sdasgup3, wenzhicui, wrengr, ormris, foad, cota, teijeong, frasercrmck, rdzhabarov,

[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

jobnoorman added a comment. In D148767#4316464 , @chapuni wrote: > In D148767#4315667 , @jobnoorman > wrote: > >> Hi, this seems to have broken my bolt+debug+shared build. I don't think >> there are build bots

[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

jobnoorman added a comment. Hi, this seems to have broken my bolt+debug+shared build. I don't think there are build bots for this configuration but you can reproduce it like this: cmake -G Ninja -DCMAKE_BUILD_TYPE="Debug" \ -DLLVM_ENABLE_PROJECTS="clang;lld;bolt" \