[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej added a comment. @sbc100 @sunfish I believe I've addressed all your feedback so far. Anything else you'd like me to do before we call this ready? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153293/new/ https://reviews.llvm.org/D153293

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej updated this revision to Diff 533375. dicej added a comment. remove config.py changes per review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153293/new/ https://reviews.llvm.org/D153293 Files: clang/docs/ReleaseNotes.rst

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej added a comment. In D153293#4437877 , @sbc100 wrote: > In D153293#4437644 , @dicej wrote: > >> In D153293#4436629 , @sbc100 wrote: >> >>> I'm happy to merge it, but

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej updated this revision to Diff 533243. dicej added a comment. update release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153293/new/ https://reviews.llvm.org/D153293 Files: clang/docs/ReleaseNotes.rst

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej added a comment. In D153293#4436629 , @sbc100 wrote: > I'm happy to merge it, but perhaps we should get @sunfish to lg too. > > Also, should we remove the `-experimental-pic` linker flag, or are you OK > with that warning from the linker? If

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej added a comment. In D153293#4437583 , @sunfish wrote: > This patch appears to be just the release notes and the test; is the actual > driver change missing? Sorry -- this is the first time I've used `arc`, and I apparently messed up. I meant to

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej added a comment. @sbc100 Thanks for the "lgtm". What's the next step to get this merged? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153293/new/ https://reviews.llvm.org/D153293 ___ cfe-commits

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej updated this revision to Diff 532705. dicej added a comment. generalize Wasm tests and release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153293/new/ https://reviews.llvm.org/D153293 Files: clang/docs/ReleaseNotes.rst

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej added a comment. Thanks for the review. I'll post an update shortly. Comment at: clang/docs/ReleaseNotes.rst:705 +- The `wasm32-wasi` target now supports `Emscripten-style shared libraries +

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej created this revision. Herald added subscribers: pmatos, asb, delcypher, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added a project: All. dicej requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay, aheejin. Herald added projects: