[PATCH] D78129: Add Marvell ThunderX3T110 support

2020-05-13 Thread Joel Jones via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG382d3a85e2a9: [AARch64] Add Marvell ThunderX3T110 support (authored by wxz2020, committed by joelkevinjones). Changed prior to commit: https://reviews.llvm.org/D78129?vs=263582=263896#toc Repository:

[PATCH] D78129: Add Marvell ThunderX3T110 support

2020-05-06 Thread Joel Jones via Phabricator via cfe-commits
joelkevinjones added a comment. I don't think it makes sense to combine two unrelated things SVE and PA support into a combined thing. Since we already have UnsupportedFeatures in every sub-target .td file, I think it would be better to instead have: def PAUnsupported : AArch64Unsupported {

[PATCH] D78129: Add Marvell ThunderX3T110 support

2020-05-06 Thread Joel Jones via Phabricator via cfe-commits
joelkevinjones added a comment. > It is okay'ish to set `CompleteModel = 0` if you're not interested in > describing all instructions. The other way is of course to add the missing > instruction to the model. We are trying to describe all instructions. The issue Wei is having is that the

[PATCH] D78129: Add Marvell ThunderX3T110 support

2020-05-06 Thread Joel Jones via Phabricator via cfe-commits
joelkevinjones added a comment. In email Wei asked for help about he following error message: error message from tblgen Included from /home/wei/project/tx3/llvm-project/llvm/lib/Target/AArch64/AArch64.td:439: