johnrusso added inline comments.

================
Comment at: lib/Driver/ToolChains/RISCV.h:42
+      : GnuTool("RISCV::Linker",
+                TC.getTriple().isArch64Bit() ? "riscv64-ld" : "riscv32-ld",
+                TC) {}
----------------
I wonder if we should construct the linker name based on the default triple 
value?  "riscv64-unknown-elf-ld" or "riscv32-unknown-elf-ld" as this is likely 
what is in the user's PATH if they have installed the gnu tools.  The linker 
name could be modified in ConstructJob if the triple is different from the 
default.


https://reviews.llvm.org/D39963



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to