justice_adams added a comment.
@dyung I don't have commit access, would you mind commiting this for me ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94829/new/
https://reviews.llvm.org/D94829
___
justice_adams created this revision.
justice_adams added reviewers: nigelp-xmos, aaron.ballman.
justice_adams added a project: clang.
justice_adams requested review of this revision.
This test will fail with any toolchains that don't default to C11.
Adding this switch to the clang invocation in
justice_adams added a comment.
@thakis thanks for the review. I don't have commit access, would you mind
committing this for me?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57592/new/
https://reviews.llvm.org/D57592
justice_adams added a comment.
@stella.stamenova These are the changes from our previous discussion regarding
the usage of %T
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57592/new/
https://reviews.llvm.org/D57592
justice_adams added a comment.
@stella.stamenova @thakis Thanks for the feedback all, I will go ahead and make
this change to the way I'm representing directories, open a new diff for
review, and add you as a reviewer.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
justice_adams added a comment.
@stella.stamenova thanks for the review. I don't have commit access, would you
mind committing this for me?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D50563/new/
https://reviews.llvm.org/D50563
___
justice_adams added a comment.
@stella.stamenova Thanks for the input, what about now?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D50563/new/
https://reviews.llvm.org/D50563
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
justice_adams updated this revision to Diff 183197.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D50563/new/
https://reviews.llvm.org/D50563
Files:
test/Frontend/output-failures.c
test/Frontend/stats-file.c
Index: test/Frontend/stats-file.c
justice_adams added a comment.
@stella.stamenova Good suggestion, I think you are right. I have updated the
diff to use %t, that way any end-users can control the way their lit test work
in a read-only mount by simply altering the test_exec_root in their config
CHANGES SINCE LAST ACTION
justice_adams updated this revision to Diff 183170.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D50563/new/
https://reviews.llvm.org/D50563
Files:
test/Frontend/output-failures.c
test/Frontend/stats-file.c
Index: test/Frontend/stats-file.c
justice_adams added a comment.
@cfe-commits Re-pinging this group to request a review on this patch
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D50563/new/
https://reviews.llvm.org/D50563
___
cfe-commits mailing list
justice_adams added a comment.
@cfe-commits ping requesting a review on this patch
https://reviews.llvm.org/D50563
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
justice_adams created this revision.
justice_adams added a project: clang.
When mounting LLVM source into a windows container in read-only mode, certain
tests fail. Ideally, we want all these tests to pass so that developers can
mount the same source folder into multiple (windows) containers
13 matches
Mail list logo
