[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

karepker added a comment. In D56424#1370908 , @hokein wrote: > In D56424#1370461 , @karepker wrote: > > > Rebasing against master. > > > > Not sure if re-arc diffing this is necessary, but I hope it doesn't hurt. >

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

karepker updated this revision to Diff 183437. karepker added a comment. Rebasing against master. Not sure if re-arc diffing this is necessary, but I hope it doesn't hurt. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56424/new/

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

karepker added a comment. In D56424#1360318 , @MyDeveloperDay wrote: > In D56424#1359227 , @karepker wrote: > > > In D56424#1357484 , > > @MyDeveloperDay wrote: > > > > >

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

karepker added a comment. In D56424#1357484 , @MyDeveloperDay wrote: > In D56424#1357481 , @lebedev.ri > wrote: > > > In D56424#1357471 , > > @MyDeveloperDay wrote: > > >

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

karepker added a comment. Hi all, ping on this patch. I've addressed all comments to the best of my ability. Is there anything outstanding that needs to be changed? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56424/new/

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

karepker marked 2 inline comments as done and an inline comment as not done. karepker added inline comments. Comment at: clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.cpp:27 +static bool isGoogletestTestMacro(StringRef MacroName) { + static const llvm::StringSet<>

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

karepker updated this revision to Diff 180727. karepker marked 4 inline comments as done. karepker added a comment. Update release notes documentation to match check documentation more. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56424/new/

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

karepker added inline comments. Comment at: docs/ReleaseNotes.rst:161 + + Checks that Googletest test and test case names do not contain an underscore, + which is prohibited by the Googletest FAQ. Eugene.Zelenko wrote: > Please synchronize with first statement

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

karepker added a comment. In D56424#1349336 , @lebedev.ri wrote: > In D56424#1349218 , @karepker wrote: > > > Clean up comments in test file. > > > For reference, what documentation sources did you read when

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

karepker updated this revision to Diff 180716. karepker marked 15 inline comments as done. karepker added a comment. Address comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56424/new/ https://reviews.llvm.org/D56424 Files:

[PATCH] D56424: Add check for underscores in googletest names.

karepker updated this revision to Diff 180603. karepker added a comment. Clean up comments in test file. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56424/new/ https://reviews.llvm.org/D56424 Files:

[PATCH] D56424: Add check for underscores in googletest names.

karepker created this revision. karepker added a reviewer: hokein. Herald added a subscriber: mgorny. Adds a clang-tidy warning for underscores in googletest names. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D56424 Files: