khazem added a comment.
Thanks, Gábor! Please do commit this (it's currently Thanksgiving week in the
US).
https://reviews.llvm.org/D26328
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
khazem created this revision.
khazem added reviewers: spyffe, dergachev.a.
khazem added subscribers: cfe-commits, phosek, seanklein.
This patch adds support for importing AST nodes of type UnresolvedLookupExpr,
as well as a test for such an import. This resolves an issue where attempting
to
khazem added a comment.
Thanks very much for this patch! It certainly fixes the infinite recursion
issue on our codebase. It LGTM, but I'd like to add a test case before landing
it.
https://reviews.llvm.org/D26753
___
cfe-commits mailing list
khazem marked 4 inline comments as done.
khazem added a comment.
Devin, based on Artem's review of the other checker that I have posted [1] I am
wondering about merging both this SpinLockChecker and the MutexChecker into
PthreadLockChecker. Do you think it is still worth landing this
khazem added a comment.
Thanks for the detailed review Artem!
I think that it's sensible to try merging this with PthreadLockChecker. In
fact, I could also try merging the SpinLockChecker [1] that I've posted for
review with PthreadLockChecker also, since they all implement similar
khazem updated this revision to Diff 77277.
khazem added a comment.
If a double-lock or double-release is detected, path notes are now emitted on
the _first_ lock or release event. Also updated the tests to check for these
notes.
https://reviews.llvm.org/D26340
Files:
khazem updated this revision to Diff 77275.
khazem added a comment.
The strings for Spin{Unl,L}ockFuncName and LockErrorCategory are now
initialized when constructing a SpinLockChecker object rather than being static
globals, in order to avoid adverse effects on startup time.
Also, the
khazem added a comment.
Good to meet you too, thanks for the useful comments and pointers to helpful
examples! I'm going to update the diff twice: the first one to address your
first two comments, and the second one to address your last two.
https://reviews.llvm.org/D26340
khazem added a comment.
Thank you Sean! I've asked Petr Hosek to commit this change.
https://reviews.llvm.org/D26328
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
khazem updated this revision to Diff 77005.
khazem added a comment.
Minor edit, the list of libraries in CMakeLists.txt is now in alphabetical
order.
https://reviews.llvm.org/D26340
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
khazem updated this revision to Diff 76272.
khazem added a comment.
(added more context)
https://reviews.llvm.org/D26105
Files:
include/clang/AST/Stmt.h
lib/AST/ASTImporter.cpp
Index: lib/AST/ASTImporter.cpp
===
---
khazem created this revision.
khazem added reviewers: a.sidorin, xazax.hun, doug.gregor, rsmith.
khazem added subscribers: phosek, cfe-commits, smklein.
The CaseStmt constructor now takes an optional SubStmt argument to initialize
its SubExprs field with. This fixes an issue where the
khazem added a comment.
This diff is a continuation of https://reviews.llvm.org/D14326, which was
accepted for inclusion but has not been merged in for the past couple of months.
I added a small patch so that it rebases cleanly onto master:
--- a/lib/AST/ASTImporter.cpp
+++
khazem created this revision.
khazem added reviewers: spyffe, sepavloff.
khazem added subscribers: phosek, khazem, NoQ, xazax.hun, cfe-commits.
This patch implements some expression-related AST node import (patch #2).
- Some code cleanup
- Add tests not present in
khazem added a comment.
I'm updating this patch so that it rebases cleanly onto master, as this patch
hasn't been updated for a couple of months...
At the time of writing, one of Clang's tests is failing with this patch.
Specifically, there is a segfault at line 130 of
15 matches
Mail list logo
