[PATCH] D68896: PR43080: Do not build context-sensitive expressions during name classification.

[Kian Moniri via Phabricator via cfe-commits]

kianm added a comment.

In D68896#1861048 , @rsmith wrote:

> In D68896#1861040 , @rsmith wrote:
>
> > In D68896#1778193 , @kianm wrote:
> >
> > > Hi, I am still seeing problems with this assertion. Could we please get a 
> > > fix? I've posted the reduced test case and reproducible command on this 
> > > Phabricator patch.
> >
> >
> > Are you still seeing problems?
>
>
> For future Phabricator visitors, this was fixed in rG2e48be09b 
> .


No I am not seeing problems, they were fixed in rG2e48be09b 
. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68896/new/

https://reviews.llvm.org/D68896



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D68896: PR43080: Do not build context-sensitive expressions during name classification.

[Kian Moniri via Phabricator via cfe-commits]

kianm added a comment.

Hi, I am still seeing problems with this assertion. Could we please get a fix? 
I've posted the reduced test case and reproducible command on this Phabricator 
patch.

Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68896/new/

https://reviews.llvm.org/D68896



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D68896: PR43080: Do not build context-sensitive expressions during name classification.

[Kian Moniri via Phabricator via cfe-commits]

kianm added a comment.

Hi,

There is a problem with this commit because it asserts after errors have been 
recognized. I have attached a reduced test case. The assertion looks to occur 
here:

  clang: 
/home/kianm/llvm/dev/llvm-project/clang/lib/Parse/ParseExprCXX.cpp:585: 
clang::ExprResult clang::Parser::tryParseCXXIdExpression(clang::CXXScopeSpec &, 
bool, clang::Token &): Assertion `SS.isEmpty() && "undeclared non-type 
annotation should be unqualified"' failed.

The reproducible command is:

  clang -cc1 -x c++ reduced.c

F10590725: reduced.c 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68896/new/

https://reviews.llvm.org/D68896



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits