[PATCH] D69088: [Lex] #pragma clang transform

2020-05-06 Thread Kit Barton via Phabricator via cfe-commits
kbarton added a comment. @Meinersbur I missed the RFC and discussion on the cfe-dev mailing list. Could you post a link here so that it's included in the history? I don't have any opposition to this, and it seems that you have addressed all the comments from reviewers. So, unless there was

[PATCH] D50989: Remove Darwin support from POWER backend.

2019-06-03 Thread Kit Barton via Phabricator via cfe-commits
kbarton closed this revision. kbarton added a comment. Herald added a subscriber: jsji. This landed in https://reviews.llvm.org/rL340770. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50989/new/ https://reviews.llvm.org/D50989 ___

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

2019-05-15 Thread Kit Barton via Phabricator via cfe-commits
kbarton added a comment. I think this looks straightforward, as long as people agree to have a separate CreateConstrained* version of these functions. I'm not qualified to weigh in on that as I don't know Clang at all and can't comment about the tradeoffs (although I think they have been well

[PATCH] D50989: Remove Darwin support from POWER backend.

2018-08-20 Thread Kit Barton via Phabricator via cfe-commits
kbarton created this revision. kbarton added reviewers: power-llvm-team, hfinkel, echristo, rsmith. Herald added a subscriber: nemanjai. This is the clang counterpart to the patch posted in https://reviews.llvm.org/D50988. The patch removes Darwin support from the POWER backend. A similar

[PATCH] D27251: [PPC] some bugs mainly about sign problem fixed in altivec.h

2017-01-04 Thread Kit Barton via Phabricator via cfe-commits
kbarton added a comment. Sorry, I don't have time to go through the entire patch in detail right now. But I did notice several places where the lines are too long, which need to get fixed. Comment at: lib/Headers/altivec.h:14206

[PATCH] D27251: [PPC] some bugs mainly about sign problem fixed in altivec.h

2016-12-01 Thread Kit Barton via Phabricator via cfe-commits
kbarton requested changes to this revision. kbarton added a comment. This revision now requires changes to proceed. Please make explicit the signed for the parameters to the functions you are changing and remove unnecessary casts. I marked the first few that I found, but stopped marking them