[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

krasimir added a comment. In D154184#4509744 , @rymiel wrote: > Shouldn't that regression already be handled by D155358 > ? Ah, I missed that. That fixes it. Thank you! Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

krasimir added a comment. It looks like this causes a regression in the following example: % cat test.cc struct A { std::unique_ptr operator()(const B& b) const; }; % clang-format -style=google test.cc # should be the same as the input struct A { std::unique_ptr

[PATCH] D151145: Add disabled unittest reproducing TextProto formatting issue.

krasimir added a comment. Thank you! That's a bug in the raw string format manager. This code effectively first looks for a matching top-level style, and if that's not found, then it tries to derive one via the RawFormat's BasedOnStyle:

[PATCH] D150563: clang-format: [JS] terminate import sorting on `export type X = Y`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe1f34b735b66: clang-format: [JS] terminate import sorting on `export type X = Y` (authored by jankuehle, committed by krasimir). Repository: rG

[PATCH] D150563: clang-format: [JS] terminate import sorting on `export type X = Y`

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150563/new/ https://reviews.llvm.org/D150563

[PATCH] D150116: clang-format: [JS] support import/export type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG34b422bafbd9: clang-format: [JS] support import/export type (authored by jankuehle, committed by krasimir). Repository: rG LLVM Github Monorepo

[PATCH] D150116: clang-format: [JS] support import/export type

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Looks good! Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150116/new/ https://reviews.llvm.org/D150116

[PATCH] D141547: Fix format for `case` in .proto files

This revision was automatically updated to reflect the committed changes. Closed by commit rGcaf393da1823: Fix format for `case` in .proto files (authored by fowles, committed by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141547/new/

[PATCH] D141547: Fix format for `case` in .proto files

krasimir accepted this revision. krasimir added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141547/new/ https://reviews.llvm.org/D141547 ___ cfe-commits mailing list

[PATCH] D141547: Fix format for `case` in .proto files

krasimir added inline comments. Comment at: clang/test/Format/case.proto:15 +repeated int32 fizz = 1; +} could you please turn this into an unit test here instead > https://github.com/llvm/llvm-project/blob/main/clang/unittests/Format/FormatTestProto.cpp.

[PATCH] D140956: [clang-format] Add an option for breaking after C++11 attributes

krasimir added a comment. > Was it actually a regression or did this patch also fix a bug? It seems that > the continuation indent before the & in your example is inconsistent with > other similar function declarations. Nice catch! I fully agree with you! Thank you for looking into this, sorry

[PATCH] D140956: [clang-format] Add an option for breaking after C++11 attributes

krasimir added a comment. It looks like this regressed the following example: % cat test.cc # formatted with older clang-format a () { return 1; } % clang-format --version clang-format version 16.0.0 (https://github.com/llvm/llvm-project.git

[PATCH] D140211: [clang][dataflow] Remove unused lambda capture

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf86cdb485361: [clang][dataflow] Remove unused lambda capture (authored by merrymeerkat, committed by krasimir). Repository: rG LLVM Github

[PATCH] D140211: [clang][dataflow] Remove unused lambda capture

krasimir added a comment. I'll submit this for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140211/new/ https://reviews.llvm.org/D140211 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D129771: [clang-format] distinguish multiplication after brace-init from pointer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8dd2ef213085: [clang-format] distinguish multiplication after brace-init from pointer (authored by krasimir). Repository: rG LLVM Github Monorepo

[PATCH] D129771: [clang-format] distinguish multiplication after brace-init from pointer

krasimir marked an inline comment as done. krasimir added a comment. In D129771#3653830 , @jackhong12 wrote: > I think we can also add new test cases in > `clang/unittests/Format/TokenAnnotatorTest.cpp`. > > Tokens = annotate("int i = int{42} *

[PATCH] D129771: [clang-format] distinguish multiplication after brace-init from pointer

krasimir updated this revision to Diff 444921. krasimir added a comment. - address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129771/new/ https://reviews.llvm.org/D129771 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct

krasimir added a comment. Proposed https://reviews.llvm.org/D129771. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127873/new/ https://reviews.llvm.org/D127873 ___ cfe-commits mailing list

[PATCH] D129771: [clang-format] distinguish multiplication after brace-init from pointer

krasimir created this revision. Herald added a project: All. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After https://github.com/llvm/llvm-project/commit/b646f0955574c6ad4c156c9db522e46f597cfda9, the added regression test

[PATCH] D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct

krasimir added a comment. In D127873#3651364 , @jackhong12 wrote: > I think we cannot identify `struct`, `union`, `class` or `enum` by the right > bracket. Clang-format will split the input into multiple lines. For instance > `struct Tmp {} *tmp;`

[PATCH] D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct

krasimir added a comment. Appears that this regressed examples like this: // before int i = int{16} * 1024; // after int i = int{16}* 1024; Naively it looks like in all added examples, the token preceding the matching `{` of the `}` is one of `struct`, `class`, `union`, `enum`, or a

[PATCH] D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline.

krasimir added a comment. We found another regression with this in wrongly indenting/not putting on its own line ObjC `@interface`: % ./clang-format --version clang-format version 15.0.0 (https://github.com/llvm/llvm-project.git 50cd52d9357224cce66a9e00c9a0417c658a5655) % cat

[PATCH] D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline.

krasimir added a comment. It looks like this regressed the following example by adding an unwanted level of indentation to the `#elif B` branch: % ./clang-format --version clang-format version 15.0.0 (https://github.com/llvm/llvm-project.git 50cd52d9357224cce66a9e00c9a0417c658a5655) %

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

krasimir added a comment. In D121370#3488401 , @kwk wrote: > @krasimir could you please test this patch on your side? @kwk thank you! the new version of the patch looks good! I didn't know before about the issue you found with the `/* a comment before

[PATCH] D124513: [clang-format] add a regression test for include sorting

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbe656df18721: [clang-format] add a regression test for include sorting (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D124513: [clang-format] add a regression test for include sorting

krasimir updated this revision to Diff 425456. krasimir added a comment. - update with just the last commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124513/new/ https://reviews.llvm.org/D124513 Files:

[PATCH] D124513: [clang-format] add a regression test for include sorting

krasimir created this revision. Herald added a project: All. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds a regression test from the comments on https://reviews.llvm.org/D121370. Repository: rG LLVM Github

[PATCH] D124512: Revert "[clang-format] SortIncludes should support "@import" lines in Objective-C"

krasimir created this revision. Herald added a project: All. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commit d46fa023caa2db5a9f1e21dd038bcb626261d958

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

krasimir added a comment. > @krasimir I'm on sick leave and will have a look as soon as I'm back. Can it > wait that long? I'm planning to revert this temporarily and add a regression test, you can proceed with this work without time pressure. We aim to release a new clang-format version

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

krasimir added a comment. It appears that this regressed include sorting in the following case, where the contents of `test.h` show the expected include order and the `clang-format` behavior before this patch: % cat test.h #include #include "util/bar.h" #include "util/foo/foo.h"

[PATCH] D121584: [clang-format] Correctly recognize arrays in template parameter list.

krasimir added a comment. > It appears that this regressed some ObjC patterns: @curdeius any progress on this? If not, could we revert this for now? Internally we've got enough of these regressing ObjC patterns that we can't release clang-format with this. Repository: rG LLVM Github

[PATCH] D122230: [clang-format] don't break up #-style comment sections

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb35e0ecbe0a: [clang-format] dont break up #-style comment sections (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D122230: [clang-format] don't break up #-style comment sections

krasimir created this revision. Herald added a project: All. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Follow-up from https://github.com/llvm/llvm-project/commit/36d13d3f8adb3d1a6bae71370afa23d11a94dc78. Restore the old

[PATCH] D121451: [clang-format] Add space to comments starting with '#'.

krasimir added a comment. > So I'd rather keep the old behaviour for # in Proto but not in C-like > languages. Is that acceptable? Sounds good. I'll work on a patch doing that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121451/new/

[PATCH] D121584: [clang-format] Correctly recognize arrays in template parameter list.

krasimir added a comment. It appears that this regressed some ObjC patterns: % cat test.m # before: good void f() { // BOOL a = [b.c count] > 1; int b = a; } % clang-format -style=google test.m # after: bad, statements joined on the same line void f() { // BOOL a

[PATCH] D121451: [clang-format] Add space to comments starting with '#'.

krasimir added a comment. This is getting more fun: the reason why `///` isn't broken up is because the first character `/` after the comment leader `//` is considered punctuation per isPunctuation's CHAR_RAWDEL, which includes all these `{}[]#<>%:;?*+-/^&|~!=,"'`: -

[PATCH] D121451: [clang-format] Add space to comments starting with '#'.

krasimir added a comment. In D121451#3395611 , @curdeius wrote: > In D121451#3395578 , @krasimir > wrote: > >> This appears to have broken a relatively common pattern we see in text proto >> comments where

[PATCH] D121451: [clang-format] Add space to comments starting with '#'.

krasimir added a comment. This appears to have broken a relatively common pattern we see in text proto comments where sections use a style like this: # Big section name

[PATCH] D121758: [clang-format] Add support for formatting Verilog code

krasimir added inline comments. Comment at: clang/lib/Format/Format.cpp:3451 +for (auto Suffix : Lang.second) + if (FileName.endswith(Suffix)) +return Lang.first; I kinda prefer the old style of handling this I find it simpler to read. I'd be

[PATCH] D118869: [clang-format] Non-latin comment prefix whitespace

krasimir added a comment. Thank you! Turns out the original source wasn't using an ascii space for the comment indentation but a unicode [c2 a0] no-break space: 2f 2f c2 a0 43 6f 6d 6d 65 6e 74 0a 69 6e 74 20 |//..Comment.int | IMO we shouldn't aim to handle non-ascii spaces for

[PATCH] D118869: [clang-format] Non-latin comment prefix whitespace

krasimir added a comment. Herald added a project: All. It appears that this caused a regression by adding an additional space of indentation to line comments in some cases: % cat test.cc # (before) // Comment int i; % clang-format -style=google test.cc //  Comment int i; @ksyx

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

krasimir added a comment. > I just pushed 6cb42cd6669785f3b611106e1b6b38bbe65733a9 > to > hopefully fix this. Thank you Craig! That fixed it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

krasimir added a comment. @achieveartificialintelligence thank you for looking into this, sorry for the late reply! It looks like the latest version addresses @nikic's IR reproducer with `-mtriple=riscv32`. There seems to be an error trying this out with `-mtriple=riscv64`: % cat test.ll

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

krasimir added a comment. In D93298#3342480 , @achieveartificialintelligence wrote: > In D93298#3342452 , @krasimir wrote: > >> @achieveartificialintelligence any progress with the problematic IR? Have >> you

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

krasimir added a comment. @achieveartificialintelligence any progress with the problematic IR? Have you been able to reproduce using nikic's reduced example? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298

[PATCH] D120324: [clang-format] Avoid parsing "requires" as a keyword in non-C++-like languages.

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120324/new/ https://reviews.llvm.org/D120324

[PATCH] D120315: [clang-format] Fix preprocessor nesting after commit 529aa4b011c4ae808d658022ef643c44dd9b2c9c

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9592ae49b8c: [clang-format] Fix preprocessor nesting after commit… (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D120315: [clang-format] Fix preprocessor nesting after commit 529aa4b011c4ae808d658022ef643c44dd9b2c9c

krasimir updated this revision to Diff 410521. krasimir marked an inline comment as done. krasimir added a comment. - address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120315/new/ https://reviews.llvm.org/D120315 Files:

[PATCH] D113319: [clang-format] Improve require and concept handling

krasimir added a comment. It appears that this causes a regression by adding a space in-between pointer dereferences `*p` -> `* p` in some cases, e.g. formatting this with llvm style: // before void f() { while (p < a && *p == 'a') p++; } // after void f() { while (p < a

[PATCH] D113319: [clang-format] Improve require and concept handling

krasimir added a comment. It appears that after this patch clang-format started breaking up `requires` in javascript, e.g.: // before function f() { var requires = {}; } // after function f() { var requires = {}; } Could we restrict the requires logic only to

[PATCH] D120315: [clang-format] fix preprocessor nesting after https://github.com/llvm/llvm-project/commit/529aa4b011c4ae808d658022ef643c44dd9b2c9c

krasimir created this revision. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In https://github.com/llvm/llvm-project/commit/529aa4b011c4ae808d658022ef643c44dd9b2c9c by setting the identifier info to nullptr, we started to

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

krasimir added a comment. It appears that this is causing an assertion segfault in a `rustc` test over at our experimental rust + llvm@head bot: https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/8430#167e6de5-2dd5-41c3-87d7-b6e3f3908371/262-706 The test is

[PATCH] D116001: [clang-format] add regression tests for braced lists

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3a3fcd6a23ad: [clang-format] add regression tests for braced lists (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D116000: Revert "[clang-format] Adjust braced list detection"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd96bf6ea4618: Revert [clang-format] Adjust braced list detection (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D116001: [clang-format] add regression tests for braced lists

krasimir created this revision. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on https://reviews.llvm.org/D116000. Added test cases from the comments on https://reviews.llvm.org/D114583. Repository: rG LLVM Github

[PATCH] D116000: Revert "[clang-format] Adjust braced list detection"

krasimir created this revision. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It appears that this regressed the formatting of initializer lists in some cases, see comments on https://reviews.llvm.org/D114583. I'll follow-up by

[PATCH] D114583: [clang-format] Adjust braced list detection

krasimir added a comment. It appears that this regressed the formatting of initializer lists in some cases: # Before % cat ~/test.cc class A { A() : a{} {} A(int b) : b(b) {} A(int a, int b) : a(a), bs{{bs...}} { f(); } int a, b; }; # After %

[PATCH] D110432: [clang-format][docs] mark new clang-format configuration options based on which version they would GA

krasimir added a comment. I like this. Consider only displaying the major version (e.g., `clang-format 14` instead of `clang-format 14.0.0`). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110432/new/ https://reviews.llvm.org/D110432

[PATCH] D108810: [clang-format] [PR51640] - New AfterEnum brace wrapping changes have cause C# behaviour to change

krasimir accepted this revision. krasimir added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/TokenAnnotator.cpp:3803 + if (Line.startsWith(Keywords.kw_interface) && + Style.BraceWrapping.AfterClass) +return

[PATCH] D108692: [clang-format] Support TypeScript override keyword

This revision was automatically updated to reflect the committed changes. Closed by commit rGe708808f875f: [clang-format] Support TypeScript override keyword (authored by jankuehle, committed by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108692: [clang-format] Support TypeScript override keyword

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! Let me know if you would like me to commit this for you in case you don't have commit rights for LLVM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108620: [clang-format] keep TypeScript argument decorators in line

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbefb9dc3694e: [clang-format] keep TypeScript argument decorators in line (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D108620: [clang-format] keep TypeScript argument decorators in line

krasimir marked an inline comment as done. krasimir added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:497 if (Style.Language == FormatStyle::LK_JavaScript && - Previous.is(tok::r_paren) && Previous.is(TT_JavaAnnotation)) { +

[PATCH] D108620: [clang-format] keep TypeScript argument decorators in line

krasimir updated this revision to Diff 368311. krasimir added a comment. - consider also functions and setters Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108620/new/ https://reviews.llvm.org/D108620 Files:

[PATCH] D108620: [clang-format] keep TypeScript argument decorators in line

krasimir created this revision. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As a follow-up from https://reviews.llvm.org/D108538, ensure TypeScript argument decorators are kept in line with the argument. Repository: rG

[PATCH] D108538: [clang-format] break after the closing paren of a TypeScript decoration

This revision was automatically updated to reflect the committed changes. Closed by commit rGf3671a688db2: [clang-format] break after the closing paren of a TypeScript decoration (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108538: [clang-format] break after the closing paren of a TypeScript decoration

krasimir created this revision. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes up a case that regressed from https://reviews.llvm.org/D105964: in specific contexts, clang-format stopped breaking after the `)` in

[PATCH] D107950: [clang-format] improve distinction of K function definitions vs attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rG45934922fa88: [clang-format] improve distinction of KR function definitions vs attributes (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107950: [clang-format] improve distinction of K function definitions vs attributes

krasimir created this revision. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After https://github.com/llvm/llvm-project/commit/9da70ab3d43c79116f80fc06aa7cf517374ce42c we saw a few regressions around trailing attribute

[PATCH] D107907: [clang-format] handle trailing comments in function definition detection

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0fc27ef19670: [clang-format] handle trailing comments in function definition detection (authored by krasimir). Repository: rG LLVM Github

[PATCH] D107907: [clang-format] handle trailing comments in function definition detection

krasimir updated this revision to Diff 365918. krasimir added a comment. - apply reviewer suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107907/new/ https://reviews.llvm.org/D107907 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D107907: [clang-format] handle trailing comments in function definition detection

krasimir created this revision. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A follow-up to https://github.com/llvm/llvm-project/commit/f6bc614546e169bb1b17a29c422ebace038e6c62 where we handle the case where the semicolon is

[PATCH] D107269: [clan-format] detect function definitions more conservatively

This revision was automatically updated to reflect the committed changes. Closed by commit rGf6bc614546e1: [clan-format] detect function definitions more conservatively (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107269: [clan-format] detect function definitions more conservatively

krasimir added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2485-2486 if (Next->Next && Next->Next->is(tok::identifier) && - !(Next->MatchingParen->Next && Next->MatchingParen->Next->is(tok::semi))) + (!Next->MatchingParen->Next || +

[PATCH] D107269: [clan-format] detect function definitions more conservatively

krasimir updated this revision to Diff 363669. krasimir added a comment. - apply review suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107269/new/ https://reviews.llvm.org/D107269 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D107267: [clang-format] don't break between function and function name in JS

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f4f2783056f: [clang-format] dont break between function and function name in JS (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107269: [clan-format] detect function definitions more conservatively

krasimir created this revision. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://reviews.llvm.org/D105964 updated the detection of function definitions. It had the unfortunate effect to start marking object definitions with

[PATCH] D107267: [clang-format] don't break between function and function name in JS

krasimir created this revision. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The commit https://github.com/llvm/llvm-project/commit/58494c856a15f5b0e886c7baf5d505ac6c05dfe5 updated detection of function declaration names. It

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

krasimir added a comment. In D103615#2858433 , @bmahjour wrote: > In D103615#2852430 , @krasimir > wrote: > >> I'm unfamiliar with the altivec API. What's a reasonable source code update >> that preserves the

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

krasimir added a comment. I'm unfamiliar with the altivec API. What's a reasonable source code update that preserves the current default behavior `-altivec-src-compat=mixed` under `-altivec-src-compat=xl`, i.e., under `-altivec-src-compat=xl` how would we compare vector bool or vector pixel to

[PATCH] D104209: [clang-format] distinguish function type casts after 21c18d5a04316891110cecc2bf37ce51533decba

This revision was automatically updated to reflect the committed changes. Closed by commit rG54bd95cd96bc: [clang-format] distinguish function type casts after… (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104209/new/

[PATCH] D104209: [clang-format] distinguish function type casts after 21c18d5a04316891110cecc2bf37ce51533decba

krasimir created this revision. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://github.com/llvm/llvm-project/commit/21c18d5a04316891110cecc2bf37ce51533decba improved the detection of multiplication in function all argument

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

krasimir added a comment. Do we have some widely used code style that requires the new option (https://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options)? I agree with @MyDeveloperDay that this option as-is is likely not addressing all the cases where we would

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

krasimir added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:135 return; +} } nit: use spaces for indentation, no tabs (Phabricator makes it look this line starts with a tab character) Repository: rG LLVM Github Monorepo

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

krasimir accepted this revision. krasimir added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1563 + if (Current.Previous) { +bool isIdentifier = +Style.Language == FormatStyle::LK_JavaScript nit:

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fa56f7ededc: [clang-format] Prevent extraneous space insertion in bitshift operators (authored by penagos, committed by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

krasimir added a comment. @penagos, I'll submit this for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100778/new/ https://reviews.llvm.org/D100778 ___ cfe-commits mailing list

[PATCH] D101515: clang-format: [JS] handle "off" in imports

krasimir accepted this revision. krasimir added inline comments. Comment at: clang/lib/Format/SortJavaScriptImports.cpp:257 +// references per group. +auto *Start = References.begin(); +SmallVector ReferencesSorted; please fix lint warning on line

[PATCH] D101515: clang-format: [JS] handle "off" in imports

krasimir added a comment. @h-joo , seems we had a comment race :D cheers! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101515/new/ https://reviews.llvm.org/D101515 ___ cfe-commits mailing list

[PATCH] D101515: clang-format: [JS] handle "off" in imports

krasimir added inline comments. Comment at: clang/lib/Format/SortJavaScriptImports.cpp:158 std::string ReferencesText; -bool SymbolsInOrder = true; -for (unsigned i = 0, e = Indices.size(); i != e; ++i) { - JsModuleReference Reference = References[Indices[i]];

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

krasimir added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:125 + CurrentToken->Next->getStartOfNonWhitespace().getLocWithOffset( + -1))) return false; penagos wrote: > krasimir wrote: > >

[PATCH] D101033: [clang-format] fix indent in alignChainedConditionals

This revision was automatically updated to reflect the committed changes. Closed by commit rG5987d7c59da5: [clang-format] fix indent in alignChainedConditionals (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101033/new/

[PATCH] D101033: [clang-format] fix indent in alignChainedConditionals

krasimir added a comment. I also have a limited understanding based on the original patch https://github.com/llvm/llvm-project/commit/4db94094b469b4715d08ef37f1799bf3ea7ca8ea together with examining affected test cases. I believe the intention of this section is to handle, e.g., the alignment

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

krasimir added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:125 + CurrentToken->Next->getStartOfNonWhitespace().getLocWithOffset( + -1))) return false; penagos wrote: > MyDeveloperDay wrote: > >

[PATCH] D101033: [clang-format] fix indent in alignChainedConditionals

krasimir created this revision. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang-format was indenting the lines following the `?` in the added test case by +5 instead of +4. This only happens in a very specific situation,

[PATCH] D99063: [clang-format] Fix ObjC method indent after f7f9f94b

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9abcdd9f471: [clang-format] Fix ObjC method indent after f7f9f94b (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99063/new/

[PATCH] D99063: [clang-format] Fix ObjC method indent after f7f9f94b

krasimir created this revision. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Commit https://github.com/llvm/llvm-project/commit/f7f9f94b2e2b4c714bac9036f6b73a3df42daaff changed the indent of ObjC method arguments from +4 to +2,

[PATCH] D97688: clang-format: use `pb` as a canonical raw string delimiter for google style

This revision was automatically updated to reflect the committed changes. Closed by commit rG587859d977e8: clang-format: use `pb` as a canonical raw string delimiter for google style (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97688: clang-format: use `pb` as a canonical raw string delimiter for google style

krasimir added a comment. In D97688#2610657 , @sammccall wrote: >> Also fixes a bug where the canonical delimiter was not applied for raw >> strings with empty delimiters detected via well-known enclosing functions >> that expect a text proto. > > Are

[PATCH] D98032: [clang-format] Improve clang-format-diff.py error message

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. LGTM. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98032/new/ https://reviews.llvm.org/D98032

  1   2   3   4   5   6   7   8   9   10   >