[PATCH] D158238: Implement __builtin_fmaximum/fminimum*

2023-09-15 Thread Kunwar Shaanjeet Singh Grover via Phabricator via cfe-commits
Groverkss added a comment. LGTM, the fmaximum/fminimum fallback support backends has been blocking us for a while in IREE. This patch is a welcome addition to start the support for this. I will let @fhahn accept the patch, since I'm not an expert in this part of code. Repository: rG LLVM

[PATCH] D133937: [mlir] Remove the unused source file.

2022-09-15 Thread Kunwar Shaanjeet Singh Grover via Phabricator via cfe-commits
Groverkss added a comment. Included this change in the original revision since I had to revert things because of a compilation issue with gcc8 anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133937/new/ https://reviews.llvm.org/D133937