RE: [PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

2021-12-23 Thread Lieberman, Ron via cfe-commits 
[AMD Official Use Only]

@Singh, Pushpinder is this resolved?
You were most recently working on it.

Thx

-Original Message-
From: Johannes Doerfert via Phabricator  
Sent: Wednesday, December 22, 2021 5:46 PM
To: georgakoud...@llnl.gov; jdoerf...@anl.gov; jhub...@vols.utk.edu; 
a.bat...@hotmail.com
Cc: matthew.v...@sony.com; andrew.savonic...@gmail.com; yanliang...@intel.com; 
xw111lu...@gmail.com; t...@google.com; shen...@google.com; sara.royu...@bsc.es; 
Islam, Saiyedul ; Song, Ruiling ; 
ravi.narayanasw...@intel.com; quic_soura...@quicinc.com; mlek...@skidmore.edu; 
li...@llnl.gov; li...@llnl.gov; jatin.bhat...@gmail.com; greg63...@gmail.com; 
florian_h...@apple.com; dougp...@gmail.com; deepak.eachemp...@hpe.com; 
david.gr...@arm.com; blitzrak...@gmail.com; Kumar N, Bhuvanendra 
; abidmus...@gmail.com; 
llvm-comm...@lists.llvm.org; a335p...@edu.uwaterloo.ca; Singh, Pushpinder 
; Palermo, Dan ; Lieberman, Ron 
; zhaos...@quicinc.com; jonathanchesterfi...@gmail.com; 
josemonsal...@gmail.com; chichun.c...@hpe.com; lebedev...@gmail.com; 
openmp-comm...@lists.llvm.org; reviews.llvm@jfbastien.com; 
i...@tianshilei.me; Liu, Yaxun (Sam) ; 
stefomeis...@gmail.com; zhang.guans...@gmail.com; cfe-commits@lists.llvm.org; 
balaji-sankar-naga-sai-sandeep.kos...@hpe.com; misono.tomoh...@fujitsu.com; 
sunil.shres...@hpe.com; jacob.weight...@hpe.com; Balasubrmanian, Vignesh 
; gandhi21...@gmail.com; michael.hl...@gmail.com
Subject: [PATCH] D102107: [OpenMP] Codegen aggregate for outlined function 
captures

[CAUTION: External Email]

jdoerfert accepted this revision.
jdoerfert added a comment.

Can we land this? AMD issues seems resolved.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD102107%2Fnew%2Fdata=04%7C01%7Cron.lieberman%40amd.com%7C586324e07cb7454e16da08d9c59ccb4a%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637758099586834909%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000sdata=H3ekOHEM0HLuanKZ%2FJN7enQIhkNzIROdSbWOLWRElpE%3Dreserved=0

https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD102107data=04%7C01%7Cron.lieberman%40amd.com%7C586324e07cb7454e16da08d9c59ccb4a%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637758099586834909%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000sdata=wcnXCYfGWmr4XXBO%2B7kmmTxqdBCRzQETRxPtIKL7Z80%3Dreserved=0
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

RE: [PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

2021-09-28 Thread Lieberman, Ron via cfe-commits 
[AMD Official Use Only]

Hi George,
I will do it now ...


-Original Message-
From: Giorgis Georgakoudis via Phabricator  
Sent: Tuesday, September 28, 2021 1:30 PM
To: georgakoud...@llnl.gov; jdoerf...@anl.gov; jhub...@vols.utk.edu
Cc: llvm-comm...@lists.llvm.org; a335p...@edu.uwaterloo.ca; Singh, Pushpinder 
; Palermo, Dan ; Lieberman, Ron 
; zhaos...@quicinc.com; jonathanchesterfi...@gmail.com; 
josemonsal...@gmail.com; chichun.c...@hpe.com; a.bat...@hotmail.com; 
lebedev...@gmail.com; openmp-comm...@lists.llvm.org; 
reviews.llvm@jfbastien.com; tianshilei1...@gmail.com; Liu, Yaxun (Sam) 
; stefomeis...@gmail.com; zhang.guans...@gmail.com; 
cfe-commits@lists.llvm.org; Balasubrmanian, Vignesh 
; Kumar N, Bhuvanendra 
; li...@llnl.gov; yanliang...@intel.com; 
li...@llnl.gov; abidmus...@gmail.com; sara.royu...@bsc.es; Islam, Saiyedul 
; quic_soura...@quicinc.com; deepak.eachemp...@hpe.com; 
dougp...@gmail.com; xw111lu...@gmail.com; mlek...@skidmore.edu; 
blitzrak...@gmail.com; jatin.bhat...@gmail.com; greg63...@gmail.com; 
shen...@google.com; ravi.narayanasw...@intel.com; florian_h...@apple.com; 
david.gr...@arm.com; t...@google.com; Song, Ruiling 
Subject: [PATCH] D102107: [OpenMP] Codegen aggregate for outlined function 
captures

[CAUTION: External Email]

ggeorgakoudis added a comment.

@pdhaliwal @JonChesterfield @ronlieb I updated the aggregate argument memory 
allocation to use an alloca instead of malloc'ing in SPMD mode, which should 
resolve your issue. Could someone please test the updated patch and give me 
feedback before landing?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD102107%2Fnew%2Fdata=04%7C01%7Cron.lieberman%40amd.com%7C5b92399e33684f58bb1608d982a599aa%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637684470098601893%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=1h3%2BMAYI9ectCfTJIp0JIJJjAtwMC7SEQaXypWCTNmc%3Dreserved=0

https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD102107data=04%7C01%7Cron.lieberman%40amd.com%7C5b92399e33684f58bb1608d982a599aa%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637684470098601893%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=Y3SeU%2FMG7VqBYv%2FKppem5T4wMP%2F70KeVmU0UD%2F8C1nU%3Dreserved=0
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

RE: [PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute

2021-09-27 Thread Lieberman, Ron via cfe-commits 
[AMD Official Use Only]

Yes, thank you, it was two dependent patches 
Builder 1 only saw 1st patch, failed, then 2nd patch arrived, and passed.
Builder 2 picked up both and passed

All good.

-Original Message-
From: Johannes Doerfert via Phabricator  
Sent: Monday, September 27, 2021 12:07 PM
To: jhub...@vols.utk.edu; jdoerf...@anl.gov; tianshilei1...@gmail.com
Cc: Lieberman, Ron ; stefomeis...@gmail.com; 
cfe-commits@lists.llvm.org; llvm-comm...@lists.llvm.org; Liu, Yaxun (Sam) 
; zhang.guans...@gmail.com; Kumar N, Bhuvanendra 
; yanliang...@intel.com; dougp...@gmail.com; 
mlek...@skidmore.edu; blitzrak...@gmail.com; shen...@google.com; 
david.gr...@arm.com; t...@google.com; Song, Ruiling 
Subject: [PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for 
distribute

[CAUTION: External Email]

jdoerfert added a comment.

In D110429#3024886 
,
 @ronlieb wrote:

> looks like subsequent builders passed. we might have an issue where the 
> runtime was not fully built when the test ran.
> please disregard , your patch is fine.

two dependent patches and you probably picked up only one. Should resolve 
itself.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD110429%2Fnew%2Fdata=04%7C01%7Cron.lieberman%40amd.com%7C3712fe9761b14dbbe0d208d981d0cac1%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637683556037623058%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=Mx06vT2zOUb1zF50rqbgWhHTKH%2Ba2dIunlcB4BGxwqU%3Dreserved=0

https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD110429data=04%7C01%7Cron.lieberman%40amd.com%7C3712fe9761b14dbbe0d208d981d0cac1%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637683556037623058%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=Eq%2FRXJpykvyBfM6x9grzFOac39xI9BnKua1fJZkfL5g%3Dreserved=0
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

RE: [PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

2021-06-30 Thread Lieberman, Ron via cfe-commits 
[AMD Official Use Only]

It maybe that the patch does not expose __CUDA__ directly.
Rather the patch works so well we finally see the pre-existing issue in 
complex.h

./clang/lib/Headers/openmp_wrappers/complex.h

-Original Message-
From: Jon Chesterfield via Phabricator  
Sent: Wednesday, June 30, 2021 12:33 PM
To: Singh, Pushpinder ; 
jonathanchesterfi...@gmail.com; xw111lu...@gmail.com; Lieberman, Ron 
; greg63...@gmail.com; jdoerf...@anl.gov; Liu, Yaxun 
(Sam) ; Chan, SiuChi ; Sumner, Brian 
; jhub...@vols.utk.edu; tianshilei1...@gmail.com
Cc: Shi, Aaron En Ye ; estewar...@gmail.com; 
stefomeis...@gmail.com; cfe-commits@lists.llvm.org; 
jv...@scarletmail.rutgers.edu; zhang.guans...@gmail.com; Kumar N, Bhuvanendra 
; mlek...@skidmore.edu; blitzrak...@gmail.com; 
shen...@google.com; t...@google.com; kuh...@google.com
Subject: [PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

[CAUTION: External Email]

JonChesterfield added a comment.

@ronlieb reports that this change means __CUDA__ is defined for openmp amdgcn 
compilation. I'm going to try to verify that


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD104904%2Fnew%2Fdata=04%7C01%7Cron.lieberman%40amd.com%7C30a5efe76bea490b3ca008d93be4a84d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637606675525170968%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=G75Ey7JiNVDx74nF6x0VeCazDx6nngKoYzufecJdCok%3Dreserved=0

https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD104904data=04%7C01%7Cron.lieberman%40amd.com%7C30a5efe76bea490b3ca008d93be4a84d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637606675525170968%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=LSZRpI6r4KqgKR5ZREXDlLH5kJPUJr20vgK79wC0dCU%3Dreserved=0
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits