Re: [PATCH] D80144: [clang-format] @lefticus just taught the world how to use [[unlikely]] but we forgot to teach clang-format

2020-05-26 Thread Marcus Johnson via cfe-commits
Why objective C? C++ has attributes and so does C2x, and I believe they’re both getting /have the unlikely attribute. > On May 25, 2020, at 1:10 PM, MyDeveloperDay via Phabricator > wrote: > > MyDeveloperDay added a comment. > > > >> I know that we didn't have a test for this in ObjC

Re: [PATCH] D75791: [clang-format] Added new option IndentExternBlock

2020-03-27 Thread Marcus Johnson via cfe-commits
I’m wondering if theres a way to tell if an option has been set in the clang-format config file. If IndentExternBlock is not set, we should default to the old behavior. As for your suggestion of setting IndentExternBlock to BraceWrapping.AfterExternBlock or negating it, neither way works with