[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

2022-12-28 Thread Mariusz Ceier via Phabricator via cfe-commits 
mceier added a comment.

Checked the changes I'm suggesting and they fix the standalone build.




Comment at: clang/lib/Basic/Targets/AArch64.cpp:650
+  .Case(NAME, FMV_PRIORITY)
+#include "../../../../llvm/include/llvm/TargetParser/AArch64TargetParser.def"
+  ;

That doesn't work for standalone builds. Instead maybe use `#include 
"llvm/TargetParser/AArch64TargetParser.def"` ?




Comment at: clang/lib/Basic/Targets/AArch64.cpp:669
+  .Case(NAME, DEP_FEATURES)
+#include "../../../../llvm/include/llvm/TargetParser/AArch64TargetParser.def"
+   .Default("");

Same comment as on line 650. `#include 
"llvm/TargetParser/AArch64TargetParser.def"` 



Comment at: clang/lib/Basic/Targets/AArch64.cpp:679
+  .Case(NAME, llvm::AArch64::FEAT_##FMV_ID)
+#include "../../../../llvm/include/llvm/TargetParser/AArch64TargetParser.def"
+  .Default(llvm::AArch64::FEAT_MAX);

Same comment as on line 650. `#include 
"llvm/TargetParser/AArch64TargetParser.def"` 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127812/new/

https://reviews.llvm.org/D127812

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D138274: Add version to all LLVM cmake package

2022-11-24 Thread Mariusz Ceier via Phabricator via cfe-commits 
mceier added inline comments.



Comment at: clang/cmake/modules/ClangConfig.cmake.in:6
+set(LLVM_VERSION 
${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH})
+find_package(LLVM @LLVM_VERSION@ EXACT REQUIRED CONFIG
  HINTS "@CLANG_CONFIG_LLVM_CMAKE_DIR@")

I think instead of  `@LLVM_VERSION@` it should be `${LLVM_VERSION}` since 
`@LLVM_VERSION@` can be something like `16.0.0gitfce7a7aa` when 
LLVM_VERSION_SUFFIX is set and that value is incorrect according to cmake 
find_package:

>  find_package called with invalid argument "16.0.0gitfce7a7aa"

This error message is produced by cmake when configuring standalone build of 
lldb:

> CMake Error at /usr/lib/llvm/16/lib64/cmake/clang/ClangConfig.cmake:10 
> (find_package):
> find_package called with invalid argument "16.0.0gitfce7a7aa"
> Call Stack (most recent call first):
> cmake/modules/LLDBStandalone.cmake:10 (find_package)
> CMakeLists.txt:30 (include)





Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138274/new/

https://reviews.llvm.org/D138274

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits