[PATCH] D102306: Add gfx1034

msearles added a comment. In D102306#2758166 , @JonChesterfield wrote: > Is there documentation for the mapping from product names to gfx numbers? See the Processors section of https://llvm.org/docs/AMDGPUUsage.html Repository: rG LLVM Github

[PATCH] D96906: [AMDGPU] gfx90a support

msearles added a comment. In D96906#2572749 , @kzhuravl wrote: >> The point is that nobody upstream even got a chance to chime in. > > We are and will be taking care of any feedback provided in this review > post-commit. To be fair to @rampitec , it was

[PATCH] D47150: [Clang Tablegen] Add llvm_unreachable() to getModifierName()

This revision was automatically updated to reflect the committed changes. Closed by commit rL332854: [Clang Tablegen] Add llvm_unreachable() to getModifierName() (authored by msearles, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D47150: [Clang Tablegen] Add llvm_unreachable() to getModifierName()

msearles updated this revision to Diff 147809. msearles added a comment. Add comment per reviewer suggestion. https://reviews.llvm.org/D47150 Files: utils/TableGen/ClangDiagnosticsEmitter.cpp Index: utils/TableGen/ClangDiagnosticsEmitter.cpp

[PATCH] D47150: [Clang Tablegen] Add llvm_unreachable() to getModifierName()

msearles updated this revision to Diff 147807. msearles retitled this revision from "[Clang Tablegen] Add default case to getModifierName()" to "[Clang Tablegen] Add llvm_unreachable() to getModifierName()". msearles added a comment. Ah, yes. Adding llvm_unreachable() is better. Done.

[PATCH] D47150: [Clang Tablegen] Add default case to getModifierName()

msearles created this revision. msearles added reviewers: b-sumner, kzhuravl, EricWF, rjmccall. Herald added subscribers: ioeric, ilya-biryukov. Fix internal build failure: ../../../ClangDiagnosticsEmitter.cpp -o ClangDiagnosticsEmitter.o ../../../ClangDiagnosticsEmitter.cpp: In function

[PATCH] D43094: AMDGPU: Enable PIC by default for amdgcn

msearles accepted this revision. msearles added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D43094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org