[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

Mordante added a comment. Herald added subscribers: bviyer, jplehr. For libc++ we like to clean up the review queue for the GitHub PR transition. Is there still interest on working on this patch? If so would it be possible to finish it before the Phabricator is changed to read only mode?

[PATCH] D133425: Silence -Wctad-maybe-unsupported stemming from system headers

Mordante added a comment. @aaron.ballman We'd like to clean up the patches from the libc++ review queue. Is this patch is still relevant? Especially after landing https://reviews.llvm.org/D133535. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158523: [clang][doc] Mentions -Wno-reserved-module-identifiers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc73de2969162: [clang][doc] Mentions -Wno-reserved-module-identifiers (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D158523: [clang][doc] Mentions -Wno-reserved-module-identifiers

Mordante created this revision. Mordante added a reviewer: ChuanqiXu. Herald added a project: All. Mordante requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a nicer way to suppress the diagnostic instead of using the pre-processor

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

Mordante added inline comments. Comment at: libcxx/include/__type_traits/is_constant_evaluated.h:31 + return false; +#endif } hazohelet wrote: > Mordante wrote: > > Why is this needed? Does this mean the builtin will fail in C++03 mode? >

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

Mordante added inline comments. Comment at: libcxx/include/__type_traits/is_constant_evaluated.h:31 + return false; +#endif } Why is this needed? Does this mean the builtin will fail in C++03 mode? Comment at:

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

Mordante added a comment. In D112921#4594092 , @wangpc wrote: > - Rebase. > - Update tests, remove clang-17. The removal of the markers in the libc++ tests breaks these test. FYI the tests are using a Clang build of apt.llvm.org and are not using this

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

Mordante accepted this revision. Mordante added a comment. I'm happy with the libc++ changes, please wait a few days for @ldionne to react. In D112921#4584704 , @aaron.ballman wrote: > In D112921#4581641 , @rnk

[PATCH] D156032: Implement CWG2137 (list-initialization from objects of the same type)

Mordante accepted this revision as: libc++. Mordante added a comment. I only looked at the libc++ changes. The libc++ AIX CI failures are unrelated to your patch. LGTM modulo one nit. Comment at:

[PATCH] D157324: [clang] Move the Clang CI jobs off of the libc++ builders

Mordante accepted this revision. Mordante added a comment. Nice to see the Clang CI new builder! Thanks for working on this, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157324/new/ https://reviews.llvm.org/D157324

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

Mordante added a comment. In D112921#4541063 , @wangpc wrote: > - Rebase. > - Unsupport clang-18. I see the libc++ build failed. It seems like timeouts uploading artifacts, so not related to your patch. Can you rebase and give it another run on the CI?

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

Mordante added a comment. In D156247#4541756 , @ilya-biryukov wrote: > In D156247#4540228 , @Mordante > wrote: > >> 2. My biggest concern is the timing of this patch. The date of the branching >> is know

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

Mordante added a comment. I see one libc++ failure, I have not looked into the other failures. Comment at: libcxx/test/libcxx/language.support/support.dynamic/libcpp_deallocate.sh.cpp:29 +// TODO(mordante) fix this test after updating clang in Docker +// UNSUPPORTED: clang-17

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

Mordante added a comment. In D156247#4538626 , @aaron.ballman wrote: > I would like explicit buy-in from the libc++ folks on the idea of adding > `-fno-coroutines` as they're going to be impacted by Clang supporting such an > option (and they may have

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

Mordante added a comment. In D112921#4535716 , @wangpc wrote: > In D112921#4532378 , @Mordante > wrote: > >> In D112921#4530916 , @wangpc wrote: >> >>> In

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Mordante added a subscriber: var-const. Mordante added a comment. In D152003#4534963 , @Fznamznon wrote: >> What do you mean with libstdc++ is fine? > > What I mean is when I do (current patch is applied to clang): > >

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

Mordante added a comment. In D112921#4530916 , @wangpc wrote: > In D112921#4529182 , @Mordante > wrote: > >> I noticed some of the CI jobs are still failing with the patch, I didn't >> look into them. > > I

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Mordante added a comment. In D152003#4531404 , @Fznamznon wrote: >> should we try to land that today? > > I'm not sure. It causes failures in libc++ testing: > > Failed Tests (3): > llvm-libc++-shared.cfg.in :: std/ranges/range.access/end.pass.cpp

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

Mordante added a comment. I noticed some of the CI jobs are still failing with the patch, I didn't look into them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112921/new/ https://reviews.llvm.org/D112921

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

Mordante added inline comments. Comment at: libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/sized_delete_array14.pass.cpp:16 +// Sized deallocation was added in macOS 10.12 and aligned OSes. +// XFAIL: use_system_cxx_lib &&

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

Mordante added inline comments. Comment at: libcxx/test/std/utilities/meta/meta.const.eval/is_constant_evaluated.verify.cpp:27 static_assert(!std::is_constant_evaluated(), ""); - // expected-warning@-1 0-1 {{'std::is_constant_evaluated' will always evaluate to 'true' in a

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

Mordante added a comment. I only looked at the libc++ part. Comment at: libcxx/test/std/utilities/meta/meta.const.eval/is_constant_evaluated.verify.cpp:27 static_assert(!std::is_constant_evaluated(), ""); - // expected-warning@-1 0-1 {{'std::is_constant_evaluated' will

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

Mordante added a comment. Thanks for working on this! I really like the direction. I mainly skimmed the code since the patch as already landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155078/new/ https://reviews.llvm.org/D155078

[PATCH] D153038: [Clang] Fixes a diagnostic typo.

This revision was automatically updated to reflect the committed changes. Closed by commit rG501405f1d5f0: [Clang] Fixes a diagnostic typo. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153038/new/

[PATCH] D153038: [Clang] Fixes a diagnostic typo.

Mordante created this revision. Mordante added a reviewer: ChuanqiXu. Herald added a project: All. Mordante requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some small style updates as drive-by. Repository: rG LLVM Github Monorepo

[PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Mordante marked an inline comment as done. Closed by commit rGcbaa3597aaf6: Reland [CMake] Bumps minimum version to 3.20.0. (authored by

[PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

Mordante accepted this revision. Mordante marked 3 inline comments as done. Mordante added a comment. In D151344#4368926 , @MaskRay wrote: > Thank you for making another try for the treewide change (which is admittedly > very painful and not many people

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante added a comment. I've created D151344 @glandium @hans @thakis I really would appreciate when you can test the patch locally to avoid another revert round. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

Mordante created this revision. Mordante added reviewers: glandium, hans, thakis. Herald added subscribers: libc-commits, bviyer, ekilmer, Moerafaat, zero9178, Enna1, bzcheeseman, ayermolo, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1,

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante added a comment. In D144509#4356160 , @hans wrote: > In D144509#4350052 , @Mordante > wrote: > >> In D144509#4349921 , @thakis wrote: >> >>> Reverted this and

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante added a comment. In D144509#4350148 , @thakis wrote: > https://github.com/llvm/llvm-project/issues/62719 is independent of chromium > and others have reported problems above too, from what I understand. Is that > not accurate? That bug report

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante added a comment. In D144509#4349017 , @dyung wrote: > I'm not really sure where else to post this, but the pre-merge linux bot > still seems to be running 3.18.4. > >

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante added a comment. In D144509#4349921 , @thakis wrote: > Reverted this and follow-ups in d763c6e5e2d0a6b34097aa7dabca31e9aff9b0b6 > for now. > > Sorry this is such a pain to

[PATCH] D150450: Add C++26 compile flags.

Mordante added inline comments. Comment at: clang/docs/CommandGuide/clang.rst:206-210 + Working draft for ISO C++ 2026 + + | ``gnu++2c`` + + Working draft for ISO C++ 2026 with GNU extensions erichkeane wrote: > aaron.ballman wrote: > > We shouldn't call it

[PATCH] D150450: Add C++26 compile flags.

Mordante accepted this revision. Mordante added a comment. This revision is now accepted and ready to land. In D150450#4338065 , @erichkeane wrote: > In D150450#4338034 , @Mordante > wrote: > >> In

[PATCH] D150450: Add C++26 compile flags.

Mordante added a comment. In D150450#4337952 , @erichkeane wrote: > In D150450#4337858 , @cor3ntin > wrote: > >> Similar PR here https://reviews.llvm.org/D149875 > > Ah! I'd not noticed that one (or maybe

[PATCH] D150063: [clang] Restores some -std=c++2b tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd556368a1a8: [clang] Restores some -std=c++2b tests. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150063/new/

[PATCH] D150063: [clang] Restores some -std=c++2b tests.

Mordante created this revision. Mordante added a reviewer: aaron.ballman. Herald added a project: All. Mordante updated this revision to Diff 520185. Mordante added a comment. Mordante edited the summary of this revision. Mordante published this revision for review. Herald added a project: clang.

[PATCH] D146090: [Clang] Updating handling of defaulted comparison operators to reflect changes from P2448R2

Mordante added a comment. In D146090#4319685 , @shafik wrote: > Landed fix 7887af027ee5eff27bbc953074726ab8d9d9f592 > > > There was also 058f04ea7dcbafbeed271fa75ee65e41409b4479 >

[PATCH] D149553: [clang] Use -std=c++23 instead of -std=c++2b

Mordante marked 3 inline comments as done. Mordante added a comment. In D149553#4313211 , @aaron.ballman wrote: > In D149553#4312788 , @Mordante > wrote: > >> In D149553#4310478

[PATCH] D149553: [clang] Use -std=c++23 instead of -std=c++2b

Mordante added a comment. In D149553#4310478 , @aaron.ballman wrote: > Thank you for working on this! The Clang changes are mostly all good, but I > think we should hold off on changing the value of `__cplusplus` for the > moment as it's not set in

[PATCH] D149553: [clang] Use -std=c++23 instead of -std=c++2b

Mordante added inline comments. Comment at: libcxx/test/tools/clang_tidy_checks/uglify_attributes.cpp:46 - if (lang_opts.CPlusPlus2b) { attributes.emplace_back("assume"); philnik wrote: > You probably want to `#ifdef` this based on Clang 16/17. Yeah I

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

Mordante added a comment. One suggestion for the commit message either use `[[maybe_unused]]` or `-Wno-unused` that way the unrelated messages aren't shown in the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/

[PATCH] D147844: Emit warning when implicit cast from int to bool happens in an conditional operator expression

Mordante accepted this revision. Mordante added a comment. I too am not really convinced by all changes in libc++. On the other hand I don't think the change make the libc++ code looking bad. So I don't feel a reason to reject the libc++ changes. I don't like the commit message, there's only a

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

Mordante marked an inline comment as done. Mordante added inline comments. Comment at: libcxx/test/std/thread/thread.threads/thread.thread.class/thread.thread.id/parse.pass.cpp:49 + std::same_as auto it = formatter.parse(parse_ctx); + assert(it == fmt.end() - (!fmt.empty()

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

Mordante added inline comments. Comment at: libcxx/include/__type_traits/is_equality_comparable.h:46 template -struct __is_trivially_equality_comparable +struct __libcpp_is_trivially_equality_comparable : integral_constant Mordante wrote: > > This does not magically use

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88622aabf107: [libc++][format] Implements formatter thread::id. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

Mordante added a comment. I mainly glossed over the patch and didn't do a real review. Comment at: clang/lib/AST/ASTContext.cpp:2672 +const RecordDecl *RD, +bool

[PATCH] D146986: Downgrade reserved module identifier error into a warning

Mordante added a comment. Sorry I was not available earlier. Thanks for working on this. LGTM but one remark. Comment at: clang/docs/ReleaseNotes.rst:92 + `_ and allows easier + building of precompiled modules. This

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

Mordante updated this revision to Diff 511875. Mordante added a comment. CI fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144331/new/ https://reviews.llvm.org/D144331 Files: libcxx/docs/FeatureTestMacroTable.rst

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

Mordante updated this revision to Diff 511865. Mordante added a comment. Herald added a subscriber: krytarowski. CI fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144331/new/ https://reviews.llvm.org/D144331 Files:

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

Mordante updated this revision to Diff 511715. Mordante added a comment. CI fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144331/new/ https://reviews.llvm.org/D144331 Files: libcxx/docs/FeatureTestMacroTable.rst

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

Mordante updated this revision to Diff 511709. Mordante added a comment. CI fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144331/new/ https://reviews.llvm.org/D144331 Files: libcxx/docs/FeatureTestMacroTable.rst

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

Mordante updated this revision to Diff 511705. Mordante marked 2 inline comments as done. Mordante added a comment. Rebased, addresses review comment, and get a CI run. Herald added a comment. NOTE: Clang-Format Team Automated Review Comment It looks like your clang-format review does not

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

Mordante marked 4 inline comments as done. Mordante added a comment. Herald added projects: clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. Thanks for the review! Comment at:

[PATCH] D144328: [libc++][format][chrono] Addresses LWG3842.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf07b882e2c1: [libc++][format][chrono] Addresses LWG3842. (authored by Mordante). Herald added projects: clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel,

[PATCH] D146240: [libc++][format] Use granularized charconv.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG57e20cab5a1d: [libc++][format] Use granularized charconv. (authored by Mordante). Herald added projects: clang, clang-format. Herald added a

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG44c6b905f852: [CMake] Bumps minimum version to 3.20.0. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144894: [clang] Documents clang-scan-deps requirements.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8dbeb41f8ebd: [clang] Documents clang-scan-deps requirements. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D144894: [clang] Documents clang-scan-deps requirements.

Mordante created this revision. Mordante added a reviewer: ChuanqiXu. Herald added a project: All. Mordante requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was discussed in https://llvm.org/PR61006. Repository: rG LLVM Github

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante updated this revision to Diff 500547. Mordante added a comment. Rebased to test CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144509/new/ https://reviews.llvm.org/D144509 Files: bolt/runtime/CMakeLists.txt clang/CMakeLists.txt

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante updated this revision to Diff 499569. Mordante added a comment. Herald added a subscriber: mstorsjo. Try to fix AIX CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144509/new/ https://reviews.llvm.org/D144509 Files:

[PATCH] D144497: [clang][doc] Removes obsolete comment.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7b6978285c1: [clang][doc] Removes obsolete comment. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144497/new/

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante created this revision. Mordante added reviewers: bollu, tstellar, mehdi_amini, MaskRay, ChuanqiXu, to268, kparzysz, thieta, tschuett, mgorny, stellaraccident, mizvekov, ldionne, jdoerfert, phosek. Herald added subscribers: libc-commits, libcxx-commits, Moerafaat, zero9178, Enna1,

[PATCH] D144497: [clang][doc] Removes obsolete comment.

Mordante created this revision. Mordante added a reviewer: ChuanqiXu. Herald added a project: All. Mordante requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After reading about the documentation improvements on LLVM weekly this part seems

[PATCH] D142690: [libc++] Fixes the Clang modular build.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa7f8ddc4e2e3: [libc++] Fixes the Clang modular build. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142690: [libc++] Fixes the Clang modular build.

Mordante added a comment. https://buildkite.com/llvm-project/libcxx-ci/builds/18148 shows this patch fixes the Clang modular build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142690/new/ https://reviews.llvm.org/D142690

[PATCH] D142690: [DRAFT][libc++] Fixes the Clang modular build.

Mordante updated this revision to Diff 492999. Mordante added a comment. Undo CI changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142690/new/ https://reviews.llvm.org/D142690 Files: libcxx/include/module.modulemap.in Index:

[PATCH] D142690: [DRAFT][libc++] Fixes the Clang modular build.

Mordante updated this revision to Diff 492834. Mordante added a comment. Removes uninteded include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142690/new/ https://reviews.llvm.org/D142690 Files: libcxx/include/module.modulemap.in

[PATCH] D142690: [DRAFT][libc++] Fixes the Clang modular build.

Mordante updated this revision to Diff 492828. Mordante added a comment. Finalized patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142690/new/ https://reviews.llvm.org/D142690 Files: clang/lib/run_the_clang_CI

[PATCH] D142690: [DRAFT][libc++] Fixes the Clang modular build.

Mordante updated this revision to Diff 492779. Mordante added a comment. Rebased and improve fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142690/new/ https://reviews.llvm.org/D142690 Files: clang/lib/run_the_clang_CI

[PATCH] D142690: [DRAFT][libc++] Fixes the Clang modular build.

Mordante updated this revision to Diff 492648. Mordante added a comment. Herald added a subscriber: arichardson. Fix CI run instead of libc++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142690/new/ https://reviews.llvm.org/D142690 Files:

[PATCH] D142690: [DRAFT][libc++] Fixes the Clang modular build.

Mordante added inline comments. Comment at: libcxx/include/module.modulemap.in:1421 + private header "__type_traits/integral_constant.h" + export type_traits.common_reference +} Note this looks wrong from libc++'s perspective. When this "solves"

[PATCH] D142690: [DRAFT][libc++] Fixes the Clang modular build.

Mordante created this revision. Herald added a project: All. Mordante requested review of this revision. Herald added projects: clang, libc++. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a reviewer: libc++. This attempts to fix the issue introduced in 12cb1cb3720d

[PATCH] D142500: Fix one of the regressions found in revert of concept sugaring

Mordante added a comment. In D142500#4080317 , @erichkeane wrote: > In D142500#4080302 , @erichkeane > wrote: > >> In D142500#4080279 , @Mordante >> wrote: >> >>> In

[PATCH] D142500: Fix one of the regressions found in revert of concept sugaring

Mordante added a comment. In D142500#4079669 , @erichkeane wrote: > In D142500#4079135 , @Mordante > wrote: > >> FYI I tested this patch with libc++ and as expected it does not fix the >> libc++ modular build

[PATCH] D142500: Fix one of the regressions found in revert of concept sugaring

Mordante added a comment. FYI I tested this patch with libc++ and as expected it does not fix the libc++ modular build ICE. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142500/new/ https://reviews.llvm.org/D142500 ___ cfe-commits mailing

[PATCH] D142007: [NFC] Fix "form/from" typos

Mordante added a comment. Thanks for your contribution, I just landed this patch on your behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142007/new/ https://reviews.llvm.org/D142007 ___

[PATCH] D142007: [NFC] Fix "form/from" typos

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG898b5c9f5e77: [NFC] Fix form/from typos (authored by pfusik, committed by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D142007: [NFC] Fix "form/from" typos

Mordante added a comment. In D142007#4071765 , @pfusik wrote: > @ldionne Can you check it in? Can you provide your name and email address to we can attribute the patch to you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

Mordante added a comment. I just tested locally with the latest nightly build Debian clang version 16.0.0 (++20230116071901+2563ad8ef1a8-1~exp1~20230116072002.532) Target: x86_64-pc-linux-gnu Thread model: posix InstalledDir: /usr/bin and that passes the test that fails in the CI. Can

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

Mordante added a comment. I see the current main pass for the module build in libc++. The error message seems different, from the message for missing parts of the module map. I'll dig a bit further to see whether I can find what's wrong. CHANGES SINCE LAST ACTION

[PATCH] D141423: Trigger the Clang/libc++ CI pipeline even when libc++ has been modified

Mordante added a comment. Should this also fix the issue where the scheduled build sometimes picks the "clang build"? For example https://buildkite.com/llvm-project/libcxx-ci/builds/17300 but I noticed to at other times too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

Mordante added a comment. I think it would be better to have a meeting to discuss this further instead of posting in this review. I propose to do it after everybody's back from their holidays. WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

Mordante added subscribers: erichkeane, ldionne, aaron.ballman. Mordante added a comment. In D139986#4017467 , @dblaikie wrote: > In D139986#4008169 , @Mordante > wrote: > >> In D139986#4005997

[PATCH] D131963: [libc++] Add custom clang-tidy checks

Mordante added inline comments. Comment at: libcxx/test/libcxx/clang_tidy.sh.cpp:15 // TODO: run clang-tidy with modules enabled once they are supported +// RUN: clang-tidy %s --warnings-as-errors=* -header-filter=.* --checks='-*,libcpp-*'

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

Mordante added a comment. In D139986#4005997 , @dblaikie wrote: > In D139986#4003873 , @Mordante > wrote: > >> In D139986#4001180 , @Michael137 >> wrote: >> >>> Missed

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

Mordante added a comment. In D139986#4001180 , @Michael137 wrote: > Missed couple of test cases in libcxx > About to fix those There were more breakage due to this patch, which I fixed in D140272 . Next time please

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Mordante marked an inline comment as done. Closed by commit rGd40dc417389e: [CMake] Warn when the version is older than 3.20.0. (authored by Mordante). Changed prior

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

Mordante marked an inline comment as done. Mordante added a comment. Thanks for all reviews! In D137724#3974764 , @thieta wrote: > I think this is ready to land @Mordante or is there anything else missing? No but I've been quite busy. I needed some

[PATCH] D138042: [libc++] Trigger both Clang and libc++ CI when there are changes to both

Mordante added a comment. Sorry I overlooked this review. Based on the CI output it only runs the Clang CI right. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138042/new/ https://reviews.llvm.org/D138042

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

Mordante accepted this revision. Mordante added a comment. LGTM after addressing @aaron.ballman's comments. Comment at: clang/lib/Headers/stdatomic.h:21 +#if __STDC_HOSTED__ && __has_include_next() \ +&& !(defined(_MSC_VER) && __cplusplus-0 <

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

Mordante added a comment. Thanks for the patch! Comment at: clang/lib/Headers/stdatomic.h:21 +#if __STDC_HOSTED__ && __has_include_next() \ +&& !(defined(_MSC_VER) && __cplusplus-0 < 202002l) # include_next Is `__cplusplus-0`

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

This revision was automatically updated to reflect the committed changes. Mordante marked an inline comment as done. Closed by commit rG0c111dd86fff: [libc++] Documents details of the pre-commit CI. (authored by Mordante). Changed prior to commit:

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

Mordante marked 6 inline comments as done. Mordante added a comment. Thanks for all feedback! Comment at: clang/www/hacking.html:311-312 + Unlike Clang, libc++ supports multiple versions of Clang. Therefore when a + patch changes the diagnostics it might be required to use a

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

Mordante added a comment. In D137724#3917644 , @MaskRay wrote: > I think `if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)` checks for > standalone builds is not necessary. The check in `llvm/CMakeLists.txt` > suffices. > It's unlikely the users

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

Mordante added a comment. In D137724#3917616 , @thieta wrote: > I think this is fine as we have discussed before. But I really dislike the > code duplication for the check. We could put it in a include() I guess - but > maybe it's not worth it. I

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

Mordante created this revision. Herald added a reviewer: bollu. Herald added subscribers: Moerafaat, zero9178, Enna1, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob,

[PATCH] D135177: [clang] adds `__is_scoped_enum`, `__is_nullptr`, and `__is_referenceable`

Mordante added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:525 +TYPE_TRAIT_1(__is_scoped_enum, IsScopedEnum, KEYCXX) +TYPE_TRAIT_1(__is_referenceable, IsReferenceable, KEYCXX) TYPE_TRAIT_2(__reference_binds_to_temporary, ReferenceBindsToTemporary,

[PATCH] D134878: Update developer policy on potentially breaking changes

Mordante added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:129 + + People interested in joining the vendors group can do so by clicking the + "Join Project" link on the vendor's "Members" page in Phabricator. aaron.ballman wrote: > Mordante

  1   2   3   4   5   >