[PATCH] D53238: [Driver] Add -static-{rtlib, stdlib} and make -static-{libgcc, libstdc++} their aliases

2018-12-04 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. Also, Sorry for the long time to reply, I don't LLVM often enough :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53238/new/ https://reviews.llvm.org/D53238 ___ cfe-commits mailing list

[PATCH] D53238: [Driver] Add -static-{rtlib, stdlib} and make -static-{libgcc, libstdc++} their aliases

2018-12-04 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. Seems like a better solution than what I had in D37726 . I'm not sully sure on the naming so I think someone else should also sign off on this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53238/new/

[PATCH] D37726: clang: alias -static-{libstdc++, libgcc} for LLVM variants

2018-12-04 Thread Martell Malone via Phabricator via cfe-commits
martell abandoned this revision. martell added a comment. Dropping in favour of D53238 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37726/new/ https://reviews.llvm.org/D37726 ___

[PATCH] D45505: [WIP] [GCC] Match a GCC version with a patch suffix without a third version component

2018-04-22 Thread Martell Malone via Phabricator via cfe-commits
martell accepted this revision. martell added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D45505 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45152: [MinGW] Add option for disabling looking for a mingw gcc in PATH

2018-04-04 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. @mstorsjo I would much prefer to detect the clang sysroot first and if that exists just ignore the gcc one. Most of the time clang and gcc will be in the same bin folder and in the case where the clang sysroot with mingw prefix folders is not found we can just default

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

2018-03-08 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. Herald added a subscriber: mgrang. ping @marsupial https://reviews.llvm.org/D35103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41597: CMAKE: disable -mbig-obj for mingw clang asm

2018-02-07 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. Updated to just ignore the flag just like how clang-cl does for /bigobj Repository: rC Clang https://reviews.llvm.org/D41597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41597: CMAKE: disable -mbig-obj for mingw clang asm

2018-02-07 Thread Martell Malone via Phabricator via cfe-commits
martell updated this revision to Diff 133374. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D41597 Files: include/clang/Driver/Options.td Index: include/clang/Driver/Options.td === ---

[PATCH] D41809: Clang counterpart change for fuzzer FreeBSD support

2018-01-13 Thread Martell Malone via Phabricator via cfe-commits
martell accepted this revision. martell added a comment. Given that https://reviews.llvm.org/rL322380 has been merged this seems good to me. https://reviews.llvm.org/D41809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

2017-11-28 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. I also want to note a small addition armb and thumbeb for NetBSD. They were missed in the previous version. Just waiting for tests to pass now. Repository: rL LLVM https://reviews.llvm.org/D39673 ___ cfe-commits mailing

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

2017-11-28 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. @mstorsjo yup, I added a comment on the commit about the failure here https://reviews.llvm.org/rL319294 I have already fixed both issues. Will re apply shortly. Repository: rL LLVM https://reviews.llvm.org/D39673 ___

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

2017-11-28 Thread Martell Malone via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL319294: Toolchain: Normalize dwarf, sjlj and seh eh (authored by martell). Changed prior to commit: https://reviews.llvm.org/D39673?vs=124695=124696#toc Repository: rL LLVM

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

2017-11-28 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. landing this as it was previous approved by reid in this state and again re checked by martin. Repository: rL LLVM https://reviews.llvm.org/D39673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

2017-11-28 Thread Martell Malone via Phabricator via cfe-commits
martell updated this revision to Diff 124695. martell added a comment. - disregard my last comment, lets go with seh on all windows targets. Repository: rL LLVM https://reviews.llvm.org/D39673 Files: docs/ClangCommandLineReference.rst include/clang/Basic/LangOptions.def

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

2017-11-28 Thread Martell Malone via Phabricator via cfe-commits
martell added inline comments. Comment at: lib/Driver/ToolChain.cpp:458 +if (Triple.getArch() == llvm::Triple::x86) + return llvm::ExceptionHandling::DwarfCFI; +else mstorsjo wrote: > I'd suggest braces around the outer if statement. > > But is

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

2017-11-28 Thread Martell Malone via Phabricator via cfe-commits
martell updated this revision to Diff 124692. martell added a comment. address reid's comment update to HEAD Repository: rL LLVM https://reviews.llvm.org/D39673 Files: docs/ClangCommandLineReference.rst include/clang/Basic/LangOptions.def include/clang/Driver/Options.td

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

2017-11-22 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. In https://reviews.llvm.org/D39673#931861, @rnk wrote: > We have to know the EH model before pre-processing, and that shouldn't rely > on LLVM TargetOptions. We can probably reuse the `llvm::ExceptionHandling` > enum instead of these various overlapping booleans, if

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

2017-11-22 Thread Martell Malone via Phabricator via cfe-commits
martell updated this revision to Diff 123883. martell edited the summary of this revision. martell added a comment. Herald added subscribers: kristof.beyls, emaste, aemerson. fold USESjLjExceptions into GetExceptionModel. do a best effort to check the llvm default exception model for the triple

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

2017-11-21 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. Just as a note there is still a lot to be desired here. I do not particularly like the `UseSEHExceptions` function default and the actual macro definition guards should be based on the current `ExceptionModel` because we set that in `lib/CodeGen/BackendUtil.cpp`. This

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

2017-11-21 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. In https://reviews.llvm.org/D39673#929986, @mstorsjo wrote: > I'm not sure if this is the right thing to do. Since the exception handling > model more or less also defines what ABI the code conforms to, I can see it > being useful to know what exception handling mode

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

2017-11-21 Thread Martell Malone via Phabricator via cfe-commits
martell updated this revision to Diff 123758. martell added a comment. updated to HEAD. added a NOT msvc test Repository: rL LLVM https://reviews.llvm.org/D39673 Files: docs/ClangCommandLineReference.rst include/clang/Basic/LangOptions.def include/clang/Driver/Options.td

[PATCH] D40285: [MINGW] normalize WIN32 macros

2017-11-21 Thread Martell Malone via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL318755: [MINGW] normalize WIN32 macros (authored by martell). Changed prior to commit: https://reviews.llvm.org/D40285?vs=123751=123755#toc Repository: rL LLVM https://reviews.llvm.org/D40285

[PATCH] D40285: [MINGW] normalize WIN32 macros

2017-11-21 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. @mstorsjo can you confirm this new order looks good to you? Repository: rL LLVM https://reviews.llvm.org/D40285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40285: [MINGW] normalize WIN32 macros

2017-11-21 Thread Martell Malone via Phabricator via cfe-commits
martell updated this revision to Diff 123751. martell added a comment. reorder test checks Repository: rL LLVM https://reviews.llvm.org/D40285 Files: lib/Basic/Targets.cpp lib/Basic/Targets.h lib/Basic/Targets/AArch64.cpp lib/Basic/Targets/AArch64.h lib/Basic/Targets/ARM.cpp

[PATCH] D40285: [MINGW] normalize WIN32 macros

2017-11-21 Thread Martell Malone via Phabricator via cfe-commits
martell updated this revision to Diff 123747. martell edited the summary of this revision. martell added a comment. [MINGW] normalize WIN32 macros Repository: rL LLVM https://reviews.llvm.org/D40285 Files: lib/Basic/Targets.cpp lib/Basic/Targets.h lib/Basic/Targets/AArch64.cpp

[PATCH] D40285: [MS] AARCH64 cleanup default WIN macros

2017-11-21 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. In https://reviews.llvm.org/D40285#931248, @mstorsjo wrote: > I'm a little divided - either we remove both WIN32 and WIN64 from all mingw > configurations, or we add the missing WIN32 for x86_64 mingw. Removing would > be the strictly correct thing to do, but I'm sure

[PATCH] D40285: [MS] AARCH64 cleanup default WIN macros

2017-11-21 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. ... also WINNT was defined for X86 so I just added that to note it. what do you suggest we do with that one. Repository: rL LLVM https://reviews.llvm.org/D40285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40285: [MS] AARCH64 cleanup default WIN macros

2017-11-21 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. In https://reviews.llvm.org/D40285#931241, @mstorsjo wrote: > ... so in general I wouldn't mind doing a change like this, but I'd like to > make it consistent on ARM, i386 and x86_64 at the same time in that case, > instead of just changing aarch64. Thanks for the

[PATCH] D40285: [MS] AARCH64 cleanup default WIN macros

2017-11-21 Thread Martell Malone via Phabricator via cfe-commits
martell updated this revision to Diff 123728. Repository: rL LLVM https://reviews.llvm.org/D40285 Files: lib/Basic/Targets/AArch64.cpp lib/Basic/Targets/X86.h test/Preprocessor/predefined-macros.c Index: test/Preprocessor/predefined-macros.c

[PATCH] D40285: [MS] AARCH64 cleanup default WIN macros

2017-11-21 Thread Martell Malone via Phabricator via cfe-commits
martell created this revision. Herald added subscribers: kristof.beyls, javed.absar, rengolin, aemerson. _WIN32 is already defined in lib/Basic/Targets/OSTargets.h WIN32 and WIN64 are not real definitions they are typically defined by the system headers, _WIN32 and _WIN64 are the compiler

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

2017-11-19 Thread Martell Malone via Phabricator via cfe-commits
martell added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:684 +else if (TI.getTriple().isThumb() || TI.getTriple().isARM()) + Builder.defineMacro("__ARM_DWARF_EH__"); + } mstorsjo wrote: > Won't this start setting this define also on

[PATCH] D39588: Distro: initial support for alpine

2017-11-18 Thread Martell Malone via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL318608: [Driver] add initial support for alpine linux (authored by martell). Changed prior to commit: https://reviews.llvm.org/D39588?vs=121462=123488#toc Repository: rL LLVM

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

2017-11-18 Thread Martell Malone via Phabricator via cfe-commits
martell requested review of this revision. martell added a comment. Thanks for the review @rnk . I addressed the comment nit you had. @mstorsjo I updated this to also handle thumb on arm. When doing that I noticed there is something really strange about the existing macro defines. I assume

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

2017-11-18 Thread Martell Malone via Phabricator via cfe-commits
martell updated this revision to Diff 123486. martell added a comment. Herald added subscribers: JDevlieghere, javed.absar. updated to handle dwarf exceptions on arm. Repository: rL LLVM https://reviews.llvm.org/D39673 Files: docs/ClangCommandLineReference.rst

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

2017-11-13 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. Ping :) Repository: rL LLVM https://reviews.llvm.org/D39673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39588: Distro: initial support for alpine

2017-11-08 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. @rnk ping. Feel free to add anyone you think might be more suitable if you can't review this. Repository: rL LLVM https://reviews.llvm.org/D39588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

2017-11-08 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. @rnk ping :) Repository: rL LLVM https://reviews.llvm.org/D39673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

2017-11-06 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. In https://reviews.llvm.org/D39673, @martell wrote: > Long term I would like the MinGW Driver to load a different libunwind > depending on the exception model but that discussion might still be a little > off. In https://reviews.llvm.org/D39673#917510, @mstorsjo

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

2017-11-06 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. @mstorsjo I think this should help with issues like having to set the default for ARM to DWARF. If you can set it at run time then it should be a lot easier to just set that in the clang wrapper scripts. Long term I would like the MinGW Driver to load a different

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

2017-11-06 Thread Martell Malone via Phabricator via cfe-commits
martell updated this revision to Diff 121832. martell added a comment. Add command line documentation references Repository: rL LLVM https://reviews.llvm.org/D39673 Files: docs/ClangCommandLineReference.rst include/clang/Basic/LangOptions.def include/clang/Driver/Options.td

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

2017-11-05 Thread Martell Malone via Phabricator via cfe-commits
martell created this revision. Herald added a subscriber: aprantl. Adds `-fseh-exceptions` and `-fdwarf-exceptions` to compliment `-fsjlj-exceptions`. This makes the exception personality configurable at runtime rather then just compile time. If nothing is passed to cc1 we default to

[PATCH] D33620: [CodeGenCXX] do not default to dllimport storage for mingw-w64

2017-11-03 Thread Martell Malone via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL317398: CodeGenCXX: no default dllimport storage for mingw (authored by martell). Changed prior to commit: https://reviews.llvm.org/D33620?vs=100523=121578#toc Repository: rL LLVM

[PATCH] D39588: Distro: initial support for alpine

2017-11-03 Thread Martell Malone via Phabricator via cfe-commits
martell updated this revision to Diff 121462. martell edited the summary of this revision. Repository: rL LLVM https://reviews.llvm.org/D39588 Files: include/clang/Driver/Distro.h lib/Driver/Distro.cpp lib/Driver/ToolChains/Linux.cpp test/Driver/pic.c Index: test/Driver/pic.c

[PATCH] D39588: Distro: initial support for alpine

2017-11-02 Thread Martell Malone via Phabricator via cfe-commits
martell created this revision. Add alpine linux as a distro. We support building for musl since https://reviews.llvm.org/rL292848. Let's add this important docker / kubernetes empowering distro. Some bits are still missing but this is a good base. Repository: rL LLVM

[PATCH] D38123: [driver] [cl] Add/fix c++17/c++latest

2017-10-15 Thread Martell Malone via Phabricator via cfe-commits
martell added inline comments. Comment at: cfe/trunk/test/Driver/cl-options.c:524 +// RUN: %clang_cl -fmsc-version=1900 -TP -std:c++17 -### -- %s 2>&1 | FileCheck -check-prefix=STDCXX17 %s +// STDCXX14: -std=c++17 + This was incorrect, it should have been

[PATCH] D38290: Add a ld64.lld alias for the MACHO LLD target

2017-10-15 Thread Martell Malone via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL315865: MACHO: ld64.lld alias for the MACHO LLD target (authored by martell). Changed prior to commit: https://reviews.llvm.org/D38290?vs=116801=119087#toc Repository: rL LLVM

[PATCH] D38123: [driver] [cl] Add/fix c++17/c++latest

2017-10-15 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. Landed, @rnk I missed this message in my travels from Ireland back to Mountain View. Just catching up with everything now :) Repository: rL LLVM https://reviews.llvm.org/D38123 ___ cfe-commits mailing list

[PATCH] D38123: [driver] [cl] Add/fix c++17/c++latest

2017-10-15 Thread Martell Malone via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL315864: [driver] [cl] Add/fix c++17/c++latest (authored by martell). Changed prior to commit: https://reviews.llvm.org/D38123?vs=116154=119086#toc Repository: rL LLVM

[PATCH] D38819: [libunwind] Add support for dwarf unwinding on windows on x86_64

2017-10-15 Thread Martell Malone via Phabricator via cfe-commits
martell added inline comments. Comment at: docs/index.rst:55 NetBSD x86_64 Clang, GCC DWARF CFI -Windows i386 ClangDWARF CFI +Windows i386, x86_64 ClangDWARF CFI

[PATCH] D38290: Add a ld64.lld alias for the MACHO LLD target

2017-10-02 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. `CODE_OWNERS.TXT` does not have a list of `driver` owners. It does have rsmith as an owner for all things not covered by someone else so I added him. Reid usually reviews driver patches I submit to clang and is on the owner list so I added him here initially. I think

[PATCH] D38290: Add a ld64.lld alias for the MACHO LLD target

2017-09-28 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. In https://reviews.llvm.org/D38290#882911, @ruiu wrote: > Is this for cross-compilation? It is mostly for native compilation on mac but this will work for cross compiling also. > If you invoke lld on macOS, it should act as ld64. That is if the file name is `ld` or

[PATCH] D38290: Add a ld64.lld alias for the MACHO LLD target

2017-09-27 Thread Martell Malone via Phabricator via cfe-commits
martell updated this revision to Diff 116801. martell added a comment. address comment Repository: rL LLVM https://reviews.llvm.org/D38290 Files: tools/clang/lib/Driver/ToolChain.cpp tools/lld/tools/lld/CMakeLists.txt tools/lld/tools/lld/lld.cpp Index: tools/lld/tools/lld/lld.cpp

[PATCH] D38290: Add a ld64.lld alias for the MACHO LLD target

2017-09-26 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. I have a patch that does a bunch of updates for testing lld correctly in clang and this was a part of it but I didn't want the patch to get too involved so I separated this out. I have seen this issue raised on various forums such as stackoverflow here and figured I

[PATCH] D38290: Add a ld64.lld alias for the MACHO LLD target

2017-09-26 Thread Martell Malone via Phabricator via cfe-commits
martell created this revision. Herald added a subscriber: mgorny. Currently when we do `-fuse-ld=lld` for apple targets this invokes the gnu frontend because of the `ld.lld` alias This creates a new alias for ld64 as `ld64.lld` to avoid this. Repository: rL LLVM

[PATCH] D38123: [driver] [cl] Add/fix c++17/c++latest

2017-09-21 Thread Martell Malone via Phabricator via cfe-commits
martell accepted this revision. martell added a comment. This revision is now accepted and ready to land. It seems that msvc enabled some c++17 features when in c++14 mode and they left them enabled because projects became dependant on them. switching to c++17 as the default and removing the

[PATCH] D38123: [driver] [cl] Add/fix c++17/c++latest

2017-09-21 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. LGTM we should probably set c++17 as the default over c++14 as part of this change. given that everything seems in order for c++17 bar P0522R0 so this looks like the change should be good. adding @rnk to confirm. @daxpedda do you have commit access?

[PATCH] D37727: Driver: Remove custom MinGW linker detection

2017-09-12 Thread Martell Malone via Phabricator via cfe-commits
martell closed this revision. martell added a comment. Landed in https://reviews.llvm.org/rL313082 Repository: rL LLVM https://reviews.llvm.org/D37727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37727: Driver: Remove custom MinGW linker detection

2017-09-12 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. In https://reviews.llvm.org/D37727#868284, @rnk wrote: > Nice! IIUC, now that the gnu ld driver works on Windows we can remove this > logic. Thanks! We could have removed it before the addition of the gnu ld driver, I think the author just missed this target and

[PATCH] D37727: Driver: Remove custom MinGW linker detection

2017-09-12 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. In https://reviews.llvm.org/D37727#867751, @mstorsjo wrote: > I do the same by adding -rtlib=compiler-rt -stdlib=libc++ -fuse-ld=lld > -Qunused-arguments in the frontend script wrapper (a wrapper named > -w64-mingw32-clang that just calls clang -target -w64-mingw32 >

[PATCH] D37727: Driver: Remove custom MinGW linker detection

2017-09-12 Thread Martell Malone via Phabricator via cfe-commits
martell updated this revision to Diff 114801. martell added a comment. update tests Repository: rL LLVM https://reviews.llvm.org/D37727 Files: lib/Driver/ToolChains/MinGW.cpp test/Driver/mingw-useld.c Index: test/Driver/mingw-useld.c

[PATCH] D37727: Driver: Remove custom MinGW linker detection

2017-09-12 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. In https://reviews.llvm.org/D37727#867627, @mstorsjo wrote: > I'm not sure I like this direction. In my setups, a build-time default isn't > right since I'm using the same clang builds for both native-on-linux building > (with the default `ld` as linker) and

[PATCH] D37726: clang: alias -static-{libstdc++, libgcc} for LLVM variants

2017-09-11 Thread Martell Malone via Phabricator via cfe-commits
martell created this revision. Alias `-static-compiler-rt` and `static-libc++` to their gcc counterparts. Currently invoking `-static-libgcc` or `-static-libstdc++` will ensure only use of static libs. In future if we want to do more accurate handling with better behaviour with the linker we

[PATCH] D37530: [MinGW] Don't link -lmsvcrt if a different msvcrt version is to be linked

2017-09-11 Thread Martell Malone via Phabricator via cfe-commits
martell accepted this revision. martell added a comment. LGMT https://reviews.llvm.org/D37530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36364: [AArch64] Add support for a MinGW AArch64 target

2017-08-09 Thread Martell Malone via Phabricator via cfe-commits
martell accepted this revision. martell added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D36364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36364: [AArch64] Add support for a MinGW AArch64 target

2017-08-06 Thread Martell Malone via Phabricator via cfe-commits
martell added inline comments. Comment at: lib/Driver/ToolChains/MinGW.cpp:130 + case llvm::Triple::arm: + case llvm::Triple::thumb: CmdArgs.push_back("thumb2pe"); I believe this was left incase someone wanted to do windows ce in future. Can you add a

[PATCH] D36364: [AArch64] Add support for a MinGW AArch64 target

2017-08-06 Thread Martell Malone via Phabricator via cfe-commits
martell added inline comments. Comment at: lib/Driver/ToolChains/MinGW.cpp:129 + else if (TC.getArch() == llvm::Triple::aarch64) +CmdArgs.push_back("arm64pe"); + else mstorsjo wrote: > martell wrote: > > I believe the reason I used thumb2pe for the arm

[PATCH] D36364: [AArch64] Add support for a MinGW AArch64 target

2017-08-06 Thread Martell Malone via Phabricator via cfe-commits
martell added inline comments. Comment at: lib/Driver/ToolChains/MinGW.cpp:129 + else if (TC.getArch() == llvm::Triple::aarch64) +CmdArgs.push_back("arm64pe"); + else I believe the reason I used thumb2pe for the arm triple is because MS gave us a watered

[PATCH] D34873: Fix miscompiled 32bit binaries by mingw

2017-08-04 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. @rnk isn't this related to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78936 Assuming this is in fact a gcc bug this will most likely cause a regression with the standalone clang mingw toolchains we are on the verge of having. This is of course assuming clang does not

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

2017-07-13 Thread Martell Malone via Phabricator via cfe-commits
martell added inline comments. Comment at: examples/clang-interpreter/Manager.cpp:18 +#define NOMINMAX +#include +#endif windows.h with lower case `w` to not break mingw https://reviews.llvm.org/D35103 ___

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

2017-07-13 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. Just 2 small nits. Comment at: examples/clang-interpreter/main.cpp:165 + llvm::errs() << "'main' function not found in module.\n"; + return 255; +} 255 -> Res ? Comment at:

[PATCH] D34606: [libcxx] Link MinGW libs for shared build

2017-06-29 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. Not quite sure how this achieves anything different from what is already in `cmake/config-ix.cmake` ? https://reviews.llvm.org/D33638 addresses the remaining changes needed to build for windows shared and static in one build. Repository: rL LLVM

[PATCH] D33852: Enable __declspec(selectany) on linux

2017-06-03 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. > ! In https://reviews.llvm.org/D33852#772290, @davide wrote: > This assumption is not quite right. Also GCC, when targeting Linux, provides > a `-fms-extensions` flag. > There's a bunch of software out there that unfortunately has to target ELF > and build with

[PATCH] D33852: Enable __declspec(selectany) on linux

2017-06-03 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. @Prazek it wasn't disabled by mistake. This was a MS extension and it appeared as though the test case should have been for windows. I updated it and made the extension available to windows only. (MSVC, Cygwin, Mingw etc) It didn't expect anyone would want a MS

[PATCH] D33620: [CodeGenCXX] do not default to dllimport storage for mingw-w64

2017-05-26 Thread Martell Malone via Phabricator via cfe-commits
martell created this revision. GNU frontends don't have options like `/MT`, `/MD` etc so it makes little sense. This fixes a few link error regressions with libc++ and libc++abi Repository: rL LLVM https://reviews.llvm.org/D33620 Files: lib/CodeGen/CodeGenModule.cpp

[PATCH] D33082: Fix Libc++ build with MinGW64

2017-05-26 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. > ! In https://reviews.llvm.org/D33082#765898, @EricWF wrote: > I removed the section you're referring to because it's unneeded. > `<__locale>` does the exact same `#include` dance. and `` includes > `<__locale>`. > It should not have an affect on functionality. It

[PATCH] D33082: Fix Libc++ build with MinGW64

2017-05-26 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. LGTM but I can't speak for the area where you added `#include ` and killed off the `_NEWLIB_VERSION` check Seems in order based on https://sourceware.org/ml/newlib-cvs/2014-q3/msg00038.html Maybe make a note of the minimum newlib version supported somewhere? Others may

[PATCH] D33082: Fix Libc++ build with MinGW64

2017-05-25 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. > ! In https://reviews.llvm.org/D33082#764617, @EricWF wrote: > Defining `_GNU_SOURCE` during the library build isn't enough, it's also has > to be defined when people are using the headers, > and in that case we must depend on the compiler to pre-define it. Is it >

[PATCH] D33082: Fix Libc++ build with MinGW64

2017-05-21 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. I want to give some context here to dispel the confusion of what is and isn't win32 api specific. First lets take `vasprintf` and `asprintf ` which are not implemented in msvcrt. In mingw-w64 we would just have posix implementations of both. They are hidden behind the

[PATCH] D15005: Fix PR8170: Clang does not check constructor declaration that uses a template-id

2017-04-18 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. It won't let me revert the automatically updated diff to the previous one because I am not the author. @faisalv are you able todo this and Sorry for the confusion. Repository: rL LLVM https://reviews.llvm.org/D15005 ___

[PATCH] D15005: Fix PR8170: Clang does not check constructor declaration that uses a template-id

2017-04-18 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. In case anyone comes here looking for https://reviews.llvm.org/rL300555 that should be https://reviews.llvm.org/D15006 no https://reviews.llvm.org/D15005. Thanks Repository: rL LLVM https://reviews.llvm.org/D15005 ___

[PATCH] D15006: Driver: Better detection of mingw-gcc

2017-04-18 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. Committed as https://reviews.llvm.org/rL300555 Repository: rL LLVM https://reviews.llvm.org/D15006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D15005: Fix PR8170: Clang does not check constructor declaration that uses a template-id

2017-04-18 Thread Martell Malone via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL300555: Driver: Better detection of mingw-gcc (authored by martell). Changed prior to commit: https://reviews.llvm.org/D15005?vs=41206=95568#toc Repository: rL LLVM https://reviews.llvm.org/D15005

[PATCH] D15006: Driver: Better detection of mingw-gcc

2017-04-14 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. To clarify the most import part about actually being able to test this is the being able to modify the PATH variable for windows and unix hosts in the test case. The program prefix is less of a problem because I can double down with the same empty file one with .exe

[PATCH] D15006: Driver: Better detection of mingw-gcc

2017-04-14 Thread Martell Malone via Phabricator via cfe-commits
martell updated this revision to Diff 95292. martell edited the summary of this revision. martell added a reviewer: yaron.keren. martell added a subscriber: yaron.keren. martell added a comment. After the revert I left this patch go to pick up some other patch work. Seen as we are not anywhere