[PATCH] D138109: [clang] Fix -fp-model={strict|precise} to disable -fapprox-func

masoud.ataei accepted this revision. masoud.ataei added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138109/new/ https://reviews.llvm.org/D138109

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

masoud.ataei added a comment. In D128653#3633704 , @lenary wrote: > You likely need `// REQUIRES: powerpc-registered-target` in the top of the > test, as `-enable-ppc-gen-scalar-mass` is only present if the PowerPC target > has been compiled into LLVM.

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

masoud.ataei added a comment. Just took it down temporarily. -- Looking at it... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128653/new/ https://reviews.llvm.org/D128653 ___ cfe-commits mailing list

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

masoud.ataei updated this revision to Diff 441170. masoud.ataei added a comment. Update the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128653/new/ https://reviews.llvm.org/D128653 Files: clang/test/CodeGen/lower-mass-end-to-end.c

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

masoud.ataei updated this revision to Diff 440625. masoud.ataei added a comment. Test updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128653/new/ https://reviews.llvm.org/D128653 Files: clang/test/CodeGen/lower-mass-end-to-end.c

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

masoud.ataei updated this revision to Diff 440334. masoud.ataei added a comment. Add more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128653/new/ https://reviews.llvm.org/D128653 Files: clang/test/CodeGen/lower-mass-end-to-end.c

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

masoud.ataei created this revision. masoud.ataei added reviewers: bmahjour, renenkel, rzurob, w2yehia. masoud.ataei added a project: PowerPC. Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai. Herald added a project: All. masoud.ataei requested review of this revision. Herald added

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

masoud.ataei added a comment. Ready for another round of review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101759/new/ https://reviews.llvm.org/D101759 ___ cfe-commits mailing list

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

masoud.ataei marked 7 inline comments as done. masoud.ataei added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:386 + if (TM.getOptLevel() == CodeGenOpt::Aggressive){ +setOperationAction(ISD::FSIN , MVT::f64, Custom); +

[PATCH] D114564: Fix the use of -fno-approx-func along with -Ofast or -ffast-math

masoud.ataei added a comment. A gentle reminder for reviewers. -- This patch will fix the bug reported here: https://bugs.llvm.org/show_bug.cgi?id=52565 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114564/new/ https://reviews.llvm.org/D114564

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

masoud.ataei added inline comments. Comment at: llvm/include/llvm/Analysis/ScalarFuncs.def:19 +TLI_DEFINE_SCALAR_MASS_FUNC("acosf", "__xl_acosf") +TLI_DEFINE_SCALAR_MASS_FUNC("__acosf_finite", "__xl_acosf") +TLI_DEFINE_SCALAR_MASS_FUNC("acos", "__xl_acos")

[PATCH] D114564: Fix the use of -fno-approx-func along with -Ofast or -ffast-math

masoud.ataei added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2760 case options::OPT_fno_honor_nans: HonorNaNs = false;break; case options::OPT_fapprox_func: ApproxFunc = true;break; case

[PATCH] D114564: Fix the use of -fno-approx-func along with -Ofast or -ffast-math

masoud.ataei added a comment. Gentle reminder for reviewers. -- This PR is ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114564/new/ https://reviews.llvm.org/D114564 ___ cfe-commits

[PATCH] D114564: Fix the use of -fno-approx-func along with -Ofast or -ffast-math

masoud.ataei marked 2 inline comments as done. masoud.ataei added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2760 case options::OPT_fno_honor_nans: HonorNaNs = false;break; case options::OPT_fapprox_func: ApproxFunc = true;

[PATCH] D114564: Fix the use of -fno-approx-func along with -Ofast or -ffast-math

masoud.ataei updated this revision to Diff 389820. masoud.ataei edited the summary of this revision. masoud.ataei added a comment. Updated the test combining -ffast-math and -fno-approx-func options. @andrew.w.kaylor I hope you don't mind that I put those tests on `clang/test/Driver/fast-math.c`

[PATCH] D114564: Fix the use of -fno-approx-func along with -Ofast or -ffast-math

masoud.ataei created this revision. masoud.ataei added reviewers: andrew.w.kaylor, aaron.ballman, erichkeane, bmahjour. masoud.ataei added a project: clang. masoud.ataei requested review of this revision. Herald added a subscriber: cfe-commits. Fining the bug number Bug 52565:

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei updated this revision to Diff 378277. masoud.ataei added a comment. Update the documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106191/new/ https://reviews.llvm.org/D106191 Files: clang/docs/UsersManual.rst

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei marked an inline comment as not done. masoud.ataei added inline comments. Comment at: clang/docs/UsersManual.rst:1393 + + Allow substitution of approximate calculations for functions. + Defaults to ``-fno-approx-func``. erichkeane wrote: >

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei updated this revision to Diff 378005. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106191/new/ https://reviews.llvm.org/D106191 Files: clang/docs/UsersManual.rst clang/include/clang/Driver/Options.td

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei added inline comments. Comment at: clang/docs/UsersManual.rst:1393 + + Allow substitution of approximate calculations for functions. + Defaults to ``-fno-approx-func``. erichkeane wrote: > This seems pretty incomplete to me, I have no idea what

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei updated this revision to Diff 377909. masoud.ataei added a comment. Update the documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106191/new/ https://reviews.llvm.org/D106191 Files: clang/docs/UsersManual.rst

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei updated this revision to Diff 377904. masoud.ataei added a comment. Description and driver test are added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106191/new/ https://reviews.llvm.org/D106191 Files:

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei added a comment. Reminder for reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106191/new/ https://reviews.llvm.org/D106191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei marked 4 inline comments as done. masoud.ataei added a comment. Sorry that it took me so long to reply reviews. Thank you for reviewing this patch. Comment at: clang/include/clang/Driver/Options.td:1732-1733 NegFlag>; -def fapprox_func : Flag<["-"],

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

masoud.ataei marked an inline comment as done. masoud.ataei added a comment. In D101759#2967250 , @lebedev.ri wrote: > Do we *really* need `-enable-approx-func-fp-math`? > I'm pretty sure we are moving away from such global options, onto relying > only

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei added a comment. In D106191#2966852 , @qiucf wrote: > Making a new option mapped to another float op flag looks reasonable, but is > there any clearer motivation for this? (such as the need for `-Ofast > -fno-approx-func`) This patch

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei updated this revision to Diff 359454. masoud.ataei added a comment. Remove extra function deceleration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106191/new/ https://reviews.llvm.org/D106191 Files:

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei created this revision. masoud.ataei added reviewers: bmahjour, Whitney, nemanjai, shchenz. masoud.ataei added projects: clang, LLVM. Herald added subscribers: ormris, dang. masoud.ataei requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits. Proposing

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

masoud.ataei marked 9 inline comments as done. masoud.ataei added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:1370 + // to be consistent to PPCGenScalarMASSEntries pass + if (TM.Options.PPCGenScalarMASSEntries && TM.Options.ApproxFuncFPMath) { +

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

masoud.ataei updated this revision to Diff 359385. masoud.ataei added a comment. Removed clang changes from this PR. Removed extra option for MASS pass. Now MASS pass is active with -O3 and approx-func option. Adding another PR for clang changes on approx-func option. Repository: rG LLVM