[PATCH] D58530: Add PragmaHandler for MSVC pragma execution_character_set

2019-03-08 Thread Matt Gardner via Phabricator via cfe-commits
sigatrev added a comment. This implementation doesn't track the push/pop stack, it just verifies the synax is valid and moves on. I modeled it after the PragmaWarningHandler which does the same, and thought it would be fine in this case since the only accepted value is a no-op. CHANGES SINCE

[PATCH] D58530: Add PragmaHandler for MSVC pragma execution_character_set

2019-03-07 Thread Matt Gardner via Phabricator via cfe-commits
sigatrev added a comment. Yeah, that would be great. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58530/new/ https://reviews.llvm.org/D58530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D58530: Add PragmaHandler for MSVC pragma execution_character_set

2019-03-06 Thread Matt Gardner via Phabricator via cfe-commits
sigatrev updated this revision to Diff 189629. sigatrev added a comment. Added tests, and slightly improved associated messaging. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58530/new/ https://reviews.llvm.org/D58530 Files: clang-tools-extra/pp-trace/PPCallbacksTracker.cpp

[PATCH] D58530: Add PragmaHandler for MSVC pragma execution_character_set

2019-02-21 Thread Matt Gardner via Phabricator via cfe-commits
sigatrev created this revision. sigatrev added reviewers: cfe-commits, rnk. Herald added subscribers: jdoerfert, jsji, kbarton, nemanjai. Herald added a project: clang. __pragma(execution_character_set(push, "UTF-8")) is used in TraceLoggingProvider.h. This commit implements a no-op handler for