werbitt updated this revision to Diff 124242.
werbitt edited the summary of this revision.
werbitt added a comment.
Updating for upstream head
https://reviews.llvm.org/D37903
Files:
tools/clang-format/clang-format.el
Index: tools/clang-format/clang-format.el
werbitt updated this revision to Diff 117574.
werbitt added a comment.
Use uppercase when referring to arguments
https://reviews.llvm.org/D37903
Files:
tools/clang-format/clang-format.el
Index: tools/clang-format/clang-format.el
werbitt updated this revision to Diff 117500.
werbitt added a comment.
Thanks, I was too hasty when I tried to fix the mess I created when I diffed
against an updated master and uploaded it without noticing. I believe this diff
gets me back to where I intended.
https://reviews.llvm.org/D37903
werbitt updated this revision to Diff 116605.
werbitt added a comment.
Cleanup Docs
- The first line of of an emacs docstring should be a complete sentence.
-Specify that "-assume-filname" is a clang-format option
https://reviews.llvm.org/D37903
Files:
tools/clang-format/clang-format.el
werbitt reclaimed this revision.
werbitt added a comment.
This revision is now accepted and ready to land.
It looks like I just uploaded a diff against a bad branch, and I can't figure
out how to undo it. Sorry about that.
https://reviews.llvm.org/D37903
werbitt updated this revision to Diff 115875.
werbitt edited the summary of this revision.
werbitt added a comment.
Rename assume-file to assume-file-name and update documentation
https://reviews.llvm.org/D37903
Files:
tools/clang-format/clang-format.el
Index:
werbitt added a comment.
Hi,
Thank you very much for your feedback.
I submitted a bug here:
https://bugs.llvm.org/show_bug.cgi?id=34667
I made the changes you suggested, but I left the assume-filename optional
argument for now.
My current use-case is that when I'm editing a source block in
werbitt updated this revision to Diff 115827.
werbitt added a comment.
Clean up call-process-region
- Quote call-process-region with #', this will cause a compile time error if
call-process-region is undefined
- Pass positional arguments normally (exclude from the list)
- Instead of using
werbitt created this revision.
When 'buffer-file-name' is nil 'call-process-region' returned a segmentation
fault error.
This was a problem when using clang-format-buffer on an orgmode source code
editing buffer.
I fixed this problem by excluding the '-assume-filename' argument when
