[PATCH] D86581: [clang-format] Handle shifts within conditions

2020-09-12 Thread Miguel Saldivar via Phabricator via cfe-commits
Saldivarcher added a comment. @MyDeveloperDay looks like it's in master, thanks for committing for me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86581/new/ https://reviews.llvm.org/D86581 ___

[PATCH] D86581: [clang-format] Handle shifts within conditions

2020-08-27 Thread Miguel Saldivar via Phabricator via cfe-commits
Saldivarcher added a comment. @MyDeveloperDay thanks for the kind words, it's much appreciated! I'm just glad I was able to help. Nope, I don't have commit access, can you do me the favor of commiting for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86581: [clang-format] Handle shifts within conditions

2020-08-26 Thread Miguel Saldivar via Phabricator via cfe-commits
Saldivarcher added a comment. MyDeveloperDay, I added your tests. Sorry to step on your toes, I didn't know there was a patch open for this already :(. Yeah, JakeMerdichAMD, it's kinda tough to handle those types of cases without some sort of parsing. I'm glad you're working on that, and my

[PATCH] D86581: [clang-format] Handle shifts within conditions

2020-08-26 Thread Miguel Saldivar via Phabricator via cfe-commits
Saldivarcher updated this revision to Diff 288013. Saldivarcher added a comment. Added some more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86581/new/ https://reviews.llvm.org/D86581 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D86581: [clang-format] Handle shifts within conditions

2020-08-25 Thread Miguel Saldivar via Phabricator via cfe-commits
Saldivarcher created this revision. Saldivarcher added a reviewer: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Saldivarcher requested review of this revision. In some situation shifts can be treated as a template, and is thus formatted as one. So, by