[clang] b168bbf - [clang-format] Recognize "hxx" as a C++ header in clang-format-diff.py

Author: Miklos Vajna Date: 2020-09-18T21:43:18+02:00 New Revision: b168bbfae42e792542b4ced8729599524b9759c5 URL: https://github.com/llvm/llvm-project/commit/b168bbfae42e792542b4ced8729599524b9759c5 DIFF: https://github.com/llvm/llvm-project/commit/b168bbfae42e792542b4ced8729599524b9759c5.diff

r364014 - [git-clang-format] recognize hxx as a C++ file

Author: vmiklos Date: Fri Jun 21 02:49:38 2019 New Revision: 364014 URL: http://llvm.org/viewvc/llvm-project?rev=364014=rev Log: [git-clang-format] recognize hxx as a C++ file clangd, clang-tidy, etc does that already, no reason why git-clang-format should skip hxx files. Reviewed By:

[clang-tools-extra] r351686 - [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods

Author: vmiklos Date: Sun Jan 20 06:28:27 2019 New Revision: 351686 URL: http://llvm.org/viewvc/llvm-project?rev=351686=rev Log: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods Otherwise we don't warn on a struct containing a single public int, but we warn on

[clang-tools-extra] r350922 - [clang-tidy] new check 'readability-redundant-preprocessor'

Author: vmiklos Date: Thu Jan 10 23:59:47 2019 New Revision: 350922 URL: http://llvm.org/viewvc/llvm-project?rev=350922=rev Log: [clang-tidy] new check 'readability-redundant-preprocessor' Finds potentially redundant preprocessor directives. Reviewed By: aaron.ballman Differential Revision:

[clang-tools-extra] r350056 - [clang-tidy] add IgnoreMacros option to readability-uppercase-literal-suffix

Author: vmiklos Date: Mon Dec 24 09:47:32 2018 New Revision: 350056 URL: http://llvm.org/viewvc/llvm-project?rev=350056=rev Log: [clang-tidy] add IgnoreMacros option to readability-uppercase-literal-suffix And also enable it by default to be consistent with e.g. modernize-use-using. This helps

[clang-tools-extra] r344885 - ReleaseNotes: move readability-redundant-smartptr-get part down below new checks

Author: vmiklos Date: Sun Oct 21 23:36:30 2018 New Revision: 344885 URL: http://llvm.org/viewvc/llvm-project?rev=344885=rev Log: ReleaseNotes: move readability-redundant-smartptr-get part down below new checks Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified:

[clang-tools-extra] r344871 - [clang-tidy] add IgnoreMacros option to readability-redundant-smartptr-get

Author: vmiklos Date: Sun Oct 21 12:16:25 2018 New Revision: 344871 URL: http://llvm.org/viewvc/llvm-project?rev=344871=rev Log: [clang-tidy] add IgnoreMacros option to readability-redundant-smartptr-get And also enable it by default to be consistent with e.g. modernize-use-using. This helps

[clang-tools-extra] r344440 - [clang-tidy] add IgnoreMacros option to modernize-use-equals-delete

Author: vmiklos Date: Sat Oct 13 00:58:05 2018 New Revision: 30 URL: http://llvm.org/viewvc/llvm-project?rev=30=rev Log: [clang-tidy] add IgnoreMacros option to modernize-use-equals-delete And also enable it by default to be consistent with e.g. modernize-use-using. This improves

[clang-tools-extra] r327854 - run-clang-tidy: forward clang-tidy exit status

Author: vmiklos Date: Mon Mar 19 07:43:59 2018 New Revision: 327854 URL: http://llvm.org/viewvc/llvm-project?rev=327854=rev Log: run-clang-tidy: forward clang-tidy exit status Exit with a non-zero value in case any of the underlying clang-tidy invocations exit with a non-zero value. This is

[clang-tools-extra] r321913 - clang-tidy: add IgnoreMacros option to readability-inconsistent-declaration-parameter-name

Author: vmiklos Date: Fri Jan 5 15:22:10 2018 New Revision: 321913 URL: http://llvm.org/viewvc/llvm-project?rev=321913=rev Log: clang-tidy: add IgnoreMacros option to readability-inconsistent-declaration-parameter-name And also enable it by default to be consistent with e.g.

r312942 - clang-rename: let -force handle multiple renames

Author: vmiklos Date: Mon Sep 11 13:18:38 2017 New Revision: 312942 URL: http://llvm.org/viewvc/llvm-project?rev=312942=rev Log: clang-rename: let -force handle multiple renames Summary: The use case is that renaming multiple symbols in a large enough codebase is much faster if all of these can

[clang-tools-extra] r304534 - clang-rename: add new -force option

Author: vmiklos Date: Fri Jun 2 04:32:28 2017 New Revision: 304534 URL: http://llvm.org/viewvc/llvm-project?rev=304534=rev Log: clang-rename: add new -force option Summary: The use-case is when renaming a widely used name, like a lower-level class in a codebase and clang-rename is

[clang-tools-extra] r302429 - clang-tidy: add IgnoreMacros option to modernize-use-default-member-init

Author: vmiklos Date: Mon May 8 10:13:31 2017 New Revision: 302429 URL: http://llvm.org/viewvc/llvm-project?rev=302429=rev Log: clang-tidy: add IgnoreMacros option to modernize-use-default-member-init Summary: And also enable it by default to be consistent with e.g. modernize-use-using. This

[clang-tools-extra] r301130 - clang-rename: fix formatting

Author: vmiklos Date: Sun Apr 23 11:07:06 2017 New Revision: 301130 URL: http://llvm.org/viewvc/llvm-project?rev=301130=rev Log: clang-rename: fix formatting As detected by clang-format. Modified: clang-tools-extra/trunk/clang-rename/RenamingAction.cpp

Re: [PATCH] D24567: [clang-rename] Merge rename-{at|all} & optimise.

vmiklos added a comment. As mentioned earlier, I have no problem with merging rename-at and rename-all. https://reviews.llvm.org/D24567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24224: [clang-rename] Merge rename-{ at | all } and optimise USRFindingAction.

vmiklos added a comment. Sure, I have no problems merging rename-all and rename-at, I added it as it looked like a good idea at that time. https://reviews.llvm.org/D24224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

vmiklos added a comment. Ah, if you mean you squashed this into https://reviews.llvm.org/D24192, then I see what you mean, ignore me. :-) https://reviews.llvm.org/D23651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r280063 - clang-rename: fix formatting in USRFinder

Author: vmiklos Date: Tue Aug 30 02:24:57 2016 New Revision: 280063 URL: http://llvm.org/viewvc/llvm-project?rev=280063=rev Log: clang-rename: fix formatting in USRFinder As detected by clang-format. Modified: clang-tools-extra/trunk/clang-rename/USRFinder.cpp Modified:

Re: [PATCH] D24002: clang-rename: improve error message when -old-name is used and could not find symbol

This revision was automatically updated to reflect the committed changes. Closed by commit rL280062: clang-rename: improve error message when -old-name is used and could not find… (authored by vmiklos). Changed prior to commit: https://reviews.llvm.org/D24002?vs=69644=69646#toc Repository:

[clang-tools-extra] r280062 - clang-rename: improve error message when -old-name is used and could not find symbol

Author: vmiklos Date: Tue Aug 30 02:23:24 2016 New Revision: 280062 URL: http://llvm.org/viewvc/llvm-project?rev=280062=rev Log: clang-rename: improve error message when -old-name is used and could not find symbol Old output was: clang-rename: could not find symbol at

Re: [PATCH] D24002: clang-rename: improve error message when -old-name is used and could not find symbol

vmiklos marked an inline comment as done. vmiklos added a comment. > Probably something like "could not find symbol OldName" would be reasonable, > too. OK, changed. https://reviews.llvm.org/D24002 ___ cfe-commits mailing list

Re: [PATCH] D24002: clang-rename: improve error message when -old-name is used and could not find symbol

vmiklos updated this revision to Diff 69644. https://reviews.llvm.org/D24002 Files: clang-rename/USRFindingAction.cpp test/clang-rename/InvalidOldName.cpp Index: test/clang-rename/InvalidOldName.cpp === --- /dev/null +++

[PATCH] D24002: clang-rename: improve error message when -old-name is used and could not find symbol

vmiklos created this revision. vmiklos added reviewers: klimek, omtcyfz. vmiklos added a subscriber: cfe-commits. Old output was: clang-rename: could not find symbol at tools/clang/tools/extra/test/clang-rename/ClassFindByName.cpp:1:1 (offset 0). https://reviews.llvm.org/D24002 Files:

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

vmiklos added a comment. > If I understood correctly, you and Alex are talking about different things. Yes, sorry, the context of my above comment was the cl::opt instances in the tool itself, not the various parameters to the different actions called from the tool.

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

vmiklos added a comment. It is expected that either SymbolOffsets or OldNames is empty, and the size of the non-empty container is the same as the size of the NewNames container. So no, the code does not rely on the offsets and the old names having the same length.

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

vmiklos added a comment. I can confirm that with this, the test script from the mail thread shows that clang-rename is almost as fast as clang++ as expected. Thanks! https://reviews.llvm.org/D23651 ___ cfe-commits mailing list

Re: [clang-tools-extra] r278295 - [Documentation] Improve consistency.

Hi Eugene, On Wed, Aug 10, 2016 at 10:00:50PM -, Eugene Zelenko via cfe-commits wrote: > Modified: clang-tools-extra/trunk/docs/clang-rename.rst > URL: >

Re: [PATCH] D23198: clang-rename rename-all: support reading old/newname pairs from a YAML file

vmiklos added a comment. In https://reviews.llvm.org/D23198#510269, @alexfh wrote: > A few late comments. I've addressed these in r278201. Repository: rL LLVM https://reviews.llvm.org/D23198 ___ cfe-commits mailing list

[clang-tools-extra] r278201 - clang-rename YAML reader: address post-commit comments

Author: vmiklos Date: Wed Aug 10 02:13:29 2016 New Revision: 278201 URL: http://llvm.org/viewvc/llvm-project?rev=278201=rev Log: clang-rename YAML reader: address post-commit comments Modified: clang-tools-extra/trunk/clang-rename/tool/ClangRename.cpp

Re: [PATCH] D23198: clang-rename rename-all: support reading old/newname pairs from a YAML file

This revision was automatically updated to reflect the committed changes. Closed by commit rL278145: clang-rename rename-all: support reading old/newname pairs from a YAML file (authored by vmiklos). Changed prior to commit: https://reviews.llvm.org/D23198?vs=67215=67381#toc Repository: rL

[clang-tools-extra] r278145 - clang-rename rename-all: support reading old/newname pairs from a YAML file

Author: vmiklos Date: Tue Aug 9 13:20:41 2016 New Revision: 278145 URL: http://llvm.org/viewvc/llvm-project?rev=278145=rev Log: clang-rename rename-all: support reading old/newname pairs from a YAML file This is handy in case by the time clang-rename is invoked, an external tool already

Re: [PATCH] D23198: clang-rename rename-all: support reading old/newname pairs from a YAML file

vmiklos added inline comments. Comment at: clang-rename/tool/ClangRename.cpp:65 @@ +64,3 @@ + + RenameAllInfo() : Offset(0) {} +}; omtcyfz wrote: > omtcyfz wrote: > > vmiklos wrote: > > > omtcyfz wrote: > > > > AFAIK there's no need to do that, integer types are

Re: [PATCH] D23198: clang-rename rename-all: support reading old/newname pairs from a YAML file

vmiklos added inline comments. Comment at: clang-rename/tool/ClangRename.cpp:65 @@ +64,3 @@ + + RenameAllInfo() : Offset(0) {} +}; omtcyfz wrote: > AFAIK there's no need to do that, integer types are by default initialized > with 0, aren't they? Are you sure?

Re: [PATCH] D23198: clang-rename rename-all: support reading old/newname pairs from a YAML file

vmiklos added a comment. > .cpp.rename-at.yaml? I just discovered that lit provides %S that allows getting rid of the confusing .cpp.yaml, I'm using that now. > Ah, and yes, it's better to move *.yaml to extra/test/clang-rename/Inputs Done. https://reviews.llvm.org/D23198

Re: [PATCH] D23198: clang-rename rename-all: support reading old/newname pairs from a YAML file

vmiklos updated this revision to Diff 67215. https://reviews.llvm.org/D23198 Files: clang-rename/tool/ClangRename.cpp docs/clang-rename.rst test/clang-rename/ClassTestMultiByNameYAML.cpp test/clang-rename/Inputs/ClassTestMultiByNameYAMLRenameAll.yaml

Re: [PATCH] D23198: clang-rename rename-all: support reading old/newname pairs from a YAML file

vmiklos marked 2 inline comments as done. vmiklos added a comment. > Would also be nice to support at least `offset + new-name` in YAML input > files, too. Done. > Please move this block upwards [preferably right after line 42]. I consider > information about limitations and editor more

Re: [PATCH] D23198: clang-rename rename-all: support reading old/newname pairs from a YAML file

vmiklos updated this revision to Diff 66993. https://reviews.llvm.org/D23198 Files: clang-rename/tool/ClangRename.cpp docs/clang-rename.rst test/clang-rename/ClassTestMultiByNameYAML.cpp test/clang-rename/ClassTestMultiByNameYAML.cpp.rename-all.yaml

Re: [PATCH] D23198: clang-rename rename-all: support reading old/newname pairs from a YAML file

vmiklos added inline comments. Comment at: clang-rename/tool/ClangRename.cpp:140 @@ -116,1 +139,3 @@ cl::value_desc("filename"), cl::cat(*Category)); + cl::opt Input( + "input", cl::desc("YAML file to load oldname-newname pairs from."), omtcyfz

Re: [PATCH] D23198: clang-rename rename-all: support reading old/newname pairs from a YAML file

vmiklos added a comment. As a side note, this is the last feature that LibreOffice's simple clang-based rename tool (https://cgit.freedesktop.org/libreoffice/contrib/dev-tools/tree/clang/rename.cxx) supports, and clang-rename does not. (That one takes a CSV file, but in case -export-fixes

[PATCH] D23198: clang-rename rename-all: support reading old/newname pairs from a YAML file

vmiklos created this revision. vmiklos added reviewers: klimek, omtcyfz. vmiklos added a subscriber: cfe-commits. This is handy in case by the time clang-rename is invoked, an external tool already genereated a list of oldname -> newname pairs to handle. https://reviews.llvm.org/D23198 Files:

Re: [PATCH] D23153: Run clang-format on clang-rename code

vmiklos added a comment. Thanks. Yes, I used the Linux-distro-provided clang-format-3.7, I didn't notice that the trunk version now also sorts includes. Repository: rL LLVM https://reviews.llvm.org/D23153 ___ cfe-commits mailing list

Re: [PATCH] D23153: Run clang-format on clang-rename code

This revision was automatically updated to reflect the committed changes. Closed by commit rL277702: Run clang-format on clang-rename code (authored by vmiklos). Changed prior to commit: https://reviews.llvm.org/D23153?vs=66766=66769#toc Repository: rL LLVM https://reviews.llvm.org/D23153

[clang-tools-extra] r277702 - Run clang-format on clang-rename code

Author: vmiklos Date: Thu Aug 4 02:43:29 2016 New Revision: 277702 URL: http://llvm.org/viewvc/llvm-project?rev=277702=rev Log: Run clang-format on clang-rename code So that later commits don't introduce non-functional changes when running clang-format before committing. Reviewers: klimek

[PATCH] D23153: Run clang-format on clang-rename code

vmiklos created this revision. vmiklos added reviewers: klimek, omtcyfz. vmiklos added a subscriber: cfe-commits. So that later commits don't introduce non-functional changes when running clang-format before committing. https://reviews.llvm.org/D23153 Files: clang-rename/RenamingAction.h

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos added a comment. Yes, I did that -- but I got no conflicts there. ;-) Repository: rL LLVM https://reviews.llvm.org/D21814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r277438 - clang-rename: split existing options into two new subcommands

Author: vmiklos Date: Tue Aug 2 04:51:31 2016 New Revision: 277438 URL: http://llvm.org/viewvc/llvm-project?rev=277438=rev Log: clang-rename: split existing options into two new subcommands - rename-at is meant to be integrated with editors and works mainly off of a location in a file, and

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

This revision was automatically updated to reflect the committed changes. Closed by commit rL277438: clang-rename: split existing options into two new subcommands (authored by vmiklos). Changed prior to commit: https://reviews.llvm.org/D21814?vs=66362=66448#toc Repository: rL LLVM

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos added a comment. Rebased on top of r277356 and resolved conflicts. (A busy day, it seems. :-) ) https://reviews.llvm.org/D21814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos updated this revision to Diff 66362. https://reviews.llvm.org/D21814 Files: clang-rename/RenamingAction.cpp clang-rename/RenamingAction.h clang-rename/tool/ClangRename.cpp docs/clang-rename.rst test/clang-rename/ClassFindByName.cpp test/clang-rename/ClassTestMulti.cpp

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos added a comment. Rebased on top of r277339 and resolved conflicts. https://reviews.llvm.org/D21814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos updated this revision to Diff 66304. https://reviews.llvm.org/D21814 Files: clang-rename/RenamingAction.cpp clang-rename/RenamingAction.h clang-rename/tool/ClangRename.cpp docs/clang-rename.rst test/clang-rename/ClassFindByName.cpp test/clang-rename/ClassTestMulti.cpp

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos added a comment. Great! Manuel, OK to land? https://reviews.llvm.org/D21814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos added a comment. Yes, exactly, so not easy to customize I guess. https://reviews.llvm.org/D21814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos added a comment. In https://reviews.llvm.org/D21814#500621, @omtcyfz wrote: > P.S. not sure whether we have to write `clang-rename: for the -new-name > option: must be specified` out. We already launched `clang-rename` what else > could've give us an error? You mean how is that error

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos added a comment. > Just write a FIXME then, I think I may look into that on the next week or > somewhen. Done. > Most of the time I use Foo->Bar renaming in tests Done, I've renamed ClaN->KlaN to FooN->BarN. https://reviews.llvm.org/D21814

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos added a comment. Rebased on top of r277131 and resolved conflicts. > As for help message, look at clang-tidy. Is there a need in helpMain? I think so; we have this chicken-and-egg problem (see earlier comments of this review), that the options parser wants to know the option category,

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos updated this revision to Diff 66105. https://reviews.llvm.org/D21814 Files: clang-rename/RenamingAction.cpp clang-rename/RenamingAction.h clang-rename/tool/ClangRename.cpp docs/clang-rename.rst test/clang-rename/ClassFindByName.cpp test/clang-rename/ClassTestMulti.cpp

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos added a subscriber: Eugene.Zelenko. vmiklos added a comment. > 1. Run `clang-format` or something, 80 char width limit is broken in > `tool/ClangRename.cpp` dozen of times. Done. I was afraid doing that, due to the changes not related to my patch, but the result doesn't seem to be too

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos updated this revision to Diff 66099. https://reviews.llvm.org/D21814 Files: clang-rename/RenamingAction.cpp clang-rename/RenamingAction.h clang-rename/tool/ClangRename.cpp docs/clang-rename.rst test/clang-rename/ClassFindByName.cpp test/clang-rename/ClassTestMulti.cpp

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos added a comment. Is there anything I can help with to get this accepted, please? As far as I see I addressed all so far mentioned concerns. Thanks. https://reviews.llvm.org/D21814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos added a comment. Rebased on top of r276949 and resolved a failing test (FunctionWithClassFindByName.cpp). https://reviews.llvm.org/D21814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos updated this revision to Diff 65876. https://reviews.llvm.org/D21814 Files: clang-rename/RenamingAction.cpp clang-rename/RenamingAction.h clang-rename/tool/ClangRename.cpp docs/clang-rename.rst test/clang-rename/ClassFindByName.cpp test/clang-rename/ClassTestMulti.cpp

Re: [PATCH] D22854: change Vim key binding for include-fixer and clang-rename

vmiklos added a subscriber: vmiklos. vmiklos added a comment. `:help leader` explains it. Or see this link: http://learnvimscriptthehardway.stevelosh.com/chapters/06.html#leader. The later describes 3 arguments for using `` instead of `,` directly. https://reviews.llvm.org/D22854

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos marked 2 inline comments as done. vmiklos added a comment. > rename-at isn't necessary here anymore since it's going to be default > behavior IIUC Indeed, it can be changed back now, done. > docs should be fixed correspondingly; i.e. prefer to write clang-rename > -offset=42 over

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos updated this revision to Diff 65684. https://reviews.llvm.org/D21814 Files: clang-rename/RenamingAction.cpp clang-rename/RenamingAction.h clang-rename/tool/ClangRename.cpp docs/clang-rename.rst test/clang-rename/ClassFindByName.cpp test/clang-rename/ClassTestMulti.cpp

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos added a comment. Rebased on top of r276836 and resolved conflicts. https://reviews.llvm.org/D21814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos updated this revision to Diff 65672. https://reviews.llvm.org/D21814 Files: clang-rename/RenamingAction.cpp clang-rename/RenamingAction.h clang-rename/tool/ClangRename.cpp clang-rename/tool/clang-rename.py docs/clang-rename.rst test/clang-rename/ClassFindByName.cpp

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos added a comment. Rebased on top of r276684 and resolved conflicts. https://reviews.llvm.org/D21814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos updated this revision to Diff 65417. https://reviews.llvm.org/D21814 Files: clang-rename/RenamingAction.cpp clang-rename/RenamingAction.h clang-rename/tool/ClangRename.cpp clang-rename/tool/clang-rename.py docs/clang-rename.rst test/clang-rename/ClassFindByName.cpp

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos updated this revision to Diff 65042. https://reviews.llvm.org/D21814 Files: clang-rename/RenamingAction.cpp clang-rename/RenamingAction.h clang-rename/tool/ClangRename.cpp clang-rename/tool/clang-rename.py docs/clang-rename.rst test/clang-rename/ClassFindByName.cpp

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos added a comment. Done, that also allows not modifying most existing tests. https://reviews.llvm.org/D21814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos added a comment. In https://reviews.llvm.org/D21814#492540, @omtcyfz wrote: > I'd be actually happy if instead of having `-rename-at` option we'd have this > behavior by default unless `-rename-all` is used. Not sure I understand this request. rename-at and rename-all all subcommands,

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos marked an inline comment as done. vmiklos added a comment. https://reviews.llvm.org/D21814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos updated this revision to Diff 65031. https://reviews.llvm.org/D21814 Files: clang-rename/RenamingAction.cpp clang-rename/RenamingAction.h clang-rename/tool/ClangRename.cpp clang-rename/tool/clang-rename.py docs/clang-rename.rst test/clang-rename/ClassFindByName.cpp

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos added inline comments. Comment at: clang-rename/RenamingAction.cpp:48 @@ +47,3 @@ +for (unsigned I = 0; I < NewNameList.size(); ++I) { + HandleOneRename(Context, NewNameList[I], PrevNameList[I], USRList[I]); +} klimek wrote: > Question is

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos updated this revision to Diff 64941. https://reviews.llvm.org/D21814 Files: clang-rename/RenamingAction.cpp clang-rename/RenamingAction.h clang-rename/tool/ClangRename.cpp clang-rename/tool/clang-rename.py docs/clang-rename.rst test/clang-rename/ClassFindByName.cpp

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos added a comment. Rebased on top of r276282 and resolved conflicts. https://reviews.llvm.org/D21814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos marked an inline comment as done. vmiklos added a comment. https://reviews.llvm.org/D21814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos added a comment. > The patch looks fine to me (though I'm not sure if there are no new tests; if > they are interface changes should be applied). `make check-clang-tools` + the patch at r276098 passes for me at least. But any pending test should be trivial to adapt. > P.S. it seems

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos updated this revision to Diff 64859. https://reviews.llvm.org/D21814 Files: clang-rename/RenamingAction.cpp clang-rename/RenamingAction.h clang-rename/tool/ClangRename.cpp clang-rename/tool/clang-rename.py docs/clang-rename.rst test/clang-rename/ClassFindByName.cpp

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos added a comment. Is there anything I can help with to get this reviewed, please? As far as I see it still applies cleanly on top of current trunk. https://reviews.llvm.org/D21814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos added a comment. In https://reviews.llvm.org/D21814#486204, @omtcyfz wrote: > - Can you please update diff? I changed most of the tests recently. Sure, I actually wanted to ask if those test additions were meant to be test renames. :-) > - I think you should update `doc/clang-rename`

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos updated this revision to Diff 64231. https://reviews.llvm.org/D21814 Files: clang-rename/tool/ClangRename.cpp clang-rename/tool/clang-rename.py docs/clang-rename.rst test/clang-rename/ClassFindByName.cpp test/clang-rename/ClassReplacements.cpp

Re: [PATCH] D22237: clang-rename: fix renaming member functions

vmiklos abandoned this revision. vmiklos added a comment. I see your point, then let me abandon this. https://reviews.llvm.org/D22237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos added a comment. I've implemented the requested split of options, now there are two new rename-at and rename-all subcommands. The only common options is -i and -new-name, nothing else is shared, apart from the common options added by `tooling::CommonOptionsParser`. The code is modeled

Re: [PATCH] D21814: clang-rename: support multiple renames with one invocation

vmiklos updated this revision to Diff 64204. https://reviews.llvm.org/D21814 Files: clang-rename/tool/ClangRename.cpp test/clang-rename/ClassFindByName.cpp test/clang-rename/ClassReplacements.cpp test/clang-rename/ClassSimpleRenaming.cpp test/clang-rename/ClassTest.cpp

Re: [PATCH] D21814: clang-rename: support multiple renames with one invocation

vmiklos added a comment. I'm a bit confused. On one hand, I want to use tooling::CommonOptionsParser to parse the options, which needs a cl::OptionCategory as a parameter. On the other hand, I want to parse the options, based on that I'll know what subcommand was requested, and then I can

Re: [PATCH] D21814: clang-rename: support multiple renames with one invocation

vmiklos added a comment. The alternative is to change the `CommonOptionsParser` ctor to take a vector of `OptionCategory&`, and in that case we can add the -extra-arg-before and other options to all subcommands, but that means he'll have to adapt all client code, i.e. all tools in

Re: [PATCH] D22237: clang-rename: fix renaming member functions

vmiklos updated this revision to Diff 64027. https://reviews.llvm.org/D22237 Files: clang-rename/USRLocFinder.cpp test/clang-rename/VirtualFunction.cpp Index: test/clang-rename/VirtualFunction.cpp === --- /dev/null +++

Re: [PATCH] D22237: clang-rename: fix renaming member functions

vmiklos added a comment. Forgot to add asserts for main() in the testcase. https://reviews.llvm.org/D22237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22237: clang-rename: fix renaming member functions

vmiklos updated this revision to Diff 64025. https://reviews.llvm.org/D22237 Files: clang-rename/USRLocFinder.cpp test/clang-rename/VirtualFunction.cpp Index: test/clang-rename/VirtualFunction.cpp === --- /dev/null +++

Re: [PATCH] D22102: [clang-rename] extend testset

vmiklos added a subscriber: vmiklos. vmiklos added a comment. Can you please avoid adding VirtualFunction.cpp? http://reviews.llvm.org/D22237 would add it as well, but without the FIXME. Thanks! :-) http://reviews.llvm.org/D22102 ___ cfe-commits

Re: [PATCH] D21814: clang-rename: support multiple renames with one invocation

vmiklos added a comment. As far as I see `tooling::CommonOptionsParser` (in its current form) does not handle cl::SubCommand instances. Should I fix that or would it be OK to switch to using `cl::ParseCommandLineOptions` directly in clang-rename? http://reviews.llvm.org/D21814

Re: [PATCH] D22091: [clang-rename] exit code-related bugfix and code cleanup

vmiklos added a comment. In http://reviews.llvm.org/D22091#476756, @vmiklos wrote: > Can you please postpone the cleanup till http://reviews.llvm.org/D21814 is > reviewed? The two patches conflict with each other, I fear. Thanks. :-) Ignore this, that one won't land as-is after all.

Re: [PATCH] D22091: [clang-rename] exit code-related bugfix and code cleanup

vmiklos added a subscriber: vmiklos. vmiklos added a comment. Can you please postpone the cleanup till http://reviews.llvm.org/D21814 is reviewed? The two patches conflict with each other, I fear. Thanks. :-) http://reviews.llvm.org/D22091 ___

Re: [PATCH] D21814: clang-rename: support multiple renames with one invocation

vmiklos added a comment. Manuel, do you have an opinion on this, please? http://reviews.llvm.org/D21814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r273941 - clang-rename: try to make ClassTestReplacements more reliable

Author: vmiklos Date: Mon Jun 27 16:04:53 2016 New Revision: 273941 URL: http://llvm.org/viewvc/llvm-project?rev=273941=rev Log: clang-rename: try to make ClassTestReplacements more reliable As it failed on e.g.

Re: [PATCH] D21676: clang-rename: add a -export-fixes option

This revision was automatically updated to reflect the committed changes. Closed by commit rL273910: clang-rename: add a -export-fixes option (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D21676?vs=61833=62004#toc Repository: rL LLVM http://reviews.llvm.org/D21676

[clang-tools-extra] r273910 - clang-rename: add a -export-fixes option

Author: vmiklos Date: Mon Jun 27 14:34:47 2016 New Revision: 273910 URL: http://llvm.org/viewvc/llvm-project?rev=273910=rev Log: clang-rename: add a -export-fixes option Use case: a class is declared in a header, and defined in two translation units. clang-rename is asked to rename a class

Re: [clang-tools-extra] r273786 - [clang-tidy] Add modernize-use-using

Hi, On Sat, Jun 25, 2016 at 06:37:54PM -, Krystyna Gajczyk via cfe-commits wrote: > Author: krystynka > Date: Sat Jun 25 13:37:53 2016 > New Revision: 273786 > > URL: http://llvm.org/viewvc/llvm-project?rev=273786=rev > Log: > [clang-tidy] Add

  1   2   >