[PATCH] D82740: [libclang]: check validity before visiting Stmt node

milianw abandoned this revision. milianw added a comment. great, thanks for the help - please land the other change then Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82740/new/ https://reviews.llvm.org/D82740 ___

[PATCH] D82740: [libclang]: check validity before visiting Stmt node

milianw added a comment. @jkorous ping? can you chime in on either of the two patches? I'm fine with either, and D82629 comes with a test too. So maybe let's just go with that one? If so, could you integrate that one please? Repository: rG LLVM Github Monore

[PATCH] D82740: [libclang]: check validity before visiting Stmt node

milianw added a comment. @jkorous how would you use a debugger (would be GDB for me) to find the source - I would have to use RR or something like that to see why and where the invalid node is added, no? I also don't have the breaking code at hand anymore, I can try to come up with a way to re

[PATCH] D82740: [libclang]: check validity before visiting Stmt node

milianw added a comment. Also see https://reviews.llvm.org/D82629 which I believe is also a fix for this crash. But I didn't use a VLA in my code, but maybe the parse error just triggered something similar like that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D82629: [libclang] Fix crash when visiting a captured VLA.

milianw added a comment. this relates to https://reviews.llvm.org/D82740 too, but comes with a test which is good. personally I would place the check directly within Visit to make it more generically prevent a crash on invalid input, but that's probably a subjective design decision. Repositor

[PATCH] D82740: [libclang]: check validity before visiting Stmt node

milianw added a comment. I'm not sure how to write a unit test for this, but I ran into a reproducible crash with a complex C++ file which got fixed by this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82740/new/ https://reviews.llvm.org/D8

[PATCH] D82740: [libclang]: check validity before visiting Stmt node

milianw created this revision. milianw added reviewers: bkramer, yvvan, nik. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. Fixes crash when visiting a partial AST after encountering a parse error in the input code: #5 clang::Stmt::getStmtClass (this=) at llvm

[PATCH] D78213: [libclang]: visit BindingDecl in DecompositionDecl

milianw added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78213/new/ https://reviews.llvm.org/D78213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D78214: [libclang]: visit C++17 if init statements

milianw added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78214/new/ https://reviews.llvm.org/D78214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D78214: [libclang]: visit C++17 if init statements

milianw created this revision. milianw added reviewers: nik, yvvan. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. This makes the previously unaccessible AST nodes for C++17 "if with init statements" accessible to consumers of libclang. Repository: rG LLVM Gith

[PATCH] D78213: [libclang]: visit BindingDecl in DecompositionDecl

milianw created this revision. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. milianw added reviewers: nik, yvvan. This makes the BindingDecl accessible to consumers of libclang as CXCursor_UnexposedDecl where previously these AST nodes were not visited at all from

[PATCH] D60672: [libclang] visit c++14 lambda capture init expressions

milianw added a comment. thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60672/new/ https://reviews.llvm.org/D60672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[PATCH] D60672: [libclang] visit c++14 lambda capture init expressions

milianw added a comment. Do you have commit rights? Can you push that for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60672/new/ https://reviews.llvm.org/D60672 ___ cfe-commits mailing list cfe-c

[PATCH] D60672: [libclang] visit c++14 lambda capture init expressions

milianw added a comment. @nik odd, it works for me, I just switched to master (previously I used the 8x release branch) and applied this patch and build it all. Then I run: $ make && ./bin/llvm-lit ~/projects/src/llvm-project/clang/test/Index/cxx14-lambdas.cpp makeobj[0]: Entering directory

[PATCH] D60672: [libclang] visit c++14 lambda capture init expressions

milianw created this revision. milianw added reviewers: clang-c, cfe-commits, hokein, nik, yvvan, marcobubke. Herald added a subscriber: arphaman. Herald added a project: clang. Previously, libclang users could visit the non-init C++11 lambda captures, e.g. `[foo]`. But C++14 init-captures such as

[PATCH] D43763: libclang: Visit class template instantiations

milianw added a comment. Herald added a subscriber: arphaman. Herald added a project: clang. looks good, but this needs a test, could you add one please? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43763/new/ https://reviews.llvm.org/D43763 _

[PATCH] D37650: [continued] Add a way to get the CXCursor that corresponds to a completion result

milianw requested changes to this revision. milianw added a comment. This revision now requires changes to proceed. I'm pretty sure this is not ABI compatible. You change the size of `CXCompletionResult`, so when anyone is iterating over the array in `CXCompletionResults` it will break. If you d

[PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

milianw added a comment. still looks good to me. can someone else please review and commit this? Repository: rC Clang https://reviews.llvm.org/D10833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li